From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
<ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH libdrm] amdgpu: fix off by one in handle_table_insert
Date: Thu, 16 Aug 2018 08:50:48 +0800 [thread overview]
Message-ID: <5B74CA68.3040401@amd.com> (raw)
In-Reply-To: <20180815112555.3240-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
On 08/15/2018 07:25 PM, Christian König wrote:
> Stupid me, max_key must always be larger than key.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Good catch
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
> ---
> amdgpu/handle_table.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/amdgpu/handle_table.c b/amdgpu/handle_table.c
> index 15cd4763..4fdd29d3 100644
> --- a/amdgpu/handle_table.c
> +++ b/amdgpu/handle_table.c
> @@ -33,7 +33,7 @@ drm_private int handle_table_insert(struct handle_table *table, uint32_t key,
> {
> if (key >= table->max_key) {
> uint32_t alignment = sysconf(_SC_PAGESIZE) / sizeof(void*);
> - uint32_t max_key = ALIGN(key, alignment);
> + uint32_t max_key = ALIGN(key + 1, alignment);
> void **values;
>
> values = realloc(table->values, max_key * sizeof(void *));
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-08-16 0:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 11:25 [PATCH libdrm] amdgpu: fix off by one in handle_table_insert Christian König
[not found] ` <20180815112555.3240-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-08-15 13:58 ` Michel Dänzer
2018-08-16 0:50 ` Zhang, Jerry (Junwei) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B74CA68.3040401@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox