From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 07/10] drm/amdgpu: stop using gart_start as offset for the GTT domain Date: Tue, 28 Aug 2018 10:10:06 +0800 Message-ID: <5B84AEFE.9090400@amd.com> References: <20180827165337.1651-1-christian.koenig@amd.com> <20180827165337.1651-7-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Cc: amd-gfx list T24gMDgvMjgvMjAxOCAwMzowNyBBTSwgQWxleCBEZXVjaGVyIHdyb3RlOgo+IE9uIE1vbiwgQXVn IDI3LCAyMDE4IGF0IDEyOjU2IFBNIENocmlzdGlhbiBLw7ZuaWcKPiA8Y2tvZW5pZy5sZWljaHR6 dW1lcmtlbkBnbWFpbC5jb20+IHdyb3RlOgo+Pgo+PiBGdXJ0aGVyIHNlcGFyYXRlIEdBUlQgYW5k IEdUVCBkb21haW4uCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4KPgo+IFJldmlld2VkLWJ5OiBBbGV4IERldWNoZXIgPGFsZXhh bmRlci5kZXVjaGVyQGFtZC5jb20+CgpSZXZpZXdlZC1ieTogSnVud2VpIFpoYW5nIDxKZXJyeS5a aGFuZ0BhbWQuY29tPgoKPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfZ3R0X21nci5jIHwgMyArKy0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfdHRtLmMgICAgIHwgNiArKystLS0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0 aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9ndHRfbWdyLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfZ3R0X21nci5jCj4+IGluZGV4IGRhN2IxYjkyZDljZi4uYzI1MzlmNjgyMWMwIDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ3R0X21nci5j Cj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9ndHRfbWdyLmMKPj4g QEAgLTE0Myw3ICsxNDMsOCBAQCBzdGF0aWMgaW50IGFtZGdwdV9ndHRfbWdyX2FsbG9jKHN0cnVj dCB0dG1fbWVtX3R5cGVfbWFuYWdlciAqbWFuLAo+PiAgICAgICAgICBzcGluX3VubG9jaygmbWdy LT5sb2NrKTsKPj4KPj4gICAgICAgICAgaWYgKCFyKQo+PiAtICAgICAgICAgICAgICAgbWVtLT5z dGFydCA9IG5vZGUtPm5vZGUuc3RhcnQ7Cj4+ICsgICAgICAgICAgICAgICBtZW0tPnN0YXJ0ID0g bm9kZS0+bm9kZS5zdGFydCArCj4+ICsgICAgICAgICAgICAgICAgICAgICAgIChhZGV2LT5nbWMu Z2FydF9zdGFydCA+PiBQQUdFX1NISUZUKTsKPj4KPj4gICAgICAgICAgcmV0dXJuIHI7Cj4+ICAg fQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5j IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4+IGluZGV4IDJmMzA0 ZjlkZDU0My4uNWNhZGY0ZjFlZTJjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfdHRtLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X3R0bS5jCj4+IEBAIC0xODgsNyArMTg4LDcgQEAgc3RhdGljIGludCBhbWRncHVfaW5p dF9tZW1fdHlwZShzdHJ1Y3QgdHRtX2JvX2RldmljZSAqYmRldiwgdWludDMyX3QgdHlwZSwKPj4g ICAgICAgICAgY2FzZSBUVE1fUExfVFQ6Cj4+ICAgICAgICAgICAgICAgICAgLyogR1RUIG1lbW9y eSAgKi8KPj4gICAgICAgICAgICAgICAgICBtYW4tPmZ1bmMgPSAmYW1kZ3B1X2d0dF9tZ3JfZnVu YzsKPj4gLSAgICAgICAgICAgICAgIG1hbi0+Z3B1X29mZnNldCA9IGFkZXYtPmdtYy5nYXJ0X3N0 YXJ0Owo+PiArICAgICAgICAgICAgICAgbWFuLT5ncHVfb2Zmc2V0ID0gMDsKPj4gICAgICAgICAg ICAgICAgICBtYW4tPmF2YWlsYWJsZV9jYWNoaW5nID0gVFRNX1BMX01BU0tfQ0FDSElORzsKPj4g ICAgICAgICAgICAgICAgICBtYW4tPmRlZmF1bHRfY2FjaGluZyA9IFRUTV9QTF9GTEFHX0NBQ0hF RDsKPj4gICAgICAgICAgICAgICAgICBtYW4tPmZsYWdzID0gVFRNX01FTVRZUEVfRkxBR19NQVBQ QUJMRSB8IFRUTV9NRU1UWVBFX0ZMQUdfQ01BOwo+PiBAQCAtMTA2Miw3ICsxMDYyLDcgQEAgc3Rh dGljIGludCBhbWRncHVfdHRtX2JhY2tlbmRfYmluZChzdHJ1Y3QgdHRtX3R0ICp0dG0sCj4+ICAg ICAgICAgIGZsYWdzID0gYW1kZ3B1X3R0bV90dF9wdGVfZmxhZ3MoYWRldiwgdHRtLCBib19tZW0p Owo+Pgo+PiAgICAgICAgICAvKiBiaW5kIHBhZ2VzIGludG8gR0FSVCBwYWdlIHRhYmxlcyAqLwo+ PiAtICAgICAgIGd0dC0+b2Zmc2V0ID0gKHU2NClib19tZW0tPnN0YXJ0IDw8IFBBR0VfU0hJRlQ7 Cj4+ICsgICAgICAgZ3R0LT5vZmZzZXQgPSAoKHU2NClib19tZW0tPnN0YXJ0IDw8IFBBR0VfU0hJ RlQpIC0gYWRldi0+Z21jLmdhcnRfc3RhcnQ7Cj4+ICAgICAgICAgIHIgPSBhbWRncHVfZ2FydF9i aW5kKGFkZXYsIGd0dC0+b2Zmc2V0LCB0dG0tPm51bV9wYWdlcywKPj4gICAgICAgICAgICAgICAg ICB0dG0tPnBhZ2VzLCBndHQtPnR0bS5kbWFfYWRkcmVzcywgZmxhZ3MpOwo+Pgo+PiBAQCAtMTEx MCw3ICsxMTEwLDcgQEAgaW50IGFtZGdwdV90dG1fYWxsb2NfZ2FydChzdHJ1Y3QgdHRtX2J1ZmZl cl9vYmplY3QgKmJvKQo+PiAgICAgICAgICBmbGFncyA9IGFtZGdwdV90dG1fdHRfcHRlX2ZsYWdz KGFkZXYsIGJvLT50dG0sICZ0bXApOwo+Pgo+PiAgICAgICAgICAvKiBCaW5kIHBhZ2VzICovCj4+ IC0gICAgICAgZ3R0LT5vZmZzZXQgPSAodTY0KXRtcC5zdGFydCA8PCBQQUdFX1NISUZUOwo+PiAr ICAgICAgIGd0dC0+b2Zmc2V0ID0gKCh1NjQpdG1wLnN0YXJ0IDw8IFBBR0VfU0hJRlQpIC0gYWRl di0+Z21jLmdhcnRfc3RhcnQ7Cj4+ICAgICAgICAgIHIgPSBhbWRncHVfdHRtX2dhcnRfYmluZChh ZGV2LCBibywgZmxhZ3MpOwo+PiAgICAgICAgICBpZiAodW5saWtlbHkocikpIHsKPj4gICAgICAg ICAgICAgICAgICB0dG1fYm9fbWVtX3B1dChibywgJnRtcCk7Cj4+IC0tCj4+IDIuMTcuMQo+Pgo+ PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBhbWQt Z2Z4IG1haWxpbmcgbGlzdAo+PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFp bGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKPgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAph bWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK