From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 4/7] drm/amdgpu: use the AGP aperture for system memory access v2 Date: Thu, 30 Aug 2018 11:20:29 +0800 Message-ID: <5B87627D.9050601@amd.com> References: <20180829140809.1812-1-christian.koenig@amd.com> <20180829140809.1812-4-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180829140809.1812-4-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMDgvMjkvMjAxOCAxMDowOCBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBTdGFydCB0 byB1c2UgdGhlIG9sZCBBR1AgYXBlcnR1cmUgZm9yIHN5c3RlbSBtZW1vcnkgYWNjZXNzLgo+Cj4g djI6IE1vdmUgdGhhdCB0byBhbWRncHVfdHRtX2FsbG9jX2dhcnQKPgo+IFNpZ25lZC1vZmYtYnk6 IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiAtLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuYyB8IDIzICsrKysrKysrKysKPiAg IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuaCB8ICAxICsKPiAgIGRyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyB8IDU4ICsrKysrKysrKysrKysrLS0t LS0tLS0tLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwgNTcgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2dtYy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dtYy5jCj4gaW5kZXgg MWQyMDFmZDNmNGFmLi42NWFlZTU3YjM1ZmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2dtYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2dtYy5jCj4gQEAgLTc5LDYgKzc5LDI5IEBAIHVpbnQ2NF90IGFtZGdwdV9nbWNf cGRfYWRkcihzdHJ1Y3QgYW1kZ3B1X2JvICpibykKPiAgIAlyZXR1cm4gcGRfYWRkcjsKPiAgIH0K Pgo+ICsvKioKPiArICogYW1kZ3B1X2dtY19hZ3BfYWRkciAtIHJldHVybiB0aGUgYWRkcmVzcyBp biB0aGUgQUdQIGFkZHJlc3Mgc3BhY2UKPiArICoKPiArICogQHRibzogVFRNIEJPIHdoaWNoIG5l ZWRzIHRoZSBhZGRyZXNzLCBtdXN0IGJlIGluIEdUVCBkb21haW4KPiArICoKPiArICogVHJpZXMg dG8gZmlndXJlIG91dCBob3cgdG8gYWNjZXNzIHRoZSBCTyB0aHJvdWdoIHRoZSBBR1AgYXBlcnR1 cmUuIFJldHVybnMKPiArICogQU1ER1BVX0JPX0lOVkFMSURfT0ZGU0VUIGlmIHRoYXQgaXMgbm90 IHBvc3NpYmxlLgo+ICsgKi8KPiArdWludDY0X3QgYW1kZ3B1X2dtY19hZ3BfYWRkcihzdHJ1Y3Qg dHRtX2J1ZmZlcl9vYmplY3QgKmJvKQo+ICt7Cj4gKwlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRl diA9IGFtZGdwdV90dG1fYWRldihiby0+YmRldik7Cj4gKwlzdHJ1Y3QgdHRtX2RtYV90dCAqdHRt Owo+ICsKPiArCWlmIChiby0+bnVtX3BhZ2VzICE9IDEgfHwgYm8tPnR0bS0+Y2FjaGluZ19zdGF0 ZSA9PSB0dF9jYWNoZWQpCj4gKwkJcmV0dXJuIEFNREdQVV9CT19JTlZBTElEX09GRlNFVDsKCklm IEdUVCBibyBzaXplIGlzIDEgcGFnZSwgaXQgd2lsbCBhbHNvIGFjY2VzcyBpbiBBR1AgYWRkcmVz cyBzcGFjZT8KCkplcnJ5Cj4gKwo+ICsJdHRtID0gY29udGFpbmVyX29mKGJvLT50dG0sIHN0cnVj dCB0dG1fZG1hX3R0LCB0dG0pOwo+ICsJaWYgKHR0bS0+ZG1hX2FkZHJlc3NbMF0gKyBQQUdFX1NJ WkUgPj0gYWRldi0+Z21jLmFncF9zaXplKQo+ICsJCXJldHVybiBBTURHUFVfQk9fSU5WQUxJRF9P RkZTRVQ7Cj4gKwo+ICsJcmV0dXJuIGFkZXYtPmdtYy5hZ3Bfc3RhcnQgKyB0dG0tPmRtYV9hZGRy ZXNzWzBdOwo+ICt9Cj4gKwo+ICAgLyoqCj4gICAgKiBhbWRncHVfZ21jX3ZyYW1fbG9jYXRpb24g LSB0cnkgdG8gZmluZCBWUkFNIGxvY2F0aW9uCj4gICAgKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmggYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfZ21jLmgKPiBpbmRleCBjOTk4NWU3ZGM5ZTUuLjI2NWNhNDE1YzY0YyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmgKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmgKPiBAQCAtMTYzLDYgKzE2 Myw3IEBAIHN0YXRpYyBpbmxpbmUgdWludDY0X3QgYW1kZ3B1X2dtY19zaWduX2V4dGVuZCh1aW50 NjRfdCBhZGRyKQo+ICAgdm9pZCBhbWRncHVfZ21jX2dldF9wZGVfZm9yX2JvKHN0cnVjdCBhbWRn cHVfYm8gKmJvLCBpbnQgbGV2ZWwsCj4gICAJCQkgICAgICAgdWludDY0X3QgKmFkZHIsIHVpbnQ2 NF90ICpmbGFncyk7Cj4gICB1aW50NjRfdCBhbWRncHVfZ21jX3BkX2FkZHIoc3RydWN0IGFtZGdw dV9ibyAqYm8pOwo+ICt1aW50NjRfdCBhbWRncHVfZ21jX2FncF9hZGRyKHN0cnVjdCB0dG1fYnVm ZmVyX29iamVjdCAqYm8pOwo+ICAgdm9pZCBhbWRncHVfZ21jX3ZyYW1fbG9jYXRpb24oc3RydWN0 IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0cnVjdCBhbWRncHVfZ21jICptYywKPiAgIAkJCSAgICAg IHU2NCBiYXNlKTsKPiAgIHZvaWQgYW1kZ3B1X2dtY19nYXJ0X2xvY2F0aW9uKHN0cnVjdCBhbWRn cHVfZGV2aWNlICphZGV2LAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfdHRtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMK PiBpbmRleCBkOWYzMjAxYzllNWMuLjhhMTU4ZWU5MjJmNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfdHRtLmMKPiBAQCAtMTA4MSw0MSArMTA4MSw0OSBAQCBpbnQgYW1k Z3B1X3R0bV9hbGxvY19nYXJ0KHN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqYm8pCj4gICAJc3Ry dWN0IHR0bV9tZW1fcmVnIHRtcDsKPiAgIAlzdHJ1Y3QgdHRtX3BsYWNlbWVudCBwbGFjZW1lbnQ7 Cj4gICAJc3RydWN0IHR0bV9wbGFjZSBwbGFjZW1lbnRzOwo+IC0JdWludDY0X3QgZmxhZ3M7Cj4g Kwl1aW50NjRfdCBhZGRyLCBmbGFnczsKPiAgIAlpbnQgcjsKPgo+ICAgCWlmIChiby0+bWVtLnN0 YXJ0ICE9IEFNREdQVV9CT19JTlZBTElEX09GRlNFVCkKPiAgIAkJcmV0dXJuIDA7Cj4KPiAtCS8q IGFsbG9jYXRlIEdBUlQgc3BhY2UgKi8KPiAtCXRtcCA9IGJvLT5tZW07Cj4gLQl0bXAubW1fbm9k ZSA9IE5VTEw7Cj4gLQlwbGFjZW1lbnQubnVtX3BsYWNlbWVudCA9IDE7Cj4gLQlwbGFjZW1lbnQu cGxhY2VtZW50ID0gJnBsYWNlbWVudHM7Cj4gLQlwbGFjZW1lbnQubnVtX2J1c3lfcGxhY2VtZW50 ID0gMTsKPiAtCXBsYWNlbWVudC5idXN5X3BsYWNlbWVudCA9ICZwbGFjZW1lbnRzOwo+IC0JcGxh Y2VtZW50cy5mcGZuID0gMDsKPiAtCXBsYWNlbWVudHMubHBmbiA9IGFkZXYtPmdtYy5nYXJ0X3Np emUgPj4gUEFHRV9TSElGVDsKPiAtCXBsYWNlbWVudHMuZmxhZ3MgPSAoYm8tPm1lbS5wbGFjZW1l bnQgJiB+VFRNX1BMX01BU0tfTUVNKSB8Cj4gLQkJVFRNX1BMX0ZMQUdfVFQ7Cj4gKwlhZGRyID0g YW1kZ3B1X2dtY19hZ3BfYWRkcihibyk7Cj4gKwlpZiAoYWRkciAhPSBBTURHUFVfQk9fSU5WQUxJ RF9PRkZTRVQpIHsKPiArCQliby0+bWVtLnN0YXJ0ID0gYWRkciA+PiBQQUdFX1NISUZUOwo+ICsJ fSBlbHNlIHsKPgo+IC0JciA9IHR0bV9ib19tZW1fc3BhY2UoYm8sICZwbGFjZW1lbnQsICZ0bXAs ICZjdHgpOwo+IC0JaWYgKHVubGlrZWx5KHIpKQo+IC0JCXJldHVybiByOwo+ICsJCS8qIGFsbG9j YXRlIEdBUlQgc3BhY2UgKi8KPiArCQl0bXAgPSBiby0+bWVtOwo+ICsJCXRtcC5tbV9ub2RlID0g TlVMTDsKPiArCQlwbGFjZW1lbnQubnVtX3BsYWNlbWVudCA9IDE7Cj4gKwkJcGxhY2VtZW50LnBs YWNlbWVudCA9ICZwbGFjZW1lbnRzOwo+ICsJCXBsYWNlbWVudC5udW1fYnVzeV9wbGFjZW1lbnQg PSAxOwo+ICsJCXBsYWNlbWVudC5idXN5X3BsYWNlbWVudCA9ICZwbGFjZW1lbnRzOwo+ICsJCXBs YWNlbWVudHMuZnBmbiA9IDA7Cj4gKwkJcGxhY2VtZW50cy5scGZuID0gYWRldi0+Z21jLmdhcnRf c2l6ZSA+PiBQQUdFX1NISUZUOwo+ICsJCXBsYWNlbWVudHMuZmxhZ3MgPSAoYm8tPm1lbS5wbGFj ZW1lbnQgJiB+VFRNX1BMX01BU0tfTUVNKSB8Cj4gKwkJCVRUTV9QTF9GTEFHX1RUOwo+ICsKPiAr CQlyID0gdHRtX2JvX21lbV9zcGFjZShibywgJnBsYWNlbWVudCwgJnRtcCwgJmN0eCk7Cj4gKwkJ aWYgKHVubGlrZWx5KHIpKQo+ICsJCQlyZXR1cm4gcjsKPgo+IC0JLyogY29tcHV0ZSBQVEUgZmxh Z3MgZm9yIHRoaXMgYnVmZmVyIG9iamVjdCAqLwo+IC0JZmxhZ3MgPSBhbWRncHVfdHRtX3R0X3B0 ZV9mbGFncyhhZGV2LCBiby0+dHRtLCAmdG1wKTsKPiArCQkvKiBjb21wdXRlIFBURSBmbGFncyBm b3IgdGhpcyBidWZmZXIgb2JqZWN0ICovCj4gKwkJZmxhZ3MgPSBhbWRncHVfdHRtX3R0X3B0ZV9m bGFncyhhZGV2LCBiby0+dHRtLCAmdG1wKTsKPgo+IC0JLyogQmluZCBwYWdlcyAqLwo+IC0JZ3R0 LT5vZmZzZXQgPSAoKHU2NCl0bXAuc3RhcnQgPDwgUEFHRV9TSElGVCkgLSBhZGV2LT5nbWMuZ2Fy dF9zdGFydDsKPiAtCXIgPSBhbWRncHVfdHRtX2dhcnRfYmluZChhZGV2LCBibywgZmxhZ3MpOwo+ IC0JaWYgKHVubGlrZWx5KHIpKSB7Cj4gLQkJdHRtX2JvX21lbV9wdXQoYm8sICZ0bXApOwo+IC0J CXJldHVybiByOwo+ICsJCS8qIEJpbmQgcGFnZXMgKi8KPiArCQlndHQtPm9mZnNldCA9ICgodTY0 KXRtcC5zdGFydCA8PCBQQUdFX1NISUZUKSAtCj4gKwkJCWFkZXYtPmdtYy5nYXJ0X3N0YXJ0Owo+ ICsJCXIgPSBhbWRncHVfdHRtX2dhcnRfYmluZChhZGV2LCBibywgZmxhZ3MpOwo+ICsJCWlmICh1 bmxpa2VseShyKSkgewo+ICsJCQl0dG1fYm9fbWVtX3B1dChibywgJnRtcCk7Cj4gKwkJCXJldHVy biByOwo+ICsJCX0KPiArCj4gKwkJdHRtX2JvX21lbV9wdXQoYm8sICZiby0+bWVtKTsKPiArCQli by0+bWVtID0gdG1wOwo+ICAgCX0KPgo+IC0JdHRtX2JvX21lbV9wdXQoYm8sICZiby0+bWVtKTsK PiAtCWJvLT5tZW0gPSB0bXA7Cj4gICAJYm8tPm9mZnNldCA9IChiby0+bWVtLnN0YXJ0IDw8IFBB R0VfU0hJRlQpICsKPiAgIAkJYm8tPmJkZXYtPm1hbltiby0+bWVtLm1lbV90eXBlXS5ncHVfb2Zm c2V0Owo+Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K YW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==