From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 4/7] drm/amdgpu: use the AGP aperture for system memory access v2 Date: Fri, 31 Aug 2018 09:39:38 +0800 Message-ID: <5B889C5A.5060500@amd.com> References: <20180829140809.1812-1-christian.koenig@amd.com> <20180829140809.1812-4-christian.koenig@amd.com> <5B87627D.9050601@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: christian.koenig-5C7GfCeVMHo@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMDgvMzAvMjAxOCAwODoxNSBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBBbSAzMC4w OC4yMDE4IHVtIDA1OjIwIHNjaHJpZWIgWmhhbmcsIEplcnJ5IChKdW53ZWkpOgo+PiBPbiAwOC8y OS8yMDE4IDEwOjA4IFBNLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+Pj4gU3RhcnQgdG8gdXNl IHRoZSBvbGQgQUdQIGFwZXJ0dXJlIGZvciBzeXN0ZW0gbWVtb3J5IGFjY2Vzcy4KPj4+Cj4+PiB2 MjogTW92ZSB0aGF0IHRvIGFtZGdwdV90dG1fYWxsb2NfZ2FydAo+Pj4KPj4+IFNpZ25lZC1vZmYt Ynk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPj4+IC0tLQo+ Pj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmMgfCAyMyArKysrKysr KysrCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuaCB8ICAxICsK Pj4+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jIHwgNTggKysrKysr KysrKysrKystLS0tLS0tLS0tLQo+Pj4gICAzIGZpbGVzIGNoYW5nZWQsIDU3IGluc2VydGlvbnMo KyksIDI1IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfZ21jLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfZ21jLmMKPj4+IGluZGV4IDFkMjAxZmQzZjRhZi4uNjVhZWU1N2IzNWZlIDEwMDY0NAo+Pj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dtYy5jCj4+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmMKPj4+IEBAIC03OSw2ICs3OSwy OSBAQCB1aW50NjRfdCBhbWRncHVfZ21jX3BkX2FkZHIoc3RydWN0IGFtZGdwdV9ibyAqYm8pCj4+ PiAgICAgICByZXR1cm4gcGRfYWRkcjsKPj4+ICAgfQo+Pj4KPj4+ICsvKioKPj4+ICsgKiBhbWRn cHVfZ21jX2FncF9hZGRyIC0gcmV0dXJuIHRoZSBhZGRyZXNzIGluIHRoZSBBR1AgYWRkcmVzcyBz cGFjZQo+Pj4gKyAqCj4+PiArICogQHRibzogVFRNIEJPIHdoaWNoIG5lZWRzIHRoZSBhZGRyZXNz LCBtdXN0IGJlIGluIEdUVCBkb21haW4KPj4+ICsgKgo+Pj4gKyAqIFRyaWVzIHRvIGZpZ3VyZSBv dXQgaG93IHRvIGFjY2VzcyB0aGUgQk8gdGhyb3VnaCB0aGUgQUdQIGFwZXJ0dXJlLiBSZXR1cm5z Cj4+PiArICogQU1ER1BVX0JPX0lOVkFMSURfT0ZGU0VUIGlmIHRoYXQgaXMgbm90IHBvc3NpYmxl Lgo+Pj4gKyAqLwo+Pj4gK3VpbnQ2NF90IGFtZGdwdV9nbWNfYWdwX2FkZHIoc3RydWN0IHR0bV9i dWZmZXJfb2JqZWN0ICpibykKPj4+ICt7Cj4+PiArICAgIHN0cnVjdCBhbWRncHVfZGV2aWNlICph ZGV2ID0gYW1kZ3B1X3R0bV9hZGV2KGJvLT5iZGV2KTsKPj4+ICsgICAgc3RydWN0IHR0bV9kbWFf dHQgKnR0bTsKPj4+ICsKPj4+ICsgICAgaWYgKGJvLT5udW1fcGFnZXMgIT0gMSB8fCBiby0+dHRt LT5jYWNoaW5nX3N0YXRlID09IHR0X2NhY2hlZCkKPj4+ICsgICAgICAgIHJldHVybiBBTURHUFVf Qk9fSU5WQUxJRF9PRkZTRVQ7Cj4+Cj4+IElmIEdUVCBibyBzaXplIGlzIDEgcGFnZSwgaXQgd2ls bCBhbHNvIGFjY2VzcyBpbiBBR1AgYWRkcmVzcyBzcGFjZT8KPgo+IFllcywgdGhhdCBpcyB0aGUg aWRlYSBoZXJlLgo+Cj4gV2UgYmFzaWNhbGx5IGNhbiBhdm9pZCBHQVJUIG1hcHBpbmdzIGZvciBC T3MgaW4gdGhlIEdUVCBkb21haW4gd2hpY2ggYXJlIG9ubHkgb25lIHBhZ2UgaW4gc2l6ZS4KClRo YW5rcyB0byBleHBsYWluIHRoYXQsIGdvdCB0aGUgaW50ZW50aW9uLgoKSmVycnkKCj4KPiBDaHJp c3RpYW4uCj4KPj4KPj4gSmVycnkKPj4+ICsKPj4+ICsgICAgdHRtID0gY29udGFpbmVyX29mKGJv LT50dG0sIHN0cnVjdCB0dG1fZG1hX3R0LCB0dG0pOwo+Pj4gKyAgICBpZiAodHRtLT5kbWFfYWRk cmVzc1swXSArIFBBR0VfU0laRSA+PSBhZGV2LT5nbWMuYWdwX3NpemUpCj4+PiArICAgICAgICBy ZXR1cm4gQU1ER1BVX0JPX0lOVkFMSURfT0ZGU0VUOwo+Pj4gKwo+Pj4gKyAgICByZXR1cm4gYWRl di0+Z21jLmFncF9zdGFydCArIHR0bS0+ZG1hX2FkZHJlc3NbMF07Cj4+PiArfQo+Pj4gKwo+Pj4g ICAvKioKPj4+ICAgICogYW1kZ3B1X2dtY192cmFtX2xvY2F0aW9uIC0gdHJ5IHRvIGZpbmQgVlJB TSBsb2NhdGlvbgo+Pj4gICAgKgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9nbWMuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9n bWMuaAo+Pj4gaW5kZXggYzk5ODVlN2RjOWU1Li4yNjVjYTQxNWM2NGMgMTAwNjQ0Cj4+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmgKPj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nbWMuaAo+Pj4gQEAgLTE2Myw2ICsxNjMsNyBA QCBzdGF0aWMgaW5saW5lIHVpbnQ2NF90IGFtZGdwdV9nbWNfc2lnbl9leHRlbmQodWludDY0X3Qg YWRkcikKPj4+ICAgdm9pZCBhbWRncHVfZ21jX2dldF9wZGVfZm9yX2JvKHN0cnVjdCBhbWRncHVf Ym8gKmJvLCBpbnQgbGV2ZWwsCj4+PiAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCAqYWRk ciwgdWludDY0X3QgKmZsYWdzKTsKPj4+ICAgdWludDY0X3QgYW1kZ3B1X2dtY19wZF9hZGRyKHN0 cnVjdCBhbWRncHVfYm8gKmJvKTsKPj4+ICt1aW50NjRfdCBhbWRncHVfZ21jX2FncF9hZGRyKHN0 cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqYm8pOwo+Pj4gICB2b2lkIGFtZGdwdV9nbWNfdnJhbV9s b2NhdGlvbihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgc3RydWN0IGFtZGdwdV9nbWMgKm1j LAo+Pj4gICAgICAgICAgICAgICAgICAgICB1NjQgYmFzZSk7Cj4+PiAgIHZvaWQgYW1kZ3B1X2dt Y19nYXJ0X2xvY2F0aW9uKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+Pj4gaW5kZXggZDlmMzIwMWM5ZTVjLi44YTE1 OGVlOTIyZjcgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfdHRtLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0u Ywo+Pj4gQEAgLTEwODEsNDEgKzEwODEsNDkgQEAgaW50IGFtZGdwdV90dG1fYWxsb2NfZ2FydChz dHJ1Y3QgdHRtX2J1ZmZlcl9vYmplY3QgKmJvKQo+Pj4gICAgICAgc3RydWN0IHR0bV9tZW1fcmVn IHRtcDsKPj4+ICAgICAgIHN0cnVjdCB0dG1fcGxhY2VtZW50IHBsYWNlbWVudDsKPj4+ICAgICAg IHN0cnVjdCB0dG1fcGxhY2UgcGxhY2VtZW50czsKPj4+IC0gICAgdWludDY0X3QgZmxhZ3M7Cj4+ PiArICAgIHVpbnQ2NF90IGFkZHIsIGZsYWdzOwo+Pj4gICAgICAgaW50IHI7Cj4+Pgo+Pj4gICAg ICAgaWYgKGJvLT5tZW0uc3RhcnQgIT0gQU1ER1BVX0JPX0lOVkFMSURfT0ZGU0VUKQo+Pj4gICAg ICAgICAgIHJldHVybiAwOwo+Pj4KPj4+IC0gICAgLyogYWxsb2NhdGUgR0FSVCBzcGFjZSAqLwo+ Pj4gLSAgICB0bXAgPSBiby0+bWVtOwo+Pj4gLSAgICB0bXAubW1fbm9kZSA9IE5VTEw7Cj4+PiAt ICAgIHBsYWNlbWVudC5udW1fcGxhY2VtZW50ID0gMTsKPj4+IC0gICAgcGxhY2VtZW50LnBsYWNl bWVudCA9ICZwbGFjZW1lbnRzOwo+Pj4gLSAgICBwbGFjZW1lbnQubnVtX2J1c3lfcGxhY2VtZW50 ID0gMTsKPj4+IC0gICAgcGxhY2VtZW50LmJ1c3lfcGxhY2VtZW50ID0gJnBsYWNlbWVudHM7Cj4+ PiAtICAgIHBsYWNlbWVudHMuZnBmbiA9IDA7Cj4+PiAtICAgIHBsYWNlbWVudHMubHBmbiA9IGFk ZXYtPmdtYy5nYXJ0X3NpemUgPj4gUEFHRV9TSElGVDsKPj4+IC0gICAgcGxhY2VtZW50cy5mbGFn cyA9IChiby0+bWVtLnBsYWNlbWVudCAmIH5UVE1fUExfTUFTS19NRU0pIHwKPj4+IC0gICAgICAg IFRUTV9QTF9GTEFHX1RUOwo+Pj4gKyAgICBhZGRyID0gYW1kZ3B1X2dtY19hZ3BfYWRkcihibyk7 Cj4+PiArICAgIGlmIChhZGRyICE9IEFNREdQVV9CT19JTlZBTElEX09GRlNFVCkgewo+Pj4gKyAg ICAgICAgYm8tPm1lbS5zdGFydCA9IGFkZHIgPj4gUEFHRV9TSElGVDsKPj4+ICsgICAgfSBlbHNl IHsKPj4+Cj4+PiAtICAgIHIgPSB0dG1fYm9fbWVtX3NwYWNlKGJvLCAmcGxhY2VtZW50LCAmdG1w LCAmY3R4KTsKPj4+IC0gICAgaWYgKHVubGlrZWx5KHIpKQo+Pj4gLSAgICAgICAgcmV0dXJuIHI7 Cj4+PiArICAgICAgICAvKiBhbGxvY2F0ZSBHQVJUIHNwYWNlICovCj4+PiArICAgICAgICB0bXAg PSBiby0+bWVtOwo+Pj4gKyAgICAgICAgdG1wLm1tX25vZGUgPSBOVUxMOwo+Pj4gKyAgICAgICAg cGxhY2VtZW50Lm51bV9wbGFjZW1lbnQgPSAxOwo+Pj4gKyAgICAgICAgcGxhY2VtZW50LnBsYWNl bWVudCA9ICZwbGFjZW1lbnRzOwo+Pj4gKyAgICAgICAgcGxhY2VtZW50Lm51bV9idXN5X3BsYWNl bWVudCA9IDE7Cj4+PiArICAgICAgICBwbGFjZW1lbnQuYnVzeV9wbGFjZW1lbnQgPSAmcGxhY2Vt ZW50czsKPj4+ICsgICAgICAgIHBsYWNlbWVudHMuZnBmbiA9IDA7Cj4+PiArICAgICAgICBwbGFj ZW1lbnRzLmxwZm4gPSBhZGV2LT5nbWMuZ2FydF9zaXplID4+IFBBR0VfU0hJRlQ7Cj4+PiArICAg ICAgICBwbGFjZW1lbnRzLmZsYWdzID0gKGJvLT5tZW0ucGxhY2VtZW50ICYgflRUTV9QTF9NQVNL X01FTSkgfAo+Pj4gKyAgICAgICAgICAgIFRUTV9QTF9GTEFHX1RUOwo+Pj4gKwo+Pj4gKyAgICAg ICAgciA9IHR0bV9ib19tZW1fc3BhY2UoYm8sICZwbGFjZW1lbnQsICZ0bXAsICZjdHgpOwo+Pj4g KyAgICAgICAgaWYgKHVubGlrZWx5KHIpKQo+Pj4gKyAgICAgICAgICAgIHJldHVybiByOwo+Pj4K Pj4+IC0gICAgLyogY29tcHV0ZSBQVEUgZmxhZ3MgZm9yIHRoaXMgYnVmZmVyIG9iamVjdCAqLwo+ Pj4gLSAgICBmbGFncyA9IGFtZGdwdV90dG1fdHRfcHRlX2ZsYWdzKGFkZXYsIGJvLT50dG0sICZ0 bXApOwo+Pj4gKyAgICAgICAgLyogY29tcHV0ZSBQVEUgZmxhZ3MgZm9yIHRoaXMgYnVmZmVyIG9i amVjdCAqLwo+Pj4gKyAgICAgICAgZmxhZ3MgPSBhbWRncHVfdHRtX3R0X3B0ZV9mbGFncyhhZGV2 LCBiby0+dHRtLCAmdG1wKTsKPj4+Cj4+PiAtICAgIC8qIEJpbmQgcGFnZXMgKi8KPj4+IC0gICAg Z3R0LT5vZmZzZXQgPSAoKHU2NCl0bXAuc3RhcnQgPDwgUEFHRV9TSElGVCkgLSBhZGV2LT5nbWMu Z2FydF9zdGFydDsKPj4+IC0gICAgciA9IGFtZGdwdV90dG1fZ2FydF9iaW5kKGFkZXYsIGJvLCBm bGFncyk7Cj4+PiAtICAgIGlmICh1bmxpa2VseShyKSkgewo+Pj4gLSAgICAgICAgdHRtX2JvX21l bV9wdXQoYm8sICZ0bXApOwo+Pj4gLSAgICAgICAgcmV0dXJuIHI7Cj4+PiArICAgICAgICAvKiBC aW5kIHBhZ2VzICovCj4+PiArICAgICAgICBndHQtPm9mZnNldCA9ICgodTY0KXRtcC5zdGFydCA8 PCBQQUdFX1NISUZUKSAtCj4+PiArICAgICAgICAgICAgYWRldi0+Z21jLmdhcnRfc3RhcnQ7Cj4+ PiArICAgICAgICByID0gYW1kZ3B1X3R0bV9nYXJ0X2JpbmQoYWRldiwgYm8sIGZsYWdzKTsKPj4+ ICsgICAgICAgIGlmICh1bmxpa2VseShyKSkgewo+Pj4gKyAgICAgICAgICAgIHR0bV9ib19tZW1f cHV0KGJvLCAmdG1wKTsKPj4+ICsgICAgICAgICAgICByZXR1cm4gcjsKPj4+ICsgICAgICAgIH0K Pj4+ICsKPj4+ICsgICAgICAgIHR0bV9ib19tZW1fcHV0KGJvLCAmYm8tPm1lbSk7Cj4+PiArICAg ICAgICBiby0+bWVtID0gdG1wOwo+Pj4gICAgICAgfQo+Pj4KPj4+IC0gICAgdHRtX2JvX21lbV9w dXQoYm8sICZiby0+bWVtKTsKPj4+IC0gICAgYm8tPm1lbSA9IHRtcDsKPj4+ICAgICAgIGJvLT5v ZmZzZXQgPSAoYm8tPm1lbS5zdGFydCA8PCBQQUdFX1NISUZUKSArCj4+PiAgICAgICAgICAgYm8t PmJkZXYtPm1hbltiby0+bWVtLm1lbV90eXBlXS5ncHVfb2Zmc2V0Owo+Pj4KPj4+Cj4KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==