From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 1/4] drm/amdgpu/gmc9: rework stolen vga memory handling Date: Fri, 31 Aug 2018 10:03:06 +0800 Message-ID: <5B88A1DA.5070400@amd.com> References: <20180830145339.5162-1-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180830145339.5162-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Deucher T24gMDgvMzAvMjAxOCAxMDo1MyBQTSwgQWxleCBEZXVjaGVyIHdyb3RlOgo+IE5vIGZ1bmN0aW9u YWwgY2hhbmdlLCBqdXN0IHJld29yayBpdCBpbiBvcmRlciB0byBhZGp1c3QgdGhlCj4gYmVoYXZp b3Igb24gYSBwZXIgYXNpYyBsZXZlbC4gIFRoZSBwcm9ibGVtIGlzIHRoYXQgb24gdmVnYTEwLAo+ IHNvbWV0aGluZyBjb3JydXB0cyB0aGUgbG93ZXIgOCBNQiBvZiB2cmFtIG9uIHRoZSBzZWNvbmQK PiByZXN1bWUgZnJvbSBTMy4gIFRoaXMgZG9lcyBub3Qgc2VlbSB0byBhZmZlY3QgUmF2ZW4sIG90 aGVyCj4gZ21jOSBiYXNlZCBhc2ljcyBuZWVkIHRlc3RpbmcuCj4KPiBTaWduZWQtb2ZmLWJ5OiBB bGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+CgpSZXZpZXdlZC1ieTogSnVu d2VpIFpoYW5nIDxKZXJyeS5aaGFuZ0BhbWQuY29tPgoKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2dtY192OV8wLmMgfCA0OCArKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192OV8w LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjlfMC5jCj4gaW5kZXggMDRkNTA4 OTNhNmYyLi40NmNmZjdkOGIzNzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvZ21jX3Y5XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192 OV8wLmMKPiBAQCAtNjkyLDYgKzY5MiwyOCBAQCBzdGF0aWMgaW50IGdtY192OV8wX2VjY19hdmFp bGFibGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJcmV0dXJuIGxvc3Rfc2hlZXAg PT0gMDsKPiAgIH0KPgo+ICtzdGF0aWMgYm9vbCBnbWNfdjlfMF9rZWVwX3N0b2xlbl9tZW1vcnko c3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gK3sKPiArCj4gKwkvKgo+ICsJICogVE9ETzoK PiArCSAqIEN1cnJlbnRseSB0aGVyZSBpcyBhIGJ1ZyB3aGVyZSBzb21lIG1lbW9yeSBjbGllbnQg b3V0c2lkZQo+ICsJICogb2YgdGhlIGRyaXZlciB3cml0ZXMgdG8gZmlyc3QgOE0gb2YgVlJBTSBv biBTMyByZXN1bWUsCj4gKwkgKiB0aGlzIG92ZXJyaWRlcyBHQVJUIHdoaWNoIGJ5IGRlZmF1bHQg Z2V0cyBwbGFjZWQgaW4gZmlyc3QgOE0gYW5kCj4gKwkgKiBjYXVzZXMgVk1fRkFVTFRTIG9uY2Ug R1RUIGlzIGFjY2Vzc2VkLgo+ICsJICogS2VlcCB0aGUgc3RvbGVuIG1lbW9yeSByZXNlcnZhdGlv biB1bnRpbCB0aGUgd2hpbGUgdGhpcyBpcyBub3Qgc29sdmVkLgo+ICsJICogQWxzbyBjaGVjayBj b2RlIGluIGdtY192OV8wX2dldF92Ymlvc19mYl9zaXplIGFuZCBnbWNfdjlfMF9sYXRlX2luaXQK PiArCSAqLwo+ICsJc3dpdGNoIChhZGV2LT5hc2ljX3R5cGUpIHsKPiArCWNhc2UgQ0hJUF9SQVZF TjoKPiArCWNhc2UgQ0hJUF9WRUdBMTA6Cj4gKwljYXNlIENISVBfVkVHQTEyOgo+ICsJY2FzZSBD SElQX1ZFR0EyMDoKPiArCWRlZmF1bHQ6Cj4gKwkJcmV0dXJuIHRydWU7Cj4gKwl9Cj4gK30KPiAr Cj4gICBzdGF0aWMgaW50IGdtY192OV8wX2xhdGVfaW5pdCh2b2lkICpoYW5kbGUpCj4gICB7Cj4g ICAJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSAoc3RydWN0IGFtZGdwdV9kZXZpY2UgKilo YW5kbGU7Cj4gQEAgLTcwOCwxMCArNzMwLDggQEAgc3RhdGljIGludCBnbWNfdjlfMF9sYXRlX2lu aXQodm9pZCAqaGFuZGxlKQo+ICAgCXVuc2lnbmVkIGk7Cj4gICAJaW50IHI7Cj4KPiAtCS8qCj4g LQkgKiBUT0RPIC0gVW5jb21tZW50IG9uY2UgR0FSVCBjb3JydXB0aW9uIGlzc3VlIGlzIGZpeGVk Lgo+IC0JICovCj4gLQkvKiBhbWRncHVfYm9fbGF0ZV9pbml0KGFkZXYpOyAqLwo+ICsJaWYgKCFn bWNfdjlfMF9rZWVwX3N0b2xlbl9tZW1vcnkoYWRldikpCj4gKwkJYW1kZ3B1X2JvX2xhdGVfaW5p dChhZGV2KTsKPgo+ICAgCWZvcihpID0gMDsgaSA8IGFkZXYtPm51bV9yaW5nczsgKytpKSB7Cj4g ICAJCXN0cnVjdCBhbWRncHVfcmluZyAqcmluZyA9IGFkZXYtPnJpbmdzW2ldOwo+IEBAIC04NDgs MTggKzg2OCwxNiBAQCBzdGF0aWMgaW50IGdtY192OV8wX2dhcnRfaW5pdChzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldikKPgo+ICAgc3RhdGljIHVuc2lnbmVkIGdtY192OV8wX2dldF92Ymlvc19m Yl9zaXplKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAgewo+IC0jaWYgMAo+ICAgCXUz MiBkMXZnYV9jb250cm9sID0gUlJFRzMyX1NPQzE1KERDRSwgMCwgbW1EMVZHQV9DT05UUk9MKTsK PiAtI2VuZGlmCj4gICAJdW5zaWduZWQgc2l6ZTsKPgo+ICAgCS8qCj4gICAJICogVE9ETyBSZW1v dmUgb25jZSBHQVJUIGNvcnJ1cHRpb24gaXMgcmVzb2x2ZWQKPiAgIAkgKiBDaGVjayByZWxhdGVk IGNvZGUgaW4gZ21jX3Y5XzBfc3dfZmluaQo+ICAgCSAqICovCj4gLQlzaXplID0gOSAqIDEwMjQg KiAxMDI0Owo+ICsJaWYgKGdtY192OV8wX2tlZXBfc3RvbGVuX21lbW9yeShhZGV2KSkKPiArCQly ZXR1cm4gOSAqIDEwMjQgKiAxMDI0Owo+Cj4gLSNpZiAwCj4gICAJaWYgKFJFR19HRVRfRklFTEQo ZDF2Z2FfY29udHJvbCwgRDFWR0FfQ09OVFJPTCwgRDFWR0FfTU9ERV9FTkFCTEUpKSB7Cj4gICAJ CXNpemUgPSA5ICogMTAyNCAqIDEwMjQ7IC8qIHJlc2VydmUgOE1CIGZvciB2Z2EgZW11bGF0b3Ig YW5kIDEgTUIgZm9yIEZCICovCj4gICAJfSBlbHNlIHsKPiBAQCAtODc2LDYgKzg5NCw3IEBAIHN0 YXRpYyB1bnNpZ25lZCBnbWNfdjlfMF9nZXRfdmJpb3NfZmJfc2l6ZShzdHJ1Y3QgYW1kZ3B1X2Rl dmljZSAqYWRldikKPiAgIAkJCWJyZWFrOwo+ICAgCQljYXNlIENISVBfVkVHQTEwOgo+ICAgCQlj YXNlIENISVBfVkVHQTEyOgo+ICsJCWNhc2UgQ0hJUF9WRUdBMjA6Cj4gICAJCWRlZmF1bHQ6Cj4g ICAJCQl2aWV3cG9ydCA9IFJSRUczMl9TT0MxNShEQ0UsIDAsIG1tU0NMMF9WSUVXUE9SVF9TSVpF KTsKPiAgIAkJCXNpemUgPSAoUkVHX0dFVF9GSUVMRCh2aWV3cG9ydCwgU0NMMF9WSUVXUE9SVF9T SVpFLCBWSUVXUE9SVF9IRUlHSFQpICoKPiBAQCAtODg4LDcgKzkwNyw2IEBAIHN0YXRpYyB1bnNp Z25lZCBnbWNfdjlfMF9nZXRfdmJpb3NfZmJfc2l6ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRl dikKPiAgIAlpZiAoKGFkZXYtPmdtYy5yZWFsX3ZyYW1fc2l6ZSAtIHNpemUpIDwgKDggKiAxMDI0 ICogMTAyNCkpCj4gICAJCXJldHVybiAwOwo+Cj4gLSNlbmRpZgo+ICAgCXJldHVybiBzaXplOwo+ ICAgfQo+Cj4gQEAgLTEwMDAsMTYgKzEwMTgsOCBAQCBzdGF0aWMgaW50IGdtY192OV8wX3N3X2Zp bmkodm9pZCAqaGFuZGxlKQo+ICAgCWFtZGdwdV9nZW1fZm9yY2VfcmVsZWFzZShhZGV2KTsKPiAg IAlhbWRncHVfdm1fbWFuYWdlcl9maW5pKGFkZXYpOwo+Cj4gLQkvKgo+IC0JKiBUT0RPOgo+IC0J KiBDdXJyZW50bHkgdGhlcmUgaXMgYSBidWcgd2hlcmUgc29tZSBtZW1vcnkgY2xpZW50IG91dHNp ZGUKPiAtCSogb2YgdGhlIGRyaXZlciB3cml0ZXMgdG8gZmlyc3QgOE0gb2YgVlJBTSBvbiBTMyBy ZXN1bWUsCj4gLQkqIHRoaXMgb3ZlcnJpZGVzIEdBUlQgd2hpY2ggYnkgZGVmYXVsdCBnZXRzIHBs YWNlZCBpbiBmaXJzdCA4TSBhbmQKPiAtCSogY2F1c2VzIFZNX0ZBVUxUUyBvbmNlIEdUVCBpcyBh Y2Nlc3NlZC4KPiAtCSogS2VlcCB0aGUgc3RvbGVuIG1lbW9yeSByZXNlcnZhdGlvbiB1bnRpbCB0 aGUgd2hpbGUgdGhpcyBpcyBub3Qgc29sdmVkLgo+IC0JKiBBbHNvIGNoZWNrIGNvZGUgaW4gZ21j X3Y5XzBfZ2V0X3ZiaW9zX2ZiX3NpemUgYW5kIGdtY192OV8wX2xhdGVfaW5pdAo+IC0JKi8KPiAt CWFtZGdwdV9ib19mcmVlX2tlcm5lbCgmYWRldi0+c3RvbGVuX3ZnYV9tZW1vcnksIE5VTEwsIE5V TEwpOwo+ICsJaWYgKGdtY192OV8wX2tlZXBfc3RvbGVuX21lbW9yeShhZGV2KSkKPiArCQlhbWRn cHVfYm9fZnJlZV9rZXJuZWwoJmFkZXYtPnN0b2xlbl92Z2FfbWVtb3J5LCBOVUxMLCBOVUxMKTsK Pgo+ICAgCWFtZGdwdV9nYXJ0X3RhYmxlX3ZyYW1fZnJlZShhZGV2KTsKPiAgIAlhbWRncHVfYm9f ZmluaShhZGV2KTsKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK