From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/2] drm/amdgpu: move size calculations to the front of
 the file again
Date: Mon, 3 Sep 2018 10:52:08 +0800
Message-ID: <5B8CA1D8.3040201@amd.com>
References: <20180831132741.112280-1-christian.koenig@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20180831132741.112280-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

T24gMDgvMzEvMjAxOCAwOToyNyBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBhbWRncHVf
dm1fYm9fKiBmdW5jdGlvbnMgc2hvdWxkIGNvbWUgbXVjaCBsYXRlci4KPgo+IFNpZ25lZC1vZmYt
Ynk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KUmV2aWV3ZWQt
Ynk6IEp1bndlaSBaaGFuZyA8SmVycnkuWmhhbmdAYW1kLmNvbT4KCj4gLS0tCj4gICBkcml2ZXJz
L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyB8IDkwICsrKysrKysrKysrKysrKysrLS0t
LS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0NSBpbnNlcnRpb25zKCspLCA0NSBk
ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h
bWRncHVfdm0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4gaW5k
ZXggZDU5MjIyZmI1OTMxLi5hOTI3NWE5OWQ3OTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft
ZGdwdS9hbWRncHVfdm0uYwo+IEBAIC0xMzMsNTEgKzEzMyw2IEBAIHN0cnVjdCBhbWRncHVfcHJ0
X2NiIHsKPiAgIAlzdHJ1Y3QgZG1hX2ZlbmNlX2NiIGNiOwo+ICAgfTsKPgo+IC0vKioKPiAtICog
YW1kZ3B1X3ZtX2JvX2Jhc2VfaW5pdCAtIEFkZHMgYm8gdG8gdGhlIGxpc3Qgb2YgYm9zIGFzc29j
aWF0ZWQgd2l0aCB0aGUgdm0KPiAtICoKPiAtICogQGJhc2U6IGJhc2Ugc3RydWN0dXJlIGZvciB0
cmFja2luZyBCTyB1c2FnZSBpbiBhIFZNCj4gLSAqIEB2bTogdm0gdG8gd2hpY2ggYm8gaXMgdG8g
YmUgYWRkZWQKPiAtICogQGJvOiBhbWRncHUgYnVmZmVyIG9iamVjdAo+IC0gKgo+IC0gKiBJbml0
aWFsaXplIGEgYm9fdmFfYmFzZSBzdHJ1Y3R1cmUgYW5kIGFkZCBpdCB0byB0aGUgYXBwcm9wcmlh
dGUgbGlzdHMKPiAtICoKPiAtICovCj4gLXN0YXRpYyB2b2lkIGFtZGdwdV92bV9ib19iYXNlX2lu
aXQoc3RydWN0IGFtZGdwdV92bV9ib19iYXNlICpiYXNlLAo+IC0JCQkJICAgc3RydWN0IGFtZGdw
dV92bSAqdm0sCj4gLQkJCQkgICBzdHJ1Y3QgYW1kZ3B1X2JvICpibykKPiAtewo+IC0JYmFzZS0+
dm0gPSB2bTsKPiAtCWJhc2UtPmJvID0gYm87Cj4gLQlJTklUX0xJU1RfSEVBRCgmYmFzZS0+Ym9f
bGlzdCk7Cj4gLQlJTklUX0xJU1RfSEVBRCgmYmFzZS0+dm1fc3RhdHVzKTsKPiAtCj4gLQlpZiAo
IWJvKQo+IC0JCXJldHVybjsKPiAtCWxpc3RfYWRkX3RhaWwoJmJhc2UtPmJvX2xpc3QsICZiby0+
dmEpOwo+IC0KPiAtCWlmIChiby0+dGJvLnJlc3YgIT0gdm0tPnJvb3QuYmFzZS5iby0+dGJvLnJl
c3YpCj4gLQkJcmV0dXJuOwo+IC0KPiAtCXZtLT5idWxrX21vdmVhYmxlID0gZmFsc2U7Cj4gLQlp
ZiAoYm8tPnRiby50eXBlID09IHR0bV9ib190eXBlX2tlcm5lbCkKPiAtCQlsaXN0X21vdmUoJmJh
c2UtPnZtX3N0YXR1cywgJnZtLT5yZWxvY2F0ZWQpOwo+IC0JZWxzZQo+IC0JCWxpc3RfbW92ZSgm
YmFzZS0+dm1fc3RhdHVzLCAmdm0tPmlkbGUpOwo+IC0KPiAtCWlmIChiby0+cHJlZmVycmVkX2Rv
bWFpbnMgJgo+IC0JICAgIGFtZGdwdV9tZW1fdHlwZV90b19kb21haW4oYm8tPnRiby5tZW0ubWVt
X3R5cGUpKQo+IC0JCXJldHVybjsKPiAtCj4gLQkvKgo+IC0JICogd2UgY2hlY2tlZCBhbGwgdGhl
IHByZXJlcXVpc2l0ZXMsIGJ1dCBpdCBsb29rcyBsaWtlIHRoaXMgcGVyIHZtIGJvCj4gLQkgKiBp
cyBjdXJyZW50bHkgZXZpY3RlZC4gYWRkIHRoZSBibyB0byB0aGUgZXZpY3RlZCBsaXN0IHRvIG1h
a2Ugc3VyZSBpdAo+IC0JICogaXMgdmFsaWRhdGVkIG9uIG5leHQgdm0gdXNlIHRvIGF2b2lkIGZh
dWx0Lgo+IC0JICogKi8KPiAtCWxpc3RfbW92ZV90YWlsKCZiYXNlLT52bV9zdGF0dXMsICZ2bS0+
ZXZpY3RlZCk7Cj4gLQliYXNlLT5tb3ZlZCA9IHRydWU7Cj4gLX0KPiAtCj4gICAvKioKPiAgICAq
IGFtZGdwdV92bV9sZXZlbF9zaGlmdCAtIHJldHVybiB0aGUgYWRkciBzaGlmdCBmb3IgZWFjaCBs
ZXZlbAo+ICAgICoKPiBAQCAtMjQ5LDYgKzIwNCw1MSBAQCBzdGF0aWMgdW5zaWduZWQgYW1kZ3B1
X3ZtX2JvX3NpemUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHVuc2lnbmVkIGxldmVsKQo+
ICAgCXJldHVybiBBTURHUFVfR1BVX1BBR0VfQUxJR04oYW1kZ3B1X3ZtX251bV9lbnRyaWVzKGFk
ZXYsIGxldmVsKSAqIDgpOwo+ICAgfQo+Cj4gKy8qKgo+ICsgKiBhbWRncHVfdm1fYm9fYmFzZV9p
bml0IC0gQWRkcyBibyB0byB0aGUgbGlzdCBvZiBib3MgYXNzb2NpYXRlZCB3aXRoIHRoZSB2bQo+
ICsgKgo+ICsgKiBAYmFzZTogYmFzZSBzdHJ1Y3R1cmUgZm9yIHRyYWNraW5nIEJPIHVzYWdlIGlu
IGEgVk0KPiArICogQHZtOiB2bSB0byB3aGljaCBibyBpcyB0byBiZSBhZGRlZAo+ICsgKiBAYm86
IGFtZGdwdSBidWZmZXIgb2JqZWN0Cj4gKyAqCj4gKyAqIEluaXRpYWxpemUgYSBib192YV9iYXNl
IHN0cnVjdHVyZSBhbmQgYWRkIGl0IHRvIHRoZSBhcHByb3ByaWF0ZSBsaXN0cwo+ICsgKgo+ICsg
Ki8KPiArc3RhdGljIHZvaWQgYW1kZ3B1X3ZtX2JvX2Jhc2VfaW5pdChzdHJ1Y3QgYW1kZ3B1X3Zt
X2JvX2Jhc2UgKmJhc2UsCj4gKwkJCQkgICBzdHJ1Y3QgYW1kZ3B1X3ZtICp2bSwKPiArCQkJCSAg
IHN0cnVjdCBhbWRncHVfYm8gKmJvKQo+ICt7Cj4gKwliYXNlLT52bSA9IHZtOwo+ICsJYmFzZS0+
Ym8gPSBibzsKPiArCUlOSVRfTElTVF9IRUFEKCZiYXNlLT5ib19saXN0KTsKPiArCUlOSVRfTElT
VF9IRUFEKCZiYXNlLT52bV9zdGF0dXMpOwo+ICsKPiArCWlmICghYm8pCj4gKwkJcmV0dXJuOwo+
ICsJbGlzdF9hZGRfdGFpbCgmYmFzZS0+Ym9fbGlzdCwgJmJvLT52YSk7Cj4gKwo+ICsJaWYgKGJv
LT50Ym8ucmVzdiAhPSB2bS0+cm9vdC5iYXNlLmJvLT50Ym8ucmVzdikKPiArCQlyZXR1cm47Cj4g
Kwo+ICsJdm0tPmJ1bGtfbW92ZWFibGUgPSBmYWxzZTsKPiArCWlmIChiby0+dGJvLnR5cGUgPT0g
dHRtX2JvX3R5cGVfa2VybmVsKQo+ICsJCWxpc3RfbW92ZSgmYmFzZS0+dm1fc3RhdHVzLCAmdm0t
PnJlbG9jYXRlZCk7Cj4gKwllbHNlCj4gKwkJbGlzdF9tb3ZlKCZiYXNlLT52bV9zdGF0dXMsICZ2
bS0+aWRsZSk7Cj4gKwo+ICsJaWYgKGJvLT5wcmVmZXJyZWRfZG9tYWlucyAmCj4gKwkgICAgYW1k
Z3B1X21lbV90eXBlX3RvX2RvbWFpbihiby0+dGJvLm1lbS5tZW1fdHlwZSkpCj4gKwkJcmV0dXJu
Owo+ICsKPiArCS8qCj4gKwkgKiB3ZSBjaGVja2VkIGFsbCB0aGUgcHJlcmVxdWlzaXRlcywgYnV0
IGl0IGxvb2tzIGxpa2UgdGhpcyBwZXIgdm0gYm8KPiArCSAqIGlzIGN1cnJlbnRseSBldmljdGVk
LiBhZGQgdGhlIGJvIHRvIHRoZSBldmljdGVkIGxpc3QgdG8gbWFrZSBzdXJlIGl0Cj4gKwkgKiBp
cyB2YWxpZGF0ZWQgb24gbmV4dCB2bSB1c2UgdG8gYXZvaWQgZmF1bHQuCj4gKwkgKiAqLwo+ICsJ
bGlzdF9tb3ZlX3RhaWwoJmJhc2UtPnZtX3N0YXR1cywgJnZtLT5ldmljdGVkKTsKPiArCWJhc2Ut
Pm1vdmVkID0gdHJ1ZTsKPiArfQo+ICsKPiAgIC8qKgo+ICAgICogYW1kZ3B1X3ZtX2dldF9wZF9i
byAtIGFkZCB0aGUgVk0gUEQgdG8gYSB2YWxpZGF0aW9uIGxpc3QKPiAgICAqCj4KX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp
c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv
cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==