From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA2E5C71153 for ; Mon, 4 Sep 2023 07:30:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E8BE10E2BB; Mon, 4 Sep 2023 07:30:27 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB2DB10E2B9; Mon, 4 Sep 2023 07:30:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 18A1A61209; Mon, 4 Sep 2023 07:30:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 881FAC433CB; Mon, 4 Sep 2023 07:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693812613; bh=9NOrAiqzUZ6+zYyOrUBxeZ6qQTkIQJkolBNmv9q78q8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=NM2dJFERH4BRPJ+D3W4WuU1mRBGJo+8jJ1h4QG2Hjgyl489nFlTzJ4e2HCfUcEa/n KAyqWUpRkHO3ZsSSP5IjTim7QrGW8eaK9UgiGKHZsVaEKiIpsbvOnqZ80mfP04aXQz aCGOqSn/s/keIuxbqkLdG1wFsF4NnR9uLehGZykcMEjYXtC1IoocHjJXhIsiYmAmuv 241ePTHSXASLzmTQ7DIfaueiGTMYVj0/oN/Leip4dP+KhvUei7LrBhCO+iB5HT+yk2 YebkFjly1eKIXSFkpqRQAZHjs8cwJMfVMGleUmopqmJ2d79cdp8XoiWZ6WLmBjBt7d Mbrd2gb5STJhA== Message-ID: <5a1537b6dc242347783dbe17b055a887.mripard@kernel.org> Date: Mon, 04 Sep 2023 07:30:11 +0000 From: "Maxime Ripard" To: "Douglas Anderson" Subject: Re: [RFT PATCH 14/15] drm/radeon: Call drm_helper_force_disable_all() at shutdown/remove time In-Reply-To: <20230901164111.RFT.14.I022cfc2dcd30e77d4f7005a2d912dd7ab76c0338@changeid> References: <20230901164111.RFT.14.I022cfc2dcd30e77d4f7005a2d912dd7ab76c0338@changeid> Content-Transfer-Encoding: 7bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, alexander.deucher@amd.com, airlied@gmail.com, christian.koenig@amd.com Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, 1 Sep 2023 16:41:25 -0700, Douglas Anderson wrote: > Based on grepping through the source code, this driver appears to be > missing a call to drm_atomic_helper_shutdown(), or in this case the > non-atomic equivalent drm_helper_force_disable_all(), at system > shutdown time and at driver remove time. This is important because > drm_helper_force_disable_all() will cause panels to get disabled > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime