public inbox for amd-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Felix Kuehling <felix.kuehling@amd.com>
To: Huang Rui <ray.huang@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] drm/amdkfd: remove iommu v2 for old apu series
Date: Tue, 18 Aug 2020 11:15:47 -0400	[thread overview]
Message-ID: <5b0f4e19-d4e5-4c67-d4fd-22602d663ab0@amd.com> (raw)
In-Reply-To: <20200818130932.180114-3-ray.huang@amd.com>

Interesting. Does this actually work on Carrizo or Kaveri? I'd like to
see any Thunk changes needed to support this before giving my R-b. For
now this patch is

Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>


Am 2020-08-18 um 9:09 a.m. schrieb Huang Rui:
> We already support the fallback path, so it doesn't need IOMMU v2 flag
> anymore.
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index dab44951c4d8..731f7fdfe9d2 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -48,13 +48,11 @@ extern const struct kfd2kgd_calls arcturus_kfd2kgd;
>  extern const struct kfd2kgd_calls gfx_v10_kfd2kgd;
>  
>  static const struct kfd2kgd_calls *kfd2kgd_funcs[] = {
> -#ifdef KFD_SUPPORT_IOMMU_V2
>  #ifdef CONFIG_DRM_AMDGPU_CIK
>  	[CHIP_KAVERI] = &gfx_v7_kfd2kgd,
>  #endif
>  	[CHIP_CARRIZO] = &gfx_v8_kfd2kgd,
>  	[CHIP_RAVEN] = &gfx_v9_kfd2kgd,
> -#endif
>  #ifdef CONFIG_DRM_AMDGPU_CIK
>  	[CHIP_HAWAII] = &gfx_v7_kfd2kgd,
>  #endif
> @@ -74,7 +72,6 @@ static const struct kfd2kgd_calls *kfd2kgd_funcs[] = {
>  	[CHIP_NAVI14] = &gfx_v10_kfd2kgd,
>  };
>  
> -#ifdef KFD_SUPPORT_IOMMU_V2
>  static const struct kfd_device_info kaveri_device_info = {
>  	.asic_family = CHIP_KAVERI,
>  	.asic_name = "kaveri",
> @@ -112,7 +109,6 @@ static const struct kfd_device_info carrizo_device_info = {
>  	.num_xgmi_sdma_engines = 0,
>  	.num_sdma_queues_per_engine = 2,
>  };
> -#endif
>  
>  static const struct kfd_device_info raven_device_info = {
>  	.asic_family = CHIP_RAVEN,
> @@ -460,11 +456,9 @@ static const struct kfd_device_info navi14_device_info = {
>  
>  /* For each entry, [0] is regular and [1] is virtualisation device. */
>  static const struct kfd_device_info *kfd_supported_devices[][2] = {
> -#ifdef KFD_SUPPORT_IOMMU_V2
>  	[CHIP_KAVERI] = {&kaveri_device_info, NULL},
>  	[CHIP_CARRIZO] = {&carrizo_device_info, NULL},
>  	[CHIP_RAVEN] = {&raven_device_info, NULL},
> -#endif
>  	[CHIP_HAWAII] = {&hawaii_device_info, NULL},
>  	[CHIP_TONGA] = {&tonga_device_info, NULL},
>  	[CHIP_FIJI] = {&fiji_device_info, &fiji_vf_device_info},
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2020-08-18 15:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 13:09 [PATCH v2 1/3] drm/amdkfd: force raven as "dgpu" path (v2) Huang Rui
2020-08-18 13:09 ` [PATCH v2 2/3] drm/amdkfd: abstract the iommu device checking with ignore_crat Huang Rui
2020-08-18 15:11   ` Felix Kuehling
2020-08-19  3:09     ` Huang Rui
2020-08-18 13:09 ` [PATCH v2 3/3] drm/amdkfd: remove iommu v2 for old apu series Huang Rui
2020-08-18 15:15   ` Felix Kuehling [this message]
2020-08-19 11:04     ` Huang Rui
2020-08-18 15:01 ` [PATCH v2 1/3] drm/amdkfd: force raven as "dgpu" path (v2) Felix Kuehling
2020-08-19  2:53   ` Huang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b0f4e19-d4e5-4c67-d4fd-22602d663ab0@amd.com \
    --to=felix.kuehling@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox