From: Felix Kuehling <felix.kuehling@amd.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>,
kernel-janitors@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amdkfd: Remove unnecessary condition in kfd_topology_add_device()
Date: Fri, 25 Nov 2022 11:42:32 -0500 [thread overview]
Message-ID: <5bc1e6bd-efc8-74f6-401e-a88b7f3894ee@amd.com> (raw)
In-Reply-To: <Y4BxRRU+aiblAj2Y@kili>
On 2022-11-25 02:39, Dan Carpenter wrote:
> We re-arranged this code recently so "ret" is always zero at this point.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
I'm applying your patch to amd-staging-drm-next. Thank you!
Felix
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 6f01ebc8557b..bceb1a5b2518 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -2012,10 +2012,9 @@ int kfd_topology_add_device(struct kfd_dev *gpu)
>
> kfd_debug_print_topology();
>
> - if (!res)
> - kfd_notify_gpu_change(gpu_id, 1);
> + kfd_notify_gpu_change(gpu_id, 1);
>
> - return res;
> + return 0;
> }
>
> /**
prev parent reply other threads:[~2022-11-25 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 7:39 [PATCH] drm/amdkfd: Remove unnecessary condition in kfd_topology_add_device() Dan Carpenter
2022-11-25 16:42 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc1e6bd-efc8-74f6-401e-a88b7f3894ee@amd.com \
--to=felix.kuehling@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox