From: Nirmoy <nirmodas@amd.com>
To: christian.koenig@amd.com, Nirmoy Das <nirmoy.das@amd.com>,
amd-gfx@lists.freedesktop.org
Cc: pmenzel+amd-gfx@molgen.mpg.de, alexander.deucher@amd.com,
Tianci.Yin@amd.com, Leo.Liu@amd.com
Subject: Re: [PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd_enc
Date: Thu, 3 Sep 2020 10:38:39 +0200 [thread overview]
Message-ID: <5ca799fd-d0bb-3c75-d30b-f236753e6cc8@amd.com> (raw)
In-Reply-To: <9fc4a69d-3783-0626-5e88-18a579ada03b@gmail.com>
Hi Alex,
If possible, please squash this with:
commit e0300ed8820d19fe108006cf1b69fa26f0b4e3fc
drm/amdgpu: disable gpu-sched load balance for uvd
Regards,
Nirmoy
On 9/2/20 1:07 PM, Christian König wrote:
> Am 02.09.20 um 12:15 schrieb Nirmoy Das:
>> On hardware with multiple uvd instances, dependent uvd_enc jobs
>> may get scheduled to different uvd instances. Because uvd_enc
>> jobs retain hw context, dependent jobs should always run on the
>> same uvd instance. This patch disables GPU scheduler's load balancer
>> for a context that binds jobs from the same context to a uvd
>> instance.
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> index 7cd398d25498..c80d8339f58c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> @@ -114,8 +114,10 @@ static int amdgpu_ctx_init_entity(struct
>> amdgpu_ctx *ctx, u32 hw_ip,
>> scheds = adev->gpu_sched[hw_ip][hw_prio].sched;
>> num_scheds = adev->gpu_sched[hw_ip][hw_prio].num_scheds;
>>
>> + /* disable load balance if the hw engine retains context among
>> dependent jobs */
>> if (hw_ip == AMDGPU_HW_IP_VCN_ENC ||
>> hw_ip == AMDGPU_HW_IP_VCN_DEC ||
>> + hw_ip == AMDGPU_HW_IP_UVD_ENC ||
>> hw_ip == AMDGPU_HW_IP_UVD) {
>> sched = drm_sched_pick_best(scheds, num_scheds);
>> scheds = &sched;
>> --
>> 2.28.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cnirmoy.das%40amd.com%7C14abaffe97944d1732a008d84f306f01%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637346416736947845&sdata=1F8al%2F7xTX2sjhoUI88UNE2mjWPJxNpFslmAuBJjevU%3D&reserved=0
>>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-09-03 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 10:15 [PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd_enc Nirmoy Das
2020-09-02 11:07 ` Christian König
2020-09-03 8:38 ` Nirmoy [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-02 10:08 Nirmoy Das
2020-09-02 10:12 ` Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ca799fd-d0bb-3c75-d30b-f236753e6cc8@amd.com \
--to=nirmodas@amd.com \
--cc=Leo.Liu@amd.com \
--cc=Tianci.Yin@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=nirmoy.das@amd.com \
--cc=pmenzel+amd-gfx@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox