AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Christian König" <christian.koenig@amd.com>,
	"Michele Palazzi" <sysdadmin@m1k.cloud>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	harry.wentland@amd.com, sunpeng.li@amd.com,
	alexander.deucher@amd.com, Rodrigo.Siqueira@igalia.com,
	alex.hung@amd.com, aurabindo.pillai@amd.com
Subject: Re: [PATCH] drm/amd/display: add module param to disable immediate vblank off
Date: Wed, 11 Feb 2026 09:04:41 -0600	[thread overview]
Message-ID: <5e3cbeb9-bd22-47e8-9780-fe575e50eab8@amd.com> (raw)
In-Reply-To: <7a1fa826-cddc-4f8d-ae45-afe6ddecd6e0@amd.com>

On 2/11/26 4:07 AM, Christian König wrote:
> Dropping stable, putting Grep on BCC.
> 
> On 2/11/26 10:19, Greg KH wrote:
>> On Wed, Feb 11, 2026 at 08:45:29AM +0100, Michele Palazzi wrote:
>>> Add amdgpu.no_vblank_immediate parameter to optionally disable the
>>> immediate vblank disable path on DCN35+ non-PSR CRTCs. When set to 1,
>>> a 2-frame offdelay is used instead, matching the behavior used for
>>> older hardware and DGPUs.
>>
>> Please no more module parameters, this is not the 1990's with only one
>> one device in the system.  Please fix this the proper way.
> 
> I just wanted to write the same.
> 
> We can of course implement something in DAL/DC, but clearly not behind a module parameter.
> 
> Or is there any other negative consequence except for that the display blanking is delayed by ~40ms?
> 

If there is a strong enough interest in keeping something like this as a 
debugging mechanism, there is already an amdgpu.dcdebugmask parameter. 
This accepts a bitmask of debug bits.  Assign this functionality to a 
new bit.

  reply	other threads:[~2026-02-11 15:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11  7:45 [PATCH] drm/amd/display: add module param to disable immediate vblank off Michele Palazzi
2026-02-11  9:19 ` Greg KH
2026-02-11  9:51   ` Michele Palazzi
2026-02-11 10:07   ` Christian König
2026-02-11 15:04     ` Mario Limonciello [this message]
2026-02-12 10:20     ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e3cbeb9-bd22-47e8-9780-fe575e50eab8@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Rodrigo.Siqueira@igalia.com \
    --cc=alex.hung@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aurabindo.pillai@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=sunpeng.li@amd.com \
    --cc=sysdadmin@m1k.cloud \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox