From: Felix Kuehling <felix.kuehling@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdkfd: fix gfx_target_version for certain 11.0.3 devices
Date: Thu, 25 May 2023 17:15:31 -0400 [thread overview]
Message-ID: <5f75618e-ed88-24b5-dc03-1e209c4e5936@amd.com> (raw)
In-Reply-To: <20230525201234.1138937-1-alexander.deucher@amd.com>
On 2023-05-25 16:12, Alex Deucher wrote:
> Certain boards with GC IP 11.0.3 need slightly different handling
> in the shader compiler due to board specific bounding box
> optimizations.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index 862a50f7b490..ebc3c3f965f9 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -411,8 +411,15 @@ struct kfd_dev *kgd2kfd_probe(struct amdgpu_device *adev, bool vf)
> f2g = &gfx_v11_kfd2kgd;
> break;
> case IP_VERSION(11, 0, 3):
> - /* Note: Compiler version is 11.0.1 while HW version is 11.0.3 */
> - gfx_target_version = 110001;
> + if ((adev->pdev->device == 0x7460 &&
> + adev->pdev->revision == 0x00) ||
> + (adev->pdev->device == 0x7461 &&
> + adev->pdev->revision == 0x00))
> + /* Note: Compiler version is 11.0.5 while HW version is 11.0.3 */
> + gfx_target_version = 110005;
> + else
> + /* Note: Compiler version is 11.0.1 while HW version is 11.0.3 */
> + gfx_target_version = 110001;
> f2g = &gfx_v11_kfd2kgd;
> break;
> default:
prev parent reply other threads:[~2023-05-25 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 20:12 [PATCH] drm/amdkfd: fix gfx_target_version for certain 11.0.3 devices Alex Deucher
2023-05-25 21:15 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f75618e-ed88-24b5-dc03-1e209c4e5936@amd.com \
--to=felix.kuehling@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox