From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A320F94CB0 for ; Tue, 21 Apr 2026 21:22:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C2D810EDCC; Tue, 21 Apr 2026 21:22:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="KUsCWiyj"; dkim-atps=neutral Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010031.outbound.protection.outlook.com [52.101.201.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BC8110EDC7; Tue, 21 Apr 2026 21:22:54 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bwgzMrbkpX3FtNYNNV8uH3tjpCRvqpaYKv+xmXfBnanJB26ef2tRhOd1ie5S2/FexRxk2aB+dt8fJB3Ez9J0A39T06Vc0dQtzyscq6X994ur1JSCvWQdx/hl6QDpbHstJ02Ou7m01FjiyuRCDbjMxhGd4zUi/Bj8SCsp7jOBsLz9hKsqeLM7mXFv+B/7FUX7zWYmEptHlnNAj/fyCqMxjyEqLXSRGPOFLBomJAweYR5a/o326ypRpmtUMXdF12mCIWpL20TkQEopKmYf4Sk6rlRt4DleMmemN3rAJ3zMY6YPfDTYtVIeL+JaIXBx6iGtoFoI8hTSQErtbe5jSCvYTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1hToc/sZYZjf5XK3rllNnz1aELJoAKCQGSywn6ptOE=; b=sLCqjmqYfn5AZ6mvTSwumetvyBX7Hx3fhFX7KUeg6CJOaj0SIP4IVFSYZBwDzEjuLQz3cfpTAQ6paQ8P+YD3e582BuC/lSTnYUkxJflLtwZqArRLTZr4Vhh0nbpbsCbgqFqr/W6xqse1mE8zFvKtIftGOkCqrCheSihCdfZwAggPYdI5HSOhAxaKXsmI6jgF6PPV7BP9AHX3QmmS3RgnTVeAP7g9TSQ3f415IkmygIEuLPeSoP2Ks9yl+binn1qTi2vMZovvkHhnqL/Kft9lpWhXHhiCz9GHm91LT9y5psgJf40OQ6+JI8dARmmzR7OJKBITNjiiTlAmZSaDESMvzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1hToc/sZYZjf5XK3rllNnz1aELJoAKCQGSywn6ptOE=; b=KUsCWiyjEqDQccysc4olNuGsA3qXzO0q5NlNsek8rdnbglp/M32/0g7McTYSJ0QL/Bn0kw6Wth6sLaufV+GmKMDeOxkb+RB1e0NP9KsQKGEGY5YmIOdV3xzUjVHb9x7xMaPVhya/RM1g6oApD3tC8TogxYdDSFcas3XmHmTRp1Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB8476.namprd12.prod.outlook.com (2603:10b6:8:17e::15) by SJ0PR12MB6904.namprd12.prod.outlook.com (2603:10b6:a03:483::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Tue, 21 Apr 2026 21:22:51 +0000 Received: from DM4PR12MB8476.namprd12.prod.outlook.com ([fe80::2d79:122f:c62b:1cd8]) by DM4PR12MB8476.namprd12.prod.outlook.com ([fe80::2d79:122f:c62b:1cd8%7]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026 21:22:51 +0000 Message-ID: <605bc833-43bd-459b-aac9-c9ea5714fd84@amd.com> Date: Tue, 21 Apr 2026 15:22:50 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 2/9] drm/colorop: Add limited-range YUV-to-RGB CSC FF enum values To: Harry Wentland , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org References: <20260330153451.99472-1-harry.wentland@amd.com> <20260330153451.99472-3-harry.wentland@amd.com> Content-Language: en-US From: Alex Hung In-Reply-To: <20260330153451.99472-3-harry.wentland@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0258.namprd03.prod.outlook.com (2603:10b6:303:b4::23) To DM4PR12MB8476.namprd12.prod.outlook.com (2603:10b6:8:17e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB8476:EE_|SJ0PR12MB6904:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e3272f1-9105-4b3c-f646-08de9fec24fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: 39Q8GKCZ+ayUunasaGiM7wquQv2tzfo/wJqlhfY4Ofj3Lq8e0yyR2YyTtFDQ/xz0ndz2KmZ1nBKWzBuI29PYQJyXXhW+XUCHrTN0fxDnBaTq4RtPoM0E0hzAdFabewbiAHadcx7rZS1OStBGsXO5mASBQlIaHnxeu7G1RKYFCVhiU3hdL9j9mAjelIs68wPpTlC4CN3MuqecQ1W1AWO3jSbetyPcbdi1A/QNPpkI2TAV8VgF+mdTFuJz74kZ4VZjHG3HpCJMyIwE7VwQ0Fm47rjipgJ4nHuCwySXEjONVXPniCuqUoge9ZjgNTf2Uu/strBftqzjRx0VRyopUWrIBDWFOJHLFfvbfmyqaaXnPW6ccJBSMMofZ5jNDQvOzn9UwUHZNILMbeaq7NrsexVZuTTnkeBz5ifsb1zEbFVvVcvkmr64oTLHT0r8rUYi/ynkCJpN7/F2iGMm01JMRJpl0mzHoXwLNhwjtfi4H2k/2euDhpO/nHVhU3PSeDpNzGy8rNN7kr8DaQ6gLJxWb/fGvJGJzHSroGUQgr/3R8ou1GKY7lmXKhMLLtOWEUULXgoIRsaCXq1hc0vjXVIkFzxg3868UvWxJ9MLAA8Z/6PZDa+Xp6ZIDlZdDqj5RGKfolTJOuS2MXQDCkC5xEuukp8AcA3MgerudV1YnHJmIwyzSHB+WZoaCJPKrIrJ4TBLK6AsasRrWFW0pyRR7hXoMck0CPKgztuZzu7O8GuWy/8dA+Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB8476.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(18002099003)(56012099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmJZY3gyZW1QaytpUHBlcGRhWXY2QXRSRHp4S2xkdDJVdXhlM21pTjc3YkND?= =?utf-8?B?RTVROUFHTXB6WW5DTS9laGVieDRTZUFPZ3g0WnZ0VzhXYnMwYUIvS3hHNXNj?= =?utf-8?B?WUFKMFlkRnlSb0dYT01JWVZJYnIxWXZZS1dnUUFNaU5MVnB2dDF6bmhySDJ6?= =?utf-8?B?RmZFcW5rcHJ1KzZGRzM3RTlxUUNIVVliTXczYXMxZlVvMU5jaDNIcnhmSUlO?= =?utf-8?B?UUhGTjBIblpWYU1WRlhhZ200eUlieG5uRWQxZDhoVVg1ZjRuQkRsakxlVlZY?= =?utf-8?B?RjNFdGIxemVtM21vMWRCdU5CQlE1UzlNRTdhNUxaOXdYclJycERoZ2I4TnNF?= =?utf-8?B?QXBZT3FuaWFaZ2FrbDRFZjhYMGp0dTNkKy9HeXdtenB5L1ZiaFVFZUtueVlp?= =?utf-8?B?RDB5QXVrOGw0cStNakV1LzVTRHZuRzFkeTZ2dmJCMi9OR05kUk5YTjdxYXJj?= =?utf-8?B?T3lsb3BrZnNaNVVxSERRd2huY0RaeUZRaUltczlHK2tRYjlWd2g1TXdzSW5y?= =?utf-8?B?UE1pc0d3VUZZOWxvc3AxVHhFbTRCSlhtTno0cW5MZ3A5T3BsSTUvdG1OREtl?= =?utf-8?B?ZFJFY0Z4d0RVT0VIQVJWMjFwWWtWL0lSUW1oR1pDb1NHY3I4NEtaK2tYazhR?= =?utf-8?B?V1JQOXBZVlRFdXR6ckV3RU95Y2Z3YjdFUXIzcW44RmZJdWJRV3FTSWVpZmlh?= =?utf-8?B?SElaWCtLeDM2WnQ5cGFibE9EMGJaaDBMWm1Dd1E3VzUyZ3V2WURaekw3bko0?= =?utf-8?B?TUpmS2RNVTFOSXdCajJ1SFYzTU9HR1RGdHhHa0tGdHBjZk0vSXlsaTNMOU5h?= =?utf-8?B?OS9xZUM1eVYwYXBZM0tXNkdkcDZqT2VseUF4TExLWStONzcrMDhmMkppc1I0?= =?utf-8?B?VU4va2gweWdGVGtnS1BBNTVOYm5aU25yMDNRUnU2ZWljdG5SZGQweW5VYnJi?= =?utf-8?B?ZjVTWUhRVTFMVDBaOW9LanllZllRSkZpa1JWRXBGYnlTR0xQRWQzUDVmSzF2?= =?utf-8?B?KzFOTkt0dWQ1TkJPeE91ZW9vZ296NjQvY3lweXNSc21zUkdaNFRMMjJWTTJ5?= =?utf-8?B?TGtxY2dwRFpPYnl2ZEVTa2lxUjFtMTVYS01hTmg5VTFyekZHNnU1K2NKZTJO?= =?utf-8?B?ZkxVQXpPazFTMEYwZGd3RUFCUzFrdzJGc083QWlQVUxKRE00WG4wK3RtU0E0?= =?utf-8?B?OUxadzBubFQ2aFgwcDF5NDJDNWxWVDRiRGZqRTU1M3h2Uit6MEJ6ZHViRWxx?= =?utf-8?B?UEc4ZzE4eDMrZFFvbGNTVy9YL2pjTzAxaXhVcVgwTWowQjkwQzdCY2JrTnMv?= =?utf-8?B?aWxrQXNGMjhoWmJMZkZZM1lpTmdDNG1kdzhGM0tHMzZUaTFieG5OWVA4eVor?= =?utf-8?B?TVNlMGkwczBKbzVseElTUVNLbVN1c0lZYVg2YlZqTmNDVDN2dXJUbG8vRnN1?= =?utf-8?B?UE1POHI4bUUyQTBSQmk4VDR5cHNTS2YxKzcxNWN5d3JXR1I4QkxFTEZkVnR3?= =?utf-8?B?OTFDTmNhNlZoUFpTbDM1ajFJU3hxWUt3OFBNWmxMWG9zRDdHNlNuZjk5UTJj?= =?utf-8?B?UHJ3TDloclFRVW1vZUFHNkRiaDNocitUYWJ3aC9pN1laR3pQU2xwN0Z4N2hF?= =?utf-8?B?eG9qUSsxUmM3MTNuUmVHbHl6dFlwSS9XWDN5ZkllRUl3SzJpc1dmSlpabGow?= =?utf-8?B?Z29HTkQ0UkY1VTVDUkJGVjBsejFNY1dkQjZvTVBkZ3BpMSs4N0JsTWxhbDAx?= =?utf-8?B?K0tJbGRKQlJZenJ4OC9PMmFGWVcraGpRMXZNbG9qV052TksvR2tWUkF4Vjhq?= =?utf-8?B?ZnpxcklvWlJwMlpiTzRzYktIWDFCSktyU21Hbm5DV0c0bjlCdWVCa2tVSEt0?= =?utf-8?B?TmtzWXVyK0ZGendtS0VYR3hnNUZoU3JVK1FrV0RhTThsVUdmRkhQcGk0ckFK?= =?utf-8?B?UmJCWlVlTjgwS0xyVUpWY2xDcFA5eVptUXpLRVdQMUlJcTRmVFkrK01GUWI0?= =?utf-8?B?bkxWSWgxb0ZhTVpreThBR3hyQ2FnSHNNbW1hb1ZsVWtvdld5eHBUK3BGeFU1?= =?utf-8?B?enkzVTgzSjdBUTNpbHVWYjJIY3ptQXR0dnVQWUxyVURhQmZsbEQySElIaWdZ?= =?utf-8?B?TGF5TTFKL2pEQzg4aXFRZHFYbWdvQnBpamNnU1hMWUlKdU5mREppdlRteUF4?= =?utf-8?B?WVR6UlNNZlYwSTZnZzdDR0ErUUxsNHdJVmF2UU1oRmJnNENmdUdub2FyR1RZ?= =?utf-8?B?MFpwa0pMUkdjWDdvUDl4ZEN1OUlXZVg4dmhnKytIS2lWTnk1SVE4RHE3UkM0?= =?utf-8?B?dXF3eDBTZFU3Q3J1dzIyS2E4Ni9aZFBYc0VUb3hQK0JSTEVETm1pQT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e3272f1-9105-4b3c-f646-08de9fec24fc X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB8476.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2026 21:22:51.6192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 26Wok9rhrO0YAzEM4hIgV+Dy6EmcP3SC7AyJhy65p5TiSG/8gwSqm2YA7Fr2zS/X7C87TF96I61RJbhyGmGDuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6904 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 3/30/26 09:34, Harry Wentland wrote: > Add three new limited-range YUV-to-RGB conversion presets to the > CSC Fixed-Function colorop enum: > > - DRM_COLOROP_CSC_FF_YUV601_LIMITED_RGB601 > - DRM_COLOROP_CSC_FF_YUV709_LIMITED_RGB709 > - DRM_COLOROP_CSC_FF_YUV2020_LIMITED_RGB2020 > > The existing full-range enums (YUV601_RGB601, YUV709_RGB709, > YUV2020_RGB2020) are kept as-is. The limited-range variants are > inserted after their corresponding full-range entries. > > This gives drivers the ability to advertise support for both full > and limited range YCbCr framebuffers via the color pipeline, > replacing the need for separate COLOR_ENCODING and COLOR_RANGE > properties on the CSC colorop. > > Assisted-by Claude:claude-opus-4.6 Missing ":" after Assisted-by above Reviewed-by: Alex Hung > > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/drm_colorop.c | 11 +++++---- > include/drm/drm_colorop.h | 42 ++++++++++++++++++++++++++++++----- > 2 files changed, 43 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c > index 6a345e2e8b15..f0d11cf7e3cd 100644 > --- a/drivers/gpu/drm/drm_colorop.c > +++ b/drivers/gpu/drm/drm_colorop.c > @@ -92,10 +92,13 @@ static const struct drm_prop_enum_list drm_colorop_lut3d_interpolation_list[] = > }; > > static const char * const colorop_csc_ff_type_names[] = { > - [DRM_COLOROP_CSC_FF_YUV601_RGB601] = "YUV601 to RGB601", > - [DRM_COLOROP_CSC_FF_YUV709_RGB709] = "YUV709 to RGB709", > - [DRM_COLOROP_CSC_FF_YUV2020_RGB2020] = "YUV2020 to RGB2020", > - [DRM_COLOROP_CSC_FF_RGB709_RGB2020] = "RGB709 to RGB2020", > + [DRM_COLOROP_CSC_FF_YUV601_RGB601] = "YUV601 to RGB601", > + [DRM_COLOROP_CSC_FF_YUV601_LIMITED_RGB601] = "YUV601 Limited to RGB601", > + [DRM_COLOROP_CSC_FF_YUV709_RGB709] = "YUV709 to RGB709", > + [DRM_COLOROP_CSC_FF_YUV709_LIMITED_RGB709] = "YUV709 Limited to RGB709", > + [DRM_COLOROP_CSC_FF_YUV2020_RGB2020] = "YUV2020 to RGB2020", > + [DRM_COLOROP_CSC_FF_YUV2020_LIMITED_RGB2020] = "YUV2020 Limited to RGB2020", > + [DRM_COLOROP_CSC_FF_RGB709_RGB2020] = "RGB709 to RGB2020", > }; > > /* Init Helpers */ > diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h > index 2cd8e0779c2a..c414b9070afb 100644 > --- a/include/drm/drm_colorop.h > +++ b/include/drm/drm_colorop.h > @@ -145,31 +145,61 @@ enum drm_colorop_csc_ff_type { > * > * enum string "YUV601 to RGB601" > * > - * Selects the fixed-function CSC preset that converts YUV > - * (BT.601) colorimetry to RGB (BT.601). > + * Selects the fixed-function CSC preset that converts full-range > + * YUV (BT.601) colorimetry to RGB (BT.601). > */ > DRM_COLOROP_CSC_FF_YUV601_RGB601, > > + /** > + * @DRM_COLOROP_CSC_FF_YUV601_LIMITED_RGB601: > + * > + * enum string "YUV601 Limited to RGB601" > + * > + * Selects the fixed-function CSC preset that converts limited-range > + * YUV (BT.601) colorimetry to RGB (BT.601). > + */ > + DRM_COLOROP_CSC_FF_YUV601_LIMITED_RGB601, > + > /** > * @DRM_COLOROP_CSC_FF_YUV709_RGB709: > * > * enum string "YUV709 to RGB709" > * > - * Selects the fixed-function CSC preset that converts YUV > - * (BT.709) colorimetry to RGB (BT.709). > + * Selects the fixed-function CSC preset that converts full-range > + * YUV (BT.709) colorimetry to RGB (BT.709). > */ > DRM_COLOROP_CSC_FF_YUV709_RGB709, > > + /** > + * @DRM_COLOROP_CSC_FF_YUV709_LIMITED_RGB709: > + * > + * enum string "YUV709 Limited to RGB709" > + * > + * Selects the fixed-function CSC preset that converts limited-range > + * YUV (BT.709) colorimetry to RGB (BT.709). > + */ > + DRM_COLOROP_CSC_FF_YUV709_LIMITED_RGB709, > + > /** > * @DRM_COLOROP_CSC_FF_YUV2020_RGB2020: > * > * enum string "YUV2020 to RGB2020" > * > - * Selects the fixed-function CSC preset that converts YUV > - * (BT.2020) colorimetry to RGB (BT.2020). > + * Selects the fixed-function CSC preset that converts full-range > + * YUV (BT.2020) colorimetry to RGB (BT.2020). > */ > DRM_COLOROP_CSC_FF_YUV2020_RGB2020, > > + /** > + * @DRM_COLOROP_CSC_FF_YUV2020_LIMITED_RGB2020: > + * > + * enum string "YUV2020 Limited to RGB2020" > + * > + * Selects the fixed-function CSC preset that converts limited-range > + * YUV (BT.2020) colorimetry to RGB (BT.2020). > + */ > + DRM_COLOROP_CSC_FF_YUV2020_LIMITED_RGB2020, > + > /** > * @DRM_COLOROP_CSC_FF_RGB709_RGB2020: > *