From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Liu, Shaoyun" <Shaoyun.Liu-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: Adjust IB test timeout for XGMI configuration
Date: Wed, 3 Apr 2019 19:12:38 +0200 [thread overview]
Message-ID: <627a8360-3393-3fb3-4412-18e2b9adf771@gmail.com> (raw)
In-Reply-To: <1554306139-17280-1-git-send-email-shaoyun.liu-5C7GfCeVMHo@public.gmane.org>
Am 03.04.19 um 17:42 schrieb Liu, Shaoyun:
> On XGMI configuration the ib test may tooks longer to finish
>
> Change-Id: If3afd8eac3c342d32c387804b51fc4a4bdd35d35
> Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> index 0b8ef2d..6c508d7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> @@ -35,6 +35,7 @@
> #include "amdgpu_trace.h"
>
> #define AMDGPU_IB_TEST_TIMEOUT msecs_to_jiffies(1000)
> +#define AMDGPU_IB_TEST_GFX_XGMI_TIMEOU msecs_to_jiffies(2000)
>
> /*
> * IB
> @@ -344,7 +345,8 @@ int amdgpu_ib_ring_tests(struct amdgpu_device *adev)
> * cost waiting for it coming back under RUNTIME only
> */
> tmo_gfx = 8 * AMDGPU_IB_TEST_TIMEOUT;
> - }
> + } else if (adev->gmc.xgmi.hive_id)
> + tmo_gfx = AMDGPU_IB_TEST_GFX_XGMI_TIMEOU;
A style nit pick here: The "else" branch should have { } as well when
the "if" has them.
Apart from that the patch is Reviewed-by: Christian König
<christian.koenig@amd.com>.
Christian.
>
> for (i = 0; i < adev->num_rings; ++i) {
> struct amdgpu_ring *ring = adev->rings[i];
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-04-03 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 15:42 [PATCH] drm/amdgpu: Adjust IB test timeout for XGMI configuration Liu, Shaoyun
[not found] ` <1554306139-17280-1-git-send-email-shaoyun.liu-5C7GfCeVMHo@public.gmane.org>
2019-04-03 17:02 ` Alex Deucher
2019-04-03 17:12 ` Christian König [this message]
[not found] ` <627a8360-3393-3fb3-4412-18e2b9adf771-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-03 17:15 ` Liu, Shaoyun
-- strict thread matches above, loose matches on Subject: below --
2019-04-03 17:06 Liu, Shaoyun
2019-04-02 18:12 Liu, Shaoyun
[not found] ` <1554228693-28822-1-git-send-email-shaoyun.liu-5C7GfCeVMHo@public.gmane.org>
2019-04-03 7:55 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=627a8360-3393-3fb3-4412-18e2b9adf771@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Shaoyun.Liu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox