From: "Christian König" <christian.koenig@amd.com>
To: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org,
"Xiaogang . Chen" <Xiaogang.Chen@amd.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] drm/amdgpu/: Add missing kdoc entry in amdgpu_vm_handle_fault function
Date: Thu, 5 Sep 2024 09:41:50 +0200 [thread overview]
Message-ID: <67910b74-8b62-40b3-9f65-e59e64ab4f0a@amd.com> (raw)
In-Reply-To: <20240828030926.4065919-1-srinivasan.shanmugam@amd.com>
Am 28.08.24 um 05:09 schrieb Srinivasan Shanmugam:
> This commit adds a description for the 'ts' parameter in the
> amdgpu_vm_handle_fault function's comment block.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2781: warning: Function parameter or struct member 'ts' not described in 'amdgpu_vm_handle_fault'
>
> Cc: Xiaogang.Chen <Xiaogang.Chen@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408251419.vgZHg3GV-lkp@intel.com/
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> v2: Added Reported-by (Xiaogang)
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index ad2e469548c9..0fa165e8fb40 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2766,6 +2766,7 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
> * amdgpu_vm_handle_fault - graceful handling of VM faults.
> * @adev: amdgpu device pointer
> * @pasid: PASID of the VM
> + * @ts: Timestamp of the fault
> * @vmid: VMID, only used for GFX 9.4.3.
> * @node_id: Node_id received in IH cookie. Only applicable for
> * GFX 9.4.3.
prev parent reply other threads:[~2024-09-05 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 3:09 [PATCH v2] drm/amdgpu/: Add missing kdoc entry in amdgpu_vm_handle_fault function Srinivasan Shanmugam
2024-08-28 15:18 ` Chen, Xiaogang
2024-09-05 7:41 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67910b74-8b62-40b3-9f65-e59e64ab4f0a@amd.com \
--to=christian.koenig@amd.com \
--cc=Xiaogang.Chen@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=lkp@intel.com \
--cc=srinivasan.shanmugam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).