From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH umr] Fix VMID of chained IBs
Date: Tue, 10 Apr 2018 17:29:24 +0200 [thread overview]
Message-ID: <6a0eeee2-a29f-4eb0-84d4-ae7424fa553c@gmail.com> (raw)
In-Reply-To: <20180410152349.2716-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
Am 10.04.2018 um 17:23 schrieb Tom St Denis:
> We were using the VMID field literally when inside an IB it's inherited instead
>
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> src/lib/dump_ib.c | 8 ++++----
> src/lib/ring_decode.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/lib/dump_ib.c b/src/lib/dump_ib.c
> index 74a3241c309e..cbf859e3633b 100644
> --- a/src/lib/dump_ib.c
> +++ b/src/lib/dump_ib.c
> @@ -39,10 +39,10 @@ void umr_dump_ib(struct umr_asic *asic, struct umr_ring_decoder *decoder)
> if (decoder->src.ib_addr == 0)
> printf("ring[%s%u%s]", BLUE, (unsigned)decoder->src.addr, RST);
> else
> - printf("IB[%s%u%s] at %s%d%s@%s0x%llx%s",
> - BLUE, (unsigned)decoder->src.addr, RST,
> - YELLOW, (int)decoder->src.vmid, RST,
> - YELLOW, (unsigned long long)decoder->src.ib_addr, RST);
> + printf("IB[%s%u%s@%s0x%llx%s + %s0x%x%s]",
> + BLUE, (int)decoder->src.vmid, RST,
> + YELLOW, (unsigned long long)decoder->src.ib_addr, RST,
> + YELLOW, (unsigned)decoder->src.addr * 4, RST);
>
> printf("\n");
>
> diff --git a/src/lib/ring_decode.c b/src/lib/ring_decode.c
> index c1d6bcb98bae..42265e0a74c9 100644
> --- a/src/lib/ring_decode.c
> +++ b/src/lib/ring_decode.c
> @@ -540,7 +540,7 @@ static void print_decode_pm4_pkt3(struct umr_asic *asic, struct umr_ring_decoder
> break;
> case 2: printf("IB_SIZE:%s%lu%s, VMID: %s%lu%s", BLUE, BITS(ib, 0, 20), RST, BLUE, BITS(ib, 24, 32), RST);
> decoder->pm4.next_ib_state.ib_size = BITS(ib, 0, 20) * 4;
> - decoder->pm4.next_ib_state.ib_vmid = BITS(ib, 24, 32);
> + decoder->pm4.next_ib_state.ib_vmid = decoder->next_ib_info.vmid ? decoder->next_ib_info.vmid : BITS(ib, 24, 32);
> add_ib_pm4(decoder);
> break;
> default: printf("Invalid word for opcode 0x%02lx", (unsigned long)decoder->pm4.cur_opcode);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-04-10 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:23 [PATCH umr] Fix VMID of chained IBs Tom St Denis
[not found] ` <20180410152349.2716-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2018-04-10 15:29 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a0eeee2-a29f-4eb0-84d4-ae7424fa553c@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=tom.stdenis-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox