From: "Christian König" <christian.koenig@amd.com>
To: Jiawei Gu <Jiawei.Gu@amd.com>,
amd-gfx@lists.freedesktop.org, Andrey.Grodzovsky@amd.com,
Monk.Liu@amd.com, Emily.Deng@amd.com, Horace.Chen@amd.com
Subject: Re: [PATCH 2/2] drm/amdgpu: fill scheduler with device ptr
Date: Wed, 16 Feb 2022 12:17:21 +0100 [thread overview]
Message-ID: <6ea78726-4121-a01a-57d1-76d496e6bcc8@amd.com> (raw)
In-Reply-To: <20220216072223.8394-2-Jiawei.Gu@amd.com>
Am 16.02.22 um 08:22 schrieb Jiawei Gu:
> Now scheduler contains device ptr. Add it so scheduler printing can be
> more reader-friendly under multiple GPU scenario.
>
> Signed-off-by: Jiawei Gu <Jiawei.Gu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> index 4787cb3acaed..da53983c93f9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> @@ -506,6 +506,7 @@ int amdgpu_fence_driver_init_ring(struct amdgpu_ring *ring,
> break;
> }
>
> + ring->sched.dev = adev->dev;
That should probably be a parameter to drm_sched_init() instead and I'm
not sure what happens in the print when this is NULL.
So make sure to update all other drivers which want to use
drm_sched_init() as well.
Regards,
Christian.
> r = drm_sched_init(&ring->sched, &amdgpu_sched_ops,
> num_hw_submission, amdgpu_job_hang_limit,
> timeout, sched_score, ring->name);
next prev parent reply other threads:[~2022-02-16 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 7:22 [PATCH 1/2] drm/sched: Add device pointer to drm_gpu_scheduler Jiawei Gu
2022-02-16 7:22 ` [PATCH 2/2] drm/amdgpu: fill scheduler with device ptr Jiawei Gu
2022-02-16 11:17 ` Christian König [this message]
2022-02-17 2:46 ` Gu, JiaWei (Will)
2022-02-17 7:39 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ea78726-4121-a01a-57d1-76d496e6bcc8@amd.com \
--to=christian.koenig@amd.com \
--cc=Andrey.Grodzovsky@amd.com \
--cc=Emily.Deng@amd.com \
--cc=Horace.Chen@amd.com \
--cc=Jiawei.Gu@amd.com \
--cc=Monk.Liu@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox