Re: [PATCH v2 4/4] drm/amd: Enable seamless boot by default on newer ASICs

[Harry Wentland <harry.wentland@amd.com>]

On 2023-09-13 13:14, Mario Limonciello wrote:
> Seamless boot can technically be supported as far back as DCN1
> but to avoid regressions on older hardware, enable it for DCN3 and
> later.
> 
> If users report using the module parameter that it works on older
> ASICs as well, this can be adjusted.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 15 ++++-----------
>   1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 2116e016178a..38fafed31a1b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1361,9 +1361,9 @@ bool amdgpu_device_need_post(struct amdgpu_device *adev)
>   /*
>    * Check whether seamless boot is supported.
>    *
> - * So far we only support seamless boot on select ASICs.
> - * If everything goes well, we may consider expanding
> - * seamless boot to other ASICs.
> + * So far we only support seamless boot on DCE 3.0 or later.
> + * If users report that it works on older ASICS as well, we may
> + * loosen this.
>    */
>   bool amdgpu_device_seamless_boot_supported(struct amdgpu_device *adev)
>   {
> @@ -1383,14 +1383,7 @@ bool amdgpu_device_seamless_boot_supported(struct amdgpu_device *adev)
>   	if (adev->mman.keep_stolen_vga_memory)
>   		return false;
>   
> -	switch (adev->ip_versions[DCE_HWIP][0]) {
> -	case IP_VERSION(3, 0, 1):
> -		return true;
> -	default:
> -		break;
> -	}
> -
> -	return false;
> +	return adev->ip_versions[DCE_HWIP][0] > IP_VERSION(3, 0, 0);
>   }
>   
>   /*