From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/4] drm/amdgpu: Plus NULL function pointer check Date: Mon, 12 Mar 2018 13:54:59 +0100 Message-ID: <71e3bf37-5289-422b-7b04-de2d4e60ce9c@gmail.com> References: <1520858050-7338-1-git-send-email-Rex.Zhu@amd.com> <1520858050-7338-2-git-send-email-Rex.Zhu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1520858050-7338-2-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Rex Zhu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTIuMDMuMjAxOCB1bSAxMzozNCBzY2hyaWViIFJleCBaaHU6Cj4gQ2hhbmdlLUlkOiBJZmQ2 NTUzNjQ2ZTc0NjhiYzkzNTUwNDA3NTgxNjA3NDM3M2UxZDU4ZAo+IFNpZ25lZC1vZmYtYnk6IFJl eCBaaHUgPFJleC5aaHVAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9kZXZpY2UuYyB8IDEyICsrKysrKystLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQs IDcgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKPiBpbmRleCA1NmIyMjQ1Li5kNjBlY2M1IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IEBAIC0xNDE1LDEy ICsxNDE1LDE0IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2RldmljZV9pcF9sYXRlX3NldF9jZ19zdGF0 ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAkJaWYgKGFkZXYtPmlwX2Jsb2Nrc1tp XS52ZXJzaW9uLT50eXBlICE9IEFNRF9JUF9CTE9DS19UWVBFX1VWRCAmJgo+ICAgCQkgICAgYWRl di0+aXBfYmxvY2tzW2ldLnZlcnNpb24tPnR5cGUgIT0gQU1EX0lQX0JMT0NLX1RZUEVfVkNFKSB7 Cj4gICAJCQkvKiBlbmFibGUgY2xvY2tnYXRpbmcgdG8gc2F2ZSBwb3dlciAqLwo+IC0JCQlyID0g YWRldi0+aXBfYmxvY2tzW2ldLnZlcnNpb24tPmZ1bmNzLT5zZXRfY2xvY2tnYXRpbmdfc3RhdGUo KHZvaWQgKilhZGV2LAo+ICsJCQlpZiAoYWRldi0+aXBfYmxvY2tzW2ldLnZlcnNpb24tPmZ1bmNz LT5zZXRfY2xvY2tnYXRpbmdfc3RhdGUpIHsKCldoeSBub3QgYWRkIGl0IHRvIHRoZSBpZiBjaGVj ayBhYm92ZT8KCkNocmlzdGlhbi4KCj4gKwkJCQlyID0gYWRldi0+aXBfYmxvY2tzW2ldLnZlcnNp b24tPmZ1bmNzLT5zZXRfY2xvY2tnYXRpbmdfc3RhdGUoKHZvaWQgKilhZGV2LAo+ICAgCQkJCQkJ CQkJCSAgICAgQU1EX0NHX1NUQVRFX0dBVEUpOwo+IC0JCQlpZiAocikgewo+IC0JCQkJRFJNX0VS Uk9SKCJzZXRfY2xvY2tnYXRpbmdfc3RhdGUoZ2F0ZSkgb2YgSVAgYmxvY2sgPCVzPiBmYWlsZWQg JWRcbiIsCj4gLQkJCQkJICBhZGV2LT5pcF9ibG9ja3NbaV0udmVyc2lvbi0+ZnVuY3MtPm5hbWUs IHIpOwo+IC0JCQkJcmV0dXJuIHI7Cj4gKwkJCQlpZiAocikgewo+ICsJCQkJCURSTV9FUlJPUigi c2V0X2Nsb2NrZ2F0aW5nX3N0YXRlKGdhdGUpIG9mIElQIGJsb2NrIDwlcz4gZmFpbGVkICVkXG4i LAo+ICsJCQkJCQlhZGV2LT5pcF9ibG9ja3NbaV0udmVyc2lvbi0+ZnVuY3MtPm5hbWUsIHIpOwo+ ICsJCQkJCXJldHVybiByOwo+ICsJCQkJfQo+ICAgCQkJfQo+ICAgCQl9Cj4gICAJfQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==