From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 012A6F9EDD9 for ; Wed, 22 Apr 2026 14:04:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AE5710EA0F; Wed, 22 Apr 2026 14:04:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="j+26Fqpn"; dkim-atps=neutral Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FC4510EA0C for ; Wed, 22 Apr 2026 14:04:03 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so46892555e9.0 for ; Wed, 22 Apr 2026 07:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776866642; x=1777471442; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MB2D5LFDJfWK+z/VNsomGx4bgTK6cIcOio7NwwAtJ5A=; b=j+26FqpneNkIwCXzzfW9Ud0aX7chLZWKhumktQnAriv/CEd2712xBLou6R1GfgPC7g bQ+mk89c73SC2gc1/m7rV05hkEHkfpscV5893aPl4IKm7oduXRiNl30dVZl0Su7cpKAR 1psaq0y4+HyyNHjYS75JZ0bPAG2BeVPamvzxIa5eXUB3gTSOaFurKsDBKMpip2BIXhB/ 5OS7zsx0s6QUt8nInu6e6CtGxnNcWRS2Li1HJe0fsPQVP4VOWCR/43rxWGo0qO0iUgMf Dbbc3MJkzWROpI9X0esW9HsdNi63jv+h+QNhG/R5CD01+XLq56a7c9xZkS3x/W38ghkc sGuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776866642; x=1777471442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MB2D5LFDJfWK+z/VNsomGx4bgTK6cIcOio7NwwAtJ5A=; b=mpGjQyZQSrQkgZUAnMpHKGBaT/OokYYmzZNt3uWGyBLxaflnZmI/xc8fmhqBPcbW16 NElhj8NiQZH2chz+qDEm4IiiweXBF9ReEdQDuRxctbxaNb32zKc5v4YhpWvWjgLF/I6v bgPg2omQndu1dkmU08DIog0Nl4wfc4yJkHm8zt2J/RgIAy94PHX0CtlJ5Ln0N8U4lxKA EDJUxpNqaUBC1+4LqSKDPcKiicwnSdYmg7XE0HujYDupF/RDdCTugeyvGFPy+5Wcy/Op gMoua6ZrfnW7eWrcMEak64ilPTAATEZ9QtRgdy6dthOhxgt5EGetyECn6xHPwqXvF84Y YOxQ== X-Forwarded-Encrypted: i=1; AFNElJ8bJBveMiuV2Vk+yXq+Gcx554ulC+/FY1K2TvOPbSPuj7XyaP1/6Hhe4/eBF7lnIdL0n+mW3ptW@lists.freedesktop.org X-Gm-Message-State: AOJu0YyIKkZ3w41Y3YBcau+IpVJeYvNuCNcZQdv6dBcV7zvjRZizEHEr 2UzJ+p1wUMo/xNITV5oWAnIftsCuRtVd1NSwGzF3l9/Cb3uvskus+Elt X-Gm-Gg: AeBDiesOXjlKyyoehi2PMC8uG7+bhdWs1Hk5oYXovX/cZGhkx6HJiUnHErwL6N/K9Q4 au9rUFt9OhFiY5YGEr2P4wiVl6J/I6JGfx1pnaVYwniT8MbA1FEA7UfXomlGJZpZ79M4PQwYx9M oyEJPRAS7Vy5VPk/3RWxKwY1Dunbjp5Q3SJP7mwLOQT2vMxkJlO3QfFmcwj4jW+M3vLiropxUbi poYb8B01h7hb5BTCXVf0KRiwGRv0CHxUy8jOIXjBzhCw/yP04PWvZWffVT42sFZqm+P67ZQ0yt3 aqcrxfxa8b4wHeVw3ryzUJDYADOscLQDCSbFSgvFlbsx5XgSxED9tDg3/TjRX0366ejJcdBdoKs FexZSrGLL1vnPfLlbG1hgTe4xcfIOPpP5kTtR0dBCqZn8mkuZtM8+p1qMVg+OvN/Eu1qcbMku/x VKkLtS8vq3CDrYG5/PNX7jNoF0tYkKzTnfZ++rlL8NmSel3DBrPpiCJCYqsr0WGa/kFQkkgxO43 VnLkNS+sQg= X-Received: by 2002:a05:600c:4f92:b0:48a:f18:ece4 with SMTP id 5b1f17b1804b1-48a0f18edf7mr147574885e9.24.1776866641781; Wed, 22 Apr 2026 07:04:01 -0700 (PDT) Received: from timur-hyperion.localnet (5E1B98A2.dsl.pool.telekom.hu. [94.27.152.162]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-489393ddd69sm64867095e9.10.2026.04.22.07.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 07:04:00 -0700 (PDT) From: Timur =?UTF-8?B?S3Jpc3TDs2Y=?= To: stable@vger.kernel.org, Christian =?UTF-8?B?S8O2bmln?= , Robert Garcia Cc: Alex Deucher , Pan Xinhui , Robert Garcia , David Airlie , Daniel Vetter , Greg Kroah-Hartman , Yifan Zha , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6.1.y] drm/amdgpu: remove two invalid BUG_ON()s Date: Wed, 22 Apr 2026 16:03:59 +0200 Message-ID: <7260936.9J7NaK4W3v@timur-hyperion> In-Reply-To: <20260417074010.1607496-1-rob_garcia@163.com> References: <20260417074010.1607496-1-rob_garcia@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi, In my opinion, this BUG_ON should NOT be removed. Using the CE was never well-supported by amdgpu and can lead to serious=20 issues, so we are planning to remove it entirely. Userspace isn't using it,= so=20 there is no loss of functionality here. Mesa (the official userspace drivers) have never used CE and never will. Best regards, Timur On Friday, April 17, 2026 9:40:10=E2=80=AFAM Central European Summer Time R= obert=20 Garcia wrote: > From: Christian K=C3=B6nig >=20 > [ Upstream commit 5d55ed19d4190d2c210ac05ac7a53f800a8c6fe5 ] >=20 > Those can be triggered trivially by userspace. >=20 > Signed-off-by: Christian K=C3=B6nig > Reviewed-by: Alex Deucher > Acked-by: Timur Krist=C3=B3f > Signed-off-by: Alex Deucher > [ Modified to gfx_v11_0.c only. ] > Signed-off-by: Robert Garcia > --- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c index 37f793f7d4d2..6e3a32779168 > 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c > @@ -5380,8 +5380,6 @@ static void gfx_v11_0_ring_emit_ib_gfx(struct > amdgpu_ring *ring, unsigned vmid =3D AMDGPU_JOB_GET_VMID(job); > u32 header, control =3D 0; >=20 > - BUG_ON(ib->flags & AMDGPU_IB_FLAG_CE); > - > header =3D PACKET3(PACKET3_INDIRECT_BUFFER, 2); >=20 > control |=3D ib->length_dw | (vmid << 24);