Re: [PATCH v3 7/8] drm/amdgpu: Disable DPC for XGMI for now.

[Luben Tuikov <luben.tuikov@amd.com>]

On 2020-08-31 11:50 a.m., Andrey Grodzovsky wrote:
> XGMI support is more complicated then single device support as

Typo: "then" --> "than".

> questions of synchronization between the device recovering from
> PCI error and other members of the hive is required.

Typo: "is" --> "are", as the subject of this long sentence changes
from "XGMI support" to "questions", which is plural: "questions ... _are_ required."

Regards,
Luben

> Leaving this for next round.
> 
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index b31868a..fe720c2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -4781,6 +4781,11 @@ pci_ers_result_t amdgpu_pci_error_detected(struct pci_dev *pdev, pci_channel_sta
>  
>  	DRM_INFO("PCI error: detected callback, state(%d)!!\n", state);
>  
> +	if (adev->gmc.xgmi.num_physical_nodes > 1) {
> +		DRM_WARN("No support for XGMI hive yet...");
> +		return PCI_ERS_RESULT_DISCONNECT;
> +	}
> +
>  	switch (state) {
>  	case pci_channel_io_normal:
>  		return PCI_ERS_RESULT_CAN_RECOVER;
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx