Re: [PATCH v2 05/13] drm/colorop: Add destroy helper for colorop objects

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 1/12/2026 4:53 PM, Jani Nikula wrote:
> On Fri, 09 Jan 2026, Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> wrote:
>> Add a helper that performs common cleanup and frees the
>> associated object. This can be used by drivers if they do not
>> require any driver-specific teardown.
>>
>> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
>> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>> Reviewed-by: Alex Hung <alex.hung@amd.com>
>> ---
>>   drivers/gpu/drm/drm_colorop.c | 12 ++++++++++++
>>   include/drm/drm_colorop.h     | 10 ++++++++++
>>   2 files changed, 22 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
>> index 44eb823585d2..ba19a3ab23cb 100644
>> --- a/drivers/gpu/drm/drm_colorop.c
>> +++ b/drivers/gpu/drm/drm_colorop.c
>> @@ -178,6 +178,18 @@ void drm_colorop_cleanup(struct drm_colorop *colorop)
>>   }
>>   EXPORT_SYMBOL(drm_colorop_cleanup);
>>   
>> +/**
>> + * drm_colorop_destroy() - Helper for colorop destruction
>> + *
>> + * @colorop: colorop to destroy
>> + */
>> +void drm_colorop_destroy(struct drm_colorop *colorop)
>> +{
>> +	drm_colorop_cleanup(colorop);
>> +	kfree(colorop);
>> +}
>> +EXPORT_SYMBOL(drm_colorop_destroy);
>> +
>>   /**
>>    * drm_colorop_pipeline_destroy - Helper for color pipeline destruction
>>    *
>> diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h
>> index a3a32f9f918c..0f5ba72c1704 100644
>> --- a/include/drm/drm_colorop.h
>> +++ b/include/drm/drm_colorop.h
>> @@ -420,6 +420,16 @@ void drm_colorop_atomic_destroy_state(struct drm_colorop *colorop,
>>    */
>>   void drm_colorop_reset(struct drm_colorop *colorop);
>>   
>> +/**
>> + * drm_colorop_destroy - destroy colorop
>> + * @colorop: drm colorop
>> + *
>> + * Destroys @colorop by performing common DRM cleanup and freeing the
>> + * colorop object. This can be used by drivers if they do not
>> + * require any driver-specific teardown.
>> + */
> 
> The kernel-doc should be with the function definition, not at the
> declaration, and certainly not both.
> 

Thank you, Jani, for pointing it out. I have removed it in v3.

Regards
Chaitanya

> BR,
> Jani.
> 
>> +void drm_colorop_destroy(struct drm_colorop *colorop);
>> +
>>   /**
>>    * drm_colorop_index - find the index of a registered colorop
>>    * @colorop: colorop to find index for
>