From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/7] drm/amdgpu: fix VM PD addr shift Date: Tue, 28 Nov 2017 11:04:16 +0100 Message-ID: <77f0e398-daab-6381-cbf6-7207c2ad6c60@gmail.com> References: <20171127160217.4010-1-christian.koenig@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Chunming Zhou , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMjguMTEuMjAxNyB1bSAwMzo0MiBzY2hyaWViIENodW5taW5nIFpob3U6Cj4KPgo+IE9uIDIw MTflubQxMeaciDI45pelIDAwOjAyLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+PiBUaGUgYmxv Y2sgc2l6ZSBvbmx5IGFmZmVjdHMgdGhlIGxlYXZlIG5vZGVzLCBldmVyeXRoaW5nIGVsc2UgaXMg Zml4ZWQuCj4gVGhpcyBpcyBub3QgdHJ1ZSwgYmxvY2sgc2l6ZSBhZmZlY3RzIGV2ZXJ5IGxldmVs IGVudHJpZXMsIHNlZSB0aGUgCj4gcmVnaXN0ZXIgZXhwbGFpbnMgZm9yIFZNX0NPTlRFWFR4X0NO VEwuUEFHRV9UQUJMRV9CTE9DS19TSVpFOgo+ICJMT0cyKG51bWJlciBvZiAyTUIgbG9naWNhbCBh ZGRyZXNzIHJhbmdlcykgcG9pbnRlZCB0byBieSBhIFBERTAgcGFnZSAKPiB0ZXh0IGRpcmVjdG9y eSBlbnRyeS4gVGhlIG5hdGl2ZSBwYWdlIHNpemUgZm9yIHRoZSBjb21wb25lbnQgcHRlcyAKPiBj b21lcyBmcm9tIHRoZSBQREUwLmJsb2NrX2ZyYWdtZW50X3NpemUgZmllbGQgb3IgCj4gQkFTRV9B RERSLmJsb2NrX2ZyYWdtZW50X3NpemUgZmllbGQgKGZvciBhIGZsYXQgcGFnZSB0YWJsZSkuIFRo ZSAKPiBQQUdFX1RBQkxFX0JMT0NLX1NJWkUgZmllbGQgb25seSBoYXMgYW4gZWZmZWN0IG9uIGFk ZHJlc3MgY2FsY3VsYXRpb25zIAo+IGZvciA+PSAyIGxldmVsIHBhZ2UgdGFibGVzIGhvd2V2ZXIu IEEgZmxhdCBwYWdlIHRhYmxlIHdpbGwgdXRpbGl6ZSBhcyAKPiBtYW55IHB0ZXMgYXMgYXJlIHJl cXVpcmVkIHRvIHJlcHJlc2VudCB0aGUgbG9naWNhbCBhZGRyZXNzIGJldHdlZW4gCj4gU1RBUlRf QUREUiBhbmQgRU5EX0FERFIsIG5vdCBsaW1pdGVkIGJ5IFBBR0VfVEFCTEVfQkxPQ0tfU0laRS4i CgpUaGUgZGVzY3JpcHRpb24gb2YgdGhlIHJlZ2lzdGVyIGlzIGluY29ycmVjdCBvciBhdCBsZWFz dCBtaXNsZWFkaW5nLiAKSSd2ZSBmYWxsZW4gaW50byB0aGUgc2FtZSB0cmFwIGFzIHdlbGwuCgpU YWtlIGEgbG9vayBhdCB0aGUgVk0gZG9jdW1lbnRhdGlvbiwgdGhlcmUgaXMgYSBzbWFsbCBmb290 bm90ZSB0aGF0IAppbnRlcm1lZGlhdGUgcGFnZSBkaXJlY3RvcmllcyBhcmUgYWx3YXlzIDUxMiBl bnRyaWVzIGluIHNpemUuCgpJJ3ZlIGNvbmZpcm1lZCB0aGF0IGJ5IGNvbmZpZ3VyaW5nIGEgVmVn YTEwIGludG8gMyBsZXZlbCBwYWdlIGRpcmVjdG9yeSAKaW5zdGVhZCBvZiB0aGUgdXN1YWwgNCBh bmQgdGhlbiB1c2luZyBhIGJsb2NrIHNpemUgb2YgMTggZm9yIHRoZSBwYWdlIAp0YWJsZXMuCgpS ZWdhcmRzLApDaHJpc3RpYW4uCgo+Cj4gUmVnYXJkcywKPiBEYXZpZCBaaG91Cj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPj4g LS0tCj4+IMKgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jIHwgMjggCj4+ ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDIzIGlu c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyAKPj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdm0uYwo+PiBpbmRleCAxMjIzNzlkZmM3ZDguLmYxZTU0MWU5YjUxNCAxMDA2 NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPj4gQEAgLTEzOSw2ICsx MzksMjQgQEAgc3RydWN0IGFtZGdwdV9wcnRfY2Igewo+PiDCoCB9Owo+PiDCoCDCoCAvKioKPj4g KyAqIGFtZGdwdV92bV9sZXZlbF9zaGlmdCAtIHJldHVybiB0aGUgYWRkciBzaGlmdCBmb3IgZWFj aCBsZXZlbAo+PiArICoKPj4gKyAqIEBhZGV2OiBhbWRncHVfZGV2aWNlIHBvaW50ZXIKPj4gKyAq Cj4+ICsgKiBSZXR1cm5zIHRoZSBudW1iZXIgb2YgYml0cyB0aGUgcGZuIG5lZWRzIHRvIGJlIHJp Z2h0IHNoaWZ0ZWQgZm9yIAo+PiBhIGxldmVsLgo+PiArICovCj4+ICtzdGF0aWMgdW5zaWduZWQg YW1kZ3B1X3ZtX2xldmVsX3NoaWZ0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+PiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxldmVsKQo+ PiArewo+PiArwqDCoMKgIGlmIChsZXZlbCAhPSBhZGV2LT52bV9tYW5hZ2VyLm51bV9sZXZlbCkK Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiA5ICogKGFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVs IC0gbGV2ZWwgLSAxKSArCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFkZXYtPnZtX21hbmFn ZXIuYmxvY2tfc2l6ZTsKPj4gK8KgwqDCoCBlbHNlCj4+ICvCoMKgwqDCoMKgwqDCoCAvKiBGb3Ig dGhlIHBhZ2UgdGFibGVzIG9uIHRoZSBsZWF2ZXMgKi8KPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVy biAwOwo+PiArfQo+PiArCj4+ICsvKioKPj4gwqDCoCAqIGFtZGdwdV92bV9udW1fZW50cmllcyAt IHJldHVybiB0aGUgbnVtYmVyIG9mIGVudHJpZXMgaW4gYSBQRC9QVAo+PiDCoMKgICoKPj4gwqDC oCAqIEBhZGV2OiBhbWRncHVfZGV2aWNlIHBvaW50ZXIKPj4gQEAgLTI4OCw4ICszMDYsNyBAQCBz dGF0aWMgaW50IGFtZGdwdV92bV9hbGxvY19sZXZlbHMoc3RydWN0IAo+PiBhbWRncHVfZGV2aWNl ICphZGV2LAo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50NjRf dCBzYWRkciwgdWludDY0X3QgZWFkZHIsCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHVuc2lnbmVkIGxldmVsKQo+PiDCoCB7Cj4+IC3CoMKgwqAgdW5zaWduZWQgc2hp ZnQgPSAoYWRldi0+dm1fbWFuYWdlci5udW1fbGV2ZWwgLSBsZXZlbCkgKgo+PiAtwqDCoMKgwqDC oMKgwqAgYWRldi0+dm1fbWFuYWdlci5ibG9ja19zaXplOwo+PiArwqDCoMKgIHVuc2lnbmVkIHNo aWZ0ID0gYW1kZ3B1X3ZtX2xldmVsX3NoaWZ0KGFkZXYsIGxldmVsKTsKPj4gwqDCoMKgwqDCoCB1 bnNpZ25lZCBwdF9pZHgsIGZyb20sIHRvOwo+PiDCoMKgwqDCoMKgIGludCByOwo+PiDCoMKgwqDC oMKgIHU2NCBmbGFnczsKPj4gQEAgLTEzMDIsMTggKzEzMTksMTkgQEAgdm9pZCBhbWRncHVfdm1f Z2V0X2VudHJ5KHN0cnVjdCAKPj4gYW1kZ3B1X3B0ZV91cGRhdGVfcGFyYW1zICpwLCB1aW50NjRf dCBhZGRyLAo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBhbWRncHVfdm1f cHQgKiplbnRyeSwKPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgYW1kZ3B1 X3ZtX3B0ICoqcGFyZW50KQo+PiDCoCB7Cj4+IC3CoMKgwqAgdW5zaWduZWQgaWR4LCBsZXZlbCA9 IHAtPmFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsOwo+PiArwqDCoMKgIHVuc2lnbmVkIGxldmVs ID0gMDsKPj4gwqAgwqDCoMKgwqDCoCAqcGFyZW50ID0gTlVMTDsKPj4gwqDCoMKgwqDCoCAqZW50 cnkgPSAmcC0+dm0tPnJvb3Q7Cj4+IMKgwqDCoMKgwqAgd2hpbGUgKCgqZW50cnkpLT5lbnRyaWVz KSB7Cj4+IC3CoMKgwqDCoMKgwqDCoCBpZHggPSBhZGRyID4+IChwLT5hZGV2LT52bV9tYW5hZ2Vy LmJsb2NrX3NpemUgKiBsZXZlbC0tKTsKPj4gK8KgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGlkeCA9 IGFkZHIgPj4gYW1kZ3B1X3ZtX2xldmVsX3NoaWZ0KHAtPmFkZXYsIGxldmVsKyspOwo+PiArCj4+ IMKgwqDCoMKgwqDCoMKgwqDCoCBpZHggJT0gYW1kZ3B1X2JvX3NpemUoKCplbnRyeSktPmJhc2Uu Ym8pIC8gODsKPj4gwqDCoMKgwqDCoMKgwqDCoMKgICpwYXJlbnQgPSAqZW50cnk7Cj4+IMKgwqDC oMKgwqDCoMKgwqDCoCAqZW50cnkgPSAmKCplbnRyeSktPmVudHJpZXNbaWR4XTsKPj4gwqDCoMKg wqDCoCB9Cj4+IMKgIC3CoMKgwqAgaWYgKGxldmVsKQo+PiArwqDCoMKgIGlmIChsZXZlbCAhPSBw LT5hZGV2LT52bV9tYW5hZ2VyLm51bV9sZXZlbCkKPj4gwqDCoMKgwqDCoMKgwqDCoMKgICplbnRy eSA9IE5VTEw7Cj4+IMKgIH0KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQt Z2Z4Cg==