From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH v2 hmm 02/11] mm/hmm: Use hmm_mirror not mm as an argument for hmm_range_register Date: Thu, 6 Jun 2019 19:36:15 -0700 Message-ID: <7902a4fa-f789-de3f-e448-a8cfc412f40b@nvidia.com> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-3-jgg@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190606184438.31646-3-jgg-uk2M96/98Pc@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Jason Gunthorpe , Jerome Glisse , Ralph Campbell , Felix.Kuehling-5C7GfCeVMHo@public.gmane.org Cc: Andrea Arcangeli , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Jason Gunthorpe , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gNi82LzE5IDExOjQ0IEFNLCBKYXNvbiBHdW50aG9ycGUgd3JvdGU6Cj4gRnJvbTogSmFzb24g R3VudGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+IAo+IFJhbHBoIG9ic2VydmVzIHRoYXQgaG1t X3JhbmdlX3JlZ2lzdGVyKCkgY2FuIG9ubHkgYmUgY2FsbGVkIGJ5IGEgZHJpdmVyCj4gd2hpbGUg YSBtaXJyb3IgaXMgcmVnaXN0ZXJlZC4gTWFrZSB0aGlzIGNsZWFyIGluIHRoZSBBUEkgYnkgcGFz c2luZyBpbiB0aGUKPiBtaXJyb3Igc3RydWN0dXJlIGFzIGEgcGFyYW1ldGVyLgo+IAo+IFRoaXMg YWxzbyBzaW1wbGlmaWVzIHVuZGVyc3RhbmRpbmcgdGhlIGxpZmV0aW1lIG1vZGVsIGZvciBzdHJ1 Y3QgaG1tLCBhcwo+IHRoZSBobW0gcG9pbnRlciBtdXN0IGJlIHZhbGlkIGFzIHBhcnQgb2YgYSBy ZWdpc3RlcmVkIG1pcnJvciBzbyBhbGwgd2UKPiBuZWVkIGluIGhtbV9yZWdpc3Rlcl9yYW5nZSgp IGlzIGEgc2ltcGxlIGtyZWZfZ2V0Lgo+IAo+IFN1Z2dlc3RlZC1ieTogUmFscGggQ2FtcGJlbGwg PHJjYW1wYmVsbEBudmlkaWEuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEphc29uIEd1bnRob3JwZSA8 amdnQG1lbGxhbm94LmNvbT4KPiAtLS0KPiB2Mgo+IC0gSW5jbHVkZSB0aGUgb25lbGluZSBwYXRj aCB0byBub3V2ZWF1X3N2bS5jCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZl YXVfc3ZtLmMgfCAgMiArLQo+ICBpbmNsdWRlL2xpbnV4L2htbS5oICAgICAgICAgICAgICAgICAg IHwgIDcgKysrKy0tLQo+ICBtbS9obW0uYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg MTUgKysrKysrLS0tLS0tLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwg MTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1 L25vdXZlYXVfc3ZtLmMgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X3N2bS5jCj4g aW5kZXggOTNlZDQzYzQxM2YwYmIuLjhjOTIzNzRhZmNmMjI3IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfc3ZtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v bm91dmVhdS9ub3V2ZWF1X3N2bS5jCj4gQEAgLTY0OSw3ICs2NDksNyBAQCBub3V2ZWF1X3N2bV9m YXVsdChzdHJ1Y3QgbnZpZl9ub3RpZnkgKm5vdGlmeSkKPiAgCQlyYW5nZS52YWx1ZXMgPSBub3V2 ZWF1X3N2bV9wZm5fdmFsdWVzOwo+ICAJCXJhbmdlLnBmbl9zaGlmdCA9IE5WSUZfVk1NX1BGTk1B UF9WMF9BRERSX1NISUZUOwo+ICBhZ2FpbjoKPiAtCQlyZXQgPSBobW1fdm1hX2ZhdWx0KCZyYW5n ZSwgdHJ1ZSk7Cj4gKwkJcmV0ID0gaG1tX3ZtYV9mYXVsdCgmc3ZtbS0+bWlycm9yLCAmcmFuZ2Us IHRydWUpOwo+ICAJCWlmIChyZXQgPT0gMCkgewo+ICAJCQltdXRleF9sb2NrKCZzdm1tLT5tdXRl eCk7Cj4gIAkJCWlmICghaG1tX3ZtYV9yYW5nZV9kb25lKCZyYW5nZSkpIHsKPiBkaWZmIC0tZ2l0 IGEvaW5jbHVkZS9saW51eC9obW0uaCBiL2luY2x1ZGUvbGludXgvaG1tLmgKPiBpbmRleCA2ODhj NWNhNzA2ODc5NS4uMmQ1MTk3OTdjYjEzNGEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9o bW0uaAo+ICsrKyBiL2luY2x1ZGUvbGludXgvaG1tLmgKPiBAQCAtNTA1LDcgKzUwNSw3IEBAIHN0 YXRpYyBpbmxpbmUgYm9vbCBobW1fbWlycm9yX21tX2lzX2FsaXZlKHN0cnVjdCBobW1fbWlycm9y ICptaXJyb3IpCj4gICAqIFBsZWFzZSBzZWUgRG9jdW1lbnRhdGlvbi92bS9obW0ucnN0IGZvciBo b3cgdG8gdXNlIHRoZSByYW5nZSBBUEkuCj4gICAqLwo+ICBpbnQgaG1tX3JhbmdlX3JlZ2lzdGVy KHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlLAo+IC0JCSAgICAgICBzdHJ1Y3QgbW1fc3RydWN0ICpt bSwKPiArCQkgICAgICAgc3RydWN0IGhtbV9taXJyb3IgKm1pcnJvciwKPiAgCQkgICAgICAgdW5z aWduZWQgbG9uZyBzdGFydCwKPiAgCQkgICAgICAgdW5zaWduZWQgbG9uZyBlbmQsCj4gIAkJICAg ICAgIHVuc2lnbmVkIHBhZ2Vfc2hpZnQpOwo+IEBAIC01NDEsNyArNTQxLDggQEAgc3RhdGljIGlu bGluZSBib29sIGhtbV92bWFfcmFuZ2VfZG9uZShzdHJ1Y3QgaG1tX3JhbmdlICpyYW5nZSkKPiAg fQo+ICAKPiAgLyogVGhpcyBpcyBhIHRlbXBvcmFyeSBoZWxwZXIgdG8gYXZvaWQgbWVyZ2UgY29u ZmxpY3QgYmV0d2VlbiB0cmVlcy4gKi8KPiAtc3RhdGljIGlubGluZSBpbnQgaG1tX3ZtYV9mYXVs dChzdHJ1Y3QgaG1tX3JhbmdlICpyYW5nZSwgYm9vbCBibG9jaykKPiArc3RhdGljIGlubGluZSBp bnQgaG1tX3ZtYV9mYXVsdChzdHJ1Y3QgaG1tX21pcnJvciAqbWlycm9yLAo+ICsJCQkJc3RydWN0 IGhtbV9yYW5nZSAqcmFuZ2UsIGJvb2wgYmxvY2spCj4gIHsKPiAgCWxvbmcgcmV0Owo+ICAKPiBA QCAtNTU0LDcgKzU1NSw3IEBAIHN0YXRpYyBpbmxpbmUgaW50IGhtbV92bWFfZmF1bHQoc3RydWN0 IGhtbV9yYW5nZSAqcmFuZ2UsIGJvb2wgYmxvY2spCj4gIAlyYW5nZS0+ZGVmYXVsdF9mbGFncyA9 IDA7Cj4gIAlyYW5nZS0+cGZuX2ZsYWdzX21hc2sgPSAtMVVMOwo+ICAKPiAtCXJldCA9IGhtbV9y YW5nZV9yZWdpc3RlcihyYW5nZSwgcmFuZ2UtPnZtYS0+dm1fbW0sCj4gKwlyZXQgPSBobW1fcmFu Z2VfcmVnaXN0ZXIocmFuZ2UsIG1pcnJvciwKPiAgCQkJCSByYW5nZS0+c3RhcnQsIHJhbmdlLT5l bmQsCj4gIAkJCQkgUEFHRV9TSElGVCk7Cj4gIAlpZiAocmV0KQo+IGRpZmYgLS1naXQgYS9tbS9o bW0uYyBiL21tL2htbS5jCj4gaW5kZXggNTQ3MDAyZjU2YTE2M2QuLjg3OTY0NDcyOTkwMjNjIDEw MDY0NAo+IC0tLSBhL21tL2htbS5jCj4gKysrIGIvbW0vaG1tLmMKPiBAQCAtOTI1LDEzICs5MjUs MTMgQEAgc3RhdGljIHZvaWQgaG1tX3BmbnNfY2xlYXIoc3RydWN0IGhtbV9yYW5nZSAqcmFuZ2Us Cj4gICAqIFRyYWNrIHVwZGF0ZXMgdG8gdGhlIENQVSBwYWdlIHRhYmxlIHNlZSBpbmNsdWRlL2xp bnV4L2htbS5oCj4gICAqLwo+ICBpbnQgaG1tX3JhbmdlX3JlZ2lzdGVyKHN0cnVjdCBobW1fcmFu Z2UgKnJhbmdlLAo+IC0JCSAgICAgICBzdHJ1Y3QgbW1fc3RydWN0ICptbSwKPiArCQkgICAgICAg c3RydWN0IGhtbV9taXJyb3IgKm1pcnJvciwKPiAgCQkgICAgICAgdW5zaWduZWQgbG9uZyBzdGFy dCwKPiAgCQkgICAgICAgdW5zaWduZWQgbG9uZyBlbmQsCj4gIAkJICAgICAgIHVuc2lnbmVkIHBh Z2Vfc2hpZnQpCj4gIHsKPiAgCXVuc2lnbmVkIGxvbmcgbWFzayA9ICgoMVVMIDw8IHBhZ2Vfc2hp ZnQpIC0gMVVMKTsKPiAtCXN0cnVjdCBobW0gKmhtbTsKPiArCXN0cnVjdCBobW0gKmhtbSA9IG1p cnJvci0+aG1tOwo+ICAKPiAgCXJhbmdlLT52YWxpZCA9IGZhbHNlOwo+ICAJcmFuZ2UtPmhtbSA9 IE5VTEw7Cj4gQEAgLTk0NSwxNSArOTQ1LDEyIEBAIGludCBobW1fcmFuZ2VfcmVnaXN0ZXIoc3Ry dWN0IGhtbV9yYW5nZSAqcmFuZ2UsCj4gIAlyYW5nZS0+c3RhcnQgPSBzdGFydDsKPiAgCXJhbmdl LT5lbmQgPSBlbmQ7Cj4gIAo+IC0JaG1tID0gaG1tX2dldF9vcl9jcmVhdGUobW0pOwo+IC0JaWYg KCFobW0pCj4gLQkJcmV0dXJuIC1FRkFVTFQ7Cj4gLQo+ICAJLyogQ2hlY2sgaWYgaG1tX21tX2Rl c3Ryb3koKSB3YXMgY2FsbC4gKi8KPiAtCWlmIChobW0tPm1tID09IE5VTEwgfHwgaG1tLT5kZWFk KSB7Cj4gLQkJaG1tX3B1dChobW0pOwo+ICsJaWYgKGhtbS0+bW0gPT0gTlVMTCB8fCBobW0tPmRl YWQpCj4gIAkJcmV0dXJuIC1FRkFVTFQ7Cj4gLQl9Cj4gKwo+ICsJcmFuZ2UtPmhtbSA9IGhtbTsK PiArCWtyZWZfZ2V0KCZobW0tPmtyZWYpOwo+ICAKPiAgCS8qIEluaXRpYWxpemUgcmFuZ2UgdG8g dHJhY2sgQ1BVIHBhZ2UgdGFibGUgdXBkYXRlcy4gKi8KPiAgCW11dGV4X2xvY2soJmhtbS0+bG9j ayk7Cj4gCgpJJ20gbm90IGEgcXVhbGlmaWVkIE5vdXZlYXUgcmV2aWV3ZXIsIGJ1dCB0aGlzIGxv b2tzIG9idmlvdXNseSBjb3JyZWN0LApzbzoKCiAgICBSZXZpZXdlZC1ieTogSm9obiBIdWJiYXJk IDxqaHViYmFyZEBudmlkaWEuY29tPgoKCnRoYW5rcywKLS0gCkpvaG4gSHViYmFyZApOVklESUEK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4