From: "André Almeida" <andrealmeid@igalia.com>
To: Roy Sun <Roy.Sun@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the incomplete product number
Date: Mon, 25 Jul 2022 16:38:00 -0300 [thread overview]
Message-ID: <7c866655-7736-6911-eec4-9beb46435207@igalia.com> (raw)
In-Reply-To: <20220722045646.106225-1-Roy.Sun@amd.com>
Às 01:56 de 22/07/22, Roy Sun escreveu:
> The comments say that the product number is a 16-digit HEX string so the
> buffer needs to be at least 17 characters to hold the NUL terminator. Expand
> the buffer size to 20 to avoid the alignment issues.
>
> The comment:Product number should only be 16 characters. Any
> more,and something could be wrong. Cap it at 16 to be safe
>
> Signed-off-by: Roy Sun <Roy.Sun@amd.com>
> ---
Reviewed-by: André Almeida <andrealmeid@igalia.com>
Next time, please make your subject as [PATCH v2] and add a changelog to
make review easier.
next prev parent reply other threads:[~2022-07-25 19:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 4:56 [PATCH] drm/amdgpu: Fix the incomplete product number Roy Sun
2022-07-25 7:29 ` Sun, Roy
2022-07-25 13:35 ` Alex Deucher
2022-07-25 19:38 ` André Almeida [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-20 8:26 Roy Sun
2022-07-20 8:28 ` Sun, Roy
2022-07-20 12:48 ` Christian König
2022-07-20 14:26 ` André Almeida
2022-07-20 14:30 ` Christian König
2022-07-20 17:23 ` André Almeida
2022-07-18 12:08 yehonsun
2022-07-18 12:35 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c866655-7736-6911-eec4-9beb46435207@igalia.com \
--to=andrealmeid@igalia.com \
--cc=Roy.Sun@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox