Re: [PATCH] drm/amd/amdgpu: change the flush gpu tlb mode to sync mode.

["Christian König" <christian.koenig@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

Am 21.10.24 um 07:56 schrieb Chong Li:
> change the gpu tlb flush mode to sync mode to
> solve the issue in the rocm stress test.

And again complete NAK to this.

I've already proven together with Andjelkovic that the problem is that 
the rocm stress test is broken.

The test tries to access memory before it is probably mapped and that is 
provable by looking into the tracelogs.

Regards,
Christian.

>
> Signed-off-by: Chong Li<chongli2@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
> index 51cddfa3f1e8..4d9ff7b31618 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
> @@ -98,7 +98,6 @@ void amdgpu_vm_tlb_fence_create(struct amdgpu_device *adev, struct amdgpu_vm *vm
>   	f->adev = adev;
>   	f->dependency = *fence;
>   	f->pasid = vm->pasid;
> -	INIT_WORK(&f->work, amdgpu_tlb_fence_work);
>   	spin_lock_init(&f->lock);
>   
>   	dma_fence_init(&f->base, &amdgpu_tlb_fence_ops, &f->lock,
> @@ -106,7 +105,8 @@ void amdgpu_vm_tlb_fence_create(struct amdgpu_device *adev, struct amdgpu_vm *vm
>   
>   	/* TODO: We probably need a separate wq here */
>   	dma_fence_get(&f->base);
> -	schedule_work(&f->work);
>   
>   	*fence = &f->base;
> +
> +	amdgpu_tlb_fence_work(&f->work);
>   }

[-- Attachment #2: Type: text/html, Size: 2280 bytes --]