From: Bhawanpreet Lakha <Bhawanpreet.lakha@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>, Harry Wentland <hwentlan@amd.com>
Cc: "Wentland, Harry" <harry.wentland@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/5] HDCP SRM interface
Date: Wed, 22 Jan 2020 11:44:00 -0500 [thread overview]
Message-ID: <7eca48bb-d1e8-a1c4-0812-665438a38ecb@amd.com> (raw)
In-Reply-To: <CADnq5_NO49aT6eSDywE20h6XZSF_D4WvCyQo30cXwRMvU1YmoA@mail.gmail.com>
On 2020-01-22 11:23 a.m., Alex Deucher wrote:
> On Wed, Jan 22, 2020 at 11:12 AM Harry Wentland <hwentlan@amd.com> wrote:
>> On 2020-01-16 3:29 p.m., Bhawanpreet Lakha wrote:
>>> These patches adds support for SRM loading. By providing an interface to the
>>> usermode
>>>
>>> SRM has to be persistent and since the kernel cannot directly write to system
>>> storage we need to provide an interface so that the usermode can do it for us
>>>
>> We'll want to elaborate a bit more on why and how this is done. As
>> mentioned on my patch 2 comments I recommend to do this there as the
>> cover letter is lost after merge.
>>
> You might also want to cc dri-devel if you resend to get more reviews.
> I'm also not crazy about having to update the file in chunks, but I
> don't have any better ideas off hand. Maybe an ioctl would be
> cleaner?
>
> Alex
The kernel can only send PAGE_SIZE (4KB) at once, so if the file is
bigger than PAGE_SIZE (max SRM is 5KB) it will send it again until its
finished (unless we increase the page size).
From the user space its just a single command to read/write
save to storage : cat /sys/class/drm/card0/device/hdcp_srm > file
load from storage : cat file> /sys/class/drm/card0/device/hdcp_srm
I will send it to dri-devel after fixing what Harry suggested.
Thanks
Bhawan
>> Harry
>>
>>> Bhawanpreet Lakha (5):
>>> drm/amd/display: Pass amdgpu_device instead of psp_context
>>> drm/amd/display: update psp interface header
>>> drm/amd/display: Add sysfs interface for set/get srm
>>> drm/amd/display: Load srm before enabling HDCP
>>> drm/amd/display: call psp set/get interfaces
>>>
>>> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>>> .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 182 +++++++++++++++++-
>>> .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.h | 9 +-
>>> .../drm/amd/display/modules/hdcp/hdcp_psp.h | 26 ++-
>>> 4 files changed, 212 insertions(+), 7 deletions(-)
>>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CBhawanpreet.Lakha%40amd.com%7Ce190d770392e468225c308d79f57655d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637153070030895879&sdata=5mlINUlUGz4bkIcK1hUjves9N3BviOdtKuLFPftn1SY%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-01-22 16:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 20:29 [PATCH 0/5] HDCP SRM interface Bhawanpreet Lakha
2020-01-16 20:29 ` [PATCH 1/5] drm/amd/display: Pass amdgpu_device instead of psp_context Bhawanpreet Lakha
2020-01-16 20:29 ` [PATCH 2/5] drm/amd/display: update psp interface header Bhawanpreet Lakha
2020-01-22 16:10 ` Harry Wentland
2020-01-16 20:29 ` [PATCH 3/5] drm/amd/display: Add sysfs interface for set/get srm Bhawanpreet Lakha
2020-01-17 19:23 ` Alex Deucher
2020-01-17 19:29 ` Bhawanpreet Lakha
2020-01-22 19:03 ` Harry Wentland
2020-01-16 20:29 ` [PATCH 4/5] drm/amd/display: Load srm before enabling HDCP Bhawanpreet Lakha
2020-01-16 20:29 ` [PATCH 5/5] drm/amd/display: call psp set/get interfaces Bhawanpreet Lakha
2020-01-22 19:25 ` Harry Wentland
2020-01-22 16:11 ` [PATCH 0/5] HDCP SRM interface Harry Wentland
2020-01-22 16:23 ` Alex Deucher
2020-01-22 16:44 ` Bhawanpreet Lakha [this message]
2020-01-22 19:27 ` Harry Wentland
2020-01-22 19:49 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eca48bb-d1e8-a1c4-0812-665438a38ecb@amd.com \
--to=bhawanpreet.lakha@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hwentlan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).