From: Mario Limonciello <mario.limonciello@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Cc: lkml@antheas.dev, bob.beckett@collabora.com
Subject: Re: [PATCH 2/2] drm/amdgpu/smu: Handle S0ix for vangogh
Date: Fri, 24 Oct 2025 12:12:04 -0500 [thread overview]
Message-ID: <7f08ca96-a028-4249-aaed-c1b58b1daba5@amd.com> (raw)
In-Reply-To: <20251024170811.57760-2-alexander.deucher@amd.com>
On 10/24/2025 12:08 PM, Alex Deucher wrote:
> Fix the flows for S0ix. There is no need to stop
> rlc or reintialize PMFW in S0ix.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4659
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>> ---
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6 ++++++
> drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 3 +++
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> index 10d42267085b0..5bee02f0ba867 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> @@ -2054,6 +2054,12 @@ static int smu_disable_dpms(struct smu_context *smu)
> smu->is_apu && (amdgpu_in_reset(adev) || adev->in_s0ix))
> return 0;
>
> + /* vangogh s0ix */
> + if ((amdgpu_ip_version(adev, MP1_HWIP, 0) == IP_VERSION(11, 5, 0) ||
> + amdgpu_ip_version(adev, MP1_HWIP, 0) == IP_VERSION(11, 5, 2)) &&
> + adev->in_s0ix)
> + return 0;
> +
> /*
> * For gpu reset, runpm and hibernation through BACO,
> * BACO feature has to be kept enabled.
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> index 53579208cffb4..9626da2dba584 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> @@ -2219,6 +2219,9 @@ static int vangogh_post_smu_init(struct smu_context *smu)
> uint32_t total_cu = adev->gfx.config.max_cu_per_sh *
> adev->gfx.config.max_sh_per_se * adev->gfx.config.max_shader_engines;
>
> + if (adev->in_s0ix)
> + return 0;
> +
> /* allow message will be sent after enable message on Vangogh*/
> if (smu_cmn_feature_is_enabled(smu, SMU_FEATURE_DPM_GFXCLK_BIT) &&
> (adev->pg_flags & AMD_PG_SUPPORT_GFX_PG)) {
next prev parent reply other threads:[~2025-10-24 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 17:08 [PATCH 1/2] drm/amdgpu: move PMFW rlc notifier to where it's required Alex Deucher
2025-10-24 17:08 ` [PATCH 2/2] drm/amdgpu/smu: Handle S0ix for vangogh Alex Deucher
2025-10-24 17:12 ` Mario Limonciello [this message]
2025-10-24 17:14 ` Antheas Kapenekakis
2025-10-30 15:37 ` Mario Limonciello
2025-10-30 16:20 ` Antheas Kapenekakis
2025-10-31 11:58 ` Antheas Kapenekakis
2025-10-31 12:58 ` Mario Limonciello
2025-10-24 17:11 ` [PATCH 1/2] drm/amdgpu: move PMFW rlc notifier to where it's required Mario Limonciello
2025-10-26 4:24 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f08ca96-a028-4249-aaed-c1b58b1daba5@amd.com \
--to=mario.limonciello@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bob.beckett@collabora.com \
--cc=lkml@antheas.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox