From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C353FE9A04C for ; Wed, 18 Feb 2026 08:09:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A846110E586; Wed, 18 Feb 2026 08:09:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GLwGwah7"; dkim-atps=neutral Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id 735DF10E515 for ; Tue, 17 Feb 2026 16:41:04 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-65a1faf828bso529765a12.2 for ; Tue, 17 Feb 2026 08:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771346463; x=1771951263; darn=lists.freedesktop.org; h=mime-version:user-agent:content-transfer-encoding :disposition-notification-to:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=r/mWn0NTZppbdGJFnI/ErDwdANkgeIegPSZLoS1BE5U=; b=GLwGwah7+Erw7DnT1m6GR6nWA6GBTdGM9QFQxLSXpZHKqk9JY2tE7+fGjf0b1O0w0Q g08V4MkTajgiIE/LfWSnRx2oxbSygplypC5DmAnbQXJRP7+rkCDABbvgzMWZ6bPbbBc/ FVUYJt/DVisbFlElXtlJA5bHocUZvNEn6wO600Z57se7foFO6OOIIRxCT/L4rEsGbmJe tugU0LHMobOL9fEPSRzzCmYe0obrXW7bMoULRwYEt3SbBZNjDudrSWoHJXkvYPGIXGOP jnFB5djkzw27u+HkAhfAgWRNyvZuZ4GnFj6H9dI66pfF6VBCc3L+m8vnvzJFzl+vHQWX PXLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771346463; x=1771951263; h=mime-version:user-agent:content-transfer-encoding :disposition-notification-to:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=r/mWn0NTZppbdGJFnI/ErDwdANkgeIegPSZLoS1BE5U=; b=fzbeEEQ7V/tNn35F/Wcfw5wm+GY0IjpCVPBOnm5nyQ0rd8r5RWQPosDMPCg+cj8Y6Q 6YwJ31r7FWaT0Rc9fAWD4plaiIQoUCQ13Go961CBoo092TwbOm240DvkCQDmZDhQskzA fUtGrcvhNGoW9xuPh/ce2NyJ7bmbWN7HIiMO0rsiOncNm7kOEt9urty+gJsBdaOMEkmb l7BNC5GpwYcprcl0/7ym5/NayHiXcov6PYwt50Il6pFAxzDzWr6CDap2/WCzHAopGP29 0hKPzrkQU+qOzRKiexXN6pbDbNCZp1oSBE15v26M5vXw9gXPeVFkctpdh5LFd3bm0KNr s8UQ== X-Forwarded-Encrypted: i=1; AJvYcCW1yvpxwuIon25WaUrY+seBJ+SmZUnNWw0FG/1J231fsJWaND5zuVY18RzWj8Xs9U49IYop5pCd@lists.freedesktop.org X-Gm-Message-State: AOJu0YzoQsJE/moFVWa/TXK5a9+SH6vvwxSjsMdSYiiUahDlokvx7r71 905IEYS1IsAYKYhUKfGHtGbQbFtYUOVrJc1l7/npXDnRUgc+SeR8+l5F X-Gm-Gg: AZuq6aL/Z4hRZ1IJOhSrNZDu4nnIhBLZ+/Sr7nqXgN+357OoSiLJ+L7n3k8kD/txGyq X6QaffGQCCzo9+tLJwwiXIHaACxChiIYiHJFEG+W9b9loO48ma+My2vOMHFTH/4Srgtyrdb+335 PKzDeYC5uoZYJiGJfOkmE3qnQ+12bsVcczGaq2sMI0QzU0wUfZDE0f1OjZ9bha/1D1pqJSu64lP n/verBW+RUiJ1F/mDRdBdw6erbTT32eCOcXSr+JHulD6rDr41pk628nertLXsIlMtmW+C7T9ONs uYRhF+4u2Rjby7nOUXRJYICd25UMFMMB4o2L2UbE1RFvqpdLI4r/rxIoxBnT//T36aT2EKwM2Y7 NOwHXhk1o3Lgb/AeStZ+MoOLKQLUvErag2tSGe7grZ7PG3ieuwuFKu+BvkOPkD0iU5bWJpdsi6y qfsZ6uZs+onX6bPCqyKIxfq5csoMoQEH7Z4eq7p9duOKQ0xq6/GfnyROUsHp+Xi3IHMfF1AhH4a Xp9USDJwyo= X-Received: by 2002:a05:6402:5244:b0:65b:a76d:6ff6 with SMTP id 4fb4d7f45d1cf-65bad140f57mr4283834a12.3.1771346462611; Tue, 17 Feb 2026 08:41:02 -0800 (PST) Received: from [192.168.1.239] (87-205-5-123.static.ip.netia.com.pl. [87.205.5.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad3f1294sm2511183a12.26.2026.02.17.08.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 08:41:02 -0800 (PST) Message-ID: <8006baea7c35850de3a39f155b7aa004c4896495.camel@gmail.com> Subject: Re: [PATCH v4 23/27] drm: Add passive_vrr_disabled property to crtc From: Tomasz =?UTF-8?Q?Paku=C5=82a?= To: Michel =?ISO-8859-1?Q?D=E4nzer?= , alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, siqueira@igalia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, bernhard.berger@gmail.com, daniel@fooishbar.org Date: Tue, 17 Feb 2026 17:41:00 +0100 In-Reply-To: References: <20260216164516.36803-1-tomasz.pakula.oficjalny@gmail.com> <20260216164516.36803-24-tomasz.pakula.oficjalny@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 18 Feb 2026 08:09:39 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, 2026-02-17 at 09:21 +0100, Michel D=C3=A4nzer wrote: > On 2/16/26 17:45, Tomasz Paku=C5=82a wrote: > > Many TVs and other HDMI sinks suffer from blanking and possibly other > > glitches when VRR is toggled. With VRR present on such sinks and > > vrr_on_desktop enabled, they behave like the signal is always variable, > > even in fixed refresh rate situations. DisplayPort and eDP enforce > > seamless VRR transitions but HDMI unfortunately doesn't. > >=20 > > Keep VRR toggled if it's supported and not explicitly disabled. It can > > be used for any VRR sinks, but this is mainly targeted for HDMI. > >=20 > > Functionally, for an end user, this is the same as normal, fixed refres= h > > rate mode. The only difference is that sink is kept in VRR state which > > enables seamless transitions into/out of variable refresh rate. > >=20 > > Basically, the driver shouldn't change it's behavior around VRR_ENABLED > > set to false, jut keep sending info packets/frames with VRR/FreeSync/ > > G-Sync/HDMI VRR active. > >=20 > > Enabled by default for sinks that claim it's support >=20 > Having a negation term like "disabled" in the property name can be confus= ing (as it involves double negation when the property value is 0) and is be= tter avoided. >=20 I understand that and felt a little cheaty by doing this but I couldn't for the life of my figure out how to make it so a driver could override this by default, before the compositor will set this. Would a "set" function work, just like for "capable" properties? =20 I 100% believe this "Passive VRR" for HDMI should be the default and helps massively but I'm not even that convinced if this must be user configurable. Alex asked to make it a property, but In the end, it's not something thsdat can be controlled on other OSes. I still believe that users should be able to change this somehow, but if amdgpu module setting wasn't a good fit, I don't know what is. In the end, I can just yeet all this completely and hardcode freesync_on_desktop =3D true for HDMI like it's done in the windows driver.