Re: [PATCH] drm/amdkfd: Fix improper NULL termination of queue restore SMI event string

[Philip Yang <yangp@amd.com>]

On 2025-12-01 16:00, Brian Kocoloski wrote:
> From: Brian Kocoloski <bkocolos@amd.com>
>
> Pass character "0" rather than NULL terminator to properly format
> queue restoration SMI events. Currently, the NULL terminator precedes
> the newline character that is intended to delineate separate events
> in the SMI event buffer, which can break userspace parsers.
>
> Signed-off-by: Brian Kocoloski <brian.kocoloski@amd.com>
Reviewed-by: Philip Yang <Philip.Yang@amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> index a499449fcb06..d2bc169e84b0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> @@ -312,7 +312,7 @@ void kfd_smi_event_queue_restore(struct kfd_node *node, pid_t pid)
>   {
>   	kfd_smi_event_add(pid, node, KFD_SMI_EVENT_QUEUE_RESTORE,
>   			  KFD_EVENT_FMT_QUEUE_RESTORE(ktime_get_boottime_ns(), pid,
> -			  node->id, 0));
> +			  node->id, '0'));
>   }
>   
>   void kfd_smi_event_queue_restore_rescheduled(struct mm_struct *mm)