From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kuehling, Felix" Subject: Re: [PATCH 7/8] drm/amdkfd: New IOCTL to allocate queue GWS Date: Mon, 13 May 2019 18:12:59 +0000 Message-ID: <83257525-4d46-acbd-5853-eeb6913fa398@amd.com> References: <1557504063-1559-1-git-send-email-Oak.Zeng@amd.com> <1557504063-1559-7-git-send-email-Oak.Zeng@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Zeng, Oak" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Russell, Kent" Cc: "Keely, Sean" T24gMjAxOS0wNS0xMyAxMjowMyBwLm0uLCBaZW5nLCBPYWsgd3JvdGU6DQo+IEhpIEZlbGl4LA0K Pg0KPiBTZWUgY29tbWVudHMgaW5saW5lIFtPYWtdDQo+DQo+IEhpIEtlbnQsIHRoZXJlIGlzIG9u ZSBGWUkgZW1iZWRkZWQsIHNvIGJlIGNhcmVmdWwgd2hlbiB5b3UgbWVyZ2UgdGhpcyBjaGFuZ2Ug YmFjayB0byBrZmQtc3RhZ2luZyBicmFuY2guDQo+DQo+IFJlZ2FyZHMsDQo+IE9haw0KPg0KPiAt LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBLdWVobGluZywgRmVsaXggPEZlbGl4 Lkt1ZWhsaW5nQGFtZC5jb20+DQo+IFNlbnQ6IEZyaWRheSwgTWF5IDEwLCAyMDE5IDQ6MjggUE0N Cj4gVG86IFplbmcsIE9hayA8T2FrLlplbmdAYW1kLmNvbT47IGFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnDQo+IENjOiBLZWVseSwgU2VhbiA8U2Vhbi5LZWVseUBhbWQuY29tPg0KPiBTdWJq ZWN0OiBSZTogW1BBVENIIDcvOF0gZHJtL2FtZGtmZDogTmV3IElPQ1RMIHRvIGFsbG9jYXRlIHF1 ZXVlIEdXUw0KPg0KPiBPbiAyMDE5LTA1LTEwIDEyOjAxIHAubS4sIFplbmcsIE9hayB3cm90ZToN Cj4+IEFkZCBhIG5ldyBrZmQgaW9jdGwgdG8gYWxsb2NhdGUgcXVldWUgR1dTLiBRdWV1ZSBHV1Mg aXMgcmVsZWFzZWQgb24NCj4+IHF1ZXVlIGRlc3Ryb3kuDQo+Pg0KPj4gQ2hhbmdlLUlkOiBJNjAx NTNjMjZhNTc3OTkyYWQ4NzNlNDI5MmU3NTllNWMzZDViYmQxNQ0KPj4gU2lnbmVkLW9mZi1ieTog T2FrIFplbmcgPE9hay5aZW5nQGFtZC5jb20+DQo+PiAtLS0NCj4+ICAgIGRyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1ka2ZkL2tmZF9jaGFyZGV2LmMgfCA0NSArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKw0KPj4gICAgaW5jbHVkZS91YXBpL2xpbnV4L2tmZF9pb2N0bC5oICAgICAgICAgICB8 IDE5ICsrKysrKysrKysrKystDQo+PiAgICAyIGZpbGVzIGNoYW5nZWQsIDYzIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRrZmQva2ZkX2NoYXJkZXYuYw0KPj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9r ZmRfY2hhcmRldi5jDQo+PiBpbmRleCAzOGFlNTNmLi4xN2RkOTcwIDEwMDY0NA0KPj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2NoYXJkZXYuYw0KPj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2NoYXJkZXYuYw0KPj4gQEAgLTMzOCw2ICszMzgsMTEg QEAgc3RhdGljIGludCBrZmRfaW9jdGxfZGVzdHJveV9xdWV1ZShzdHJ1Y3QgZmlsZQ0KPj4gKmZp bHAsIHN0cnVjdCBrZmRfcHJvY2VzcyAqcCwNCj4+ICAgIA0KPj4gICAgCW11dGV4X2xvY2soJnAt Pm11dGV4KTsNCj4+ICAgIA0KPj4gKwlpZiAocHFtX2dldF9nd3MoJnAtPnBxbSwgYXJncy0+cXVl dWVfaWQpKSB7DQo+PiArCQlhbWRncHVfYW1ka2ZkX3JlbW92ZV9nd3NfZnJvbV9wcm9jZXNzKHAt PmtnZF9wcm9jZXNzX2luZm8sDQo+PiArCQkJCXBxbV9nZXRfZ3dzKCZwLT5wcW0sIGFyZ3MtPnF1 ZXVlX2lkKSk7DQo+PiArCQlwcW1fc2V0X2d3cygmcC0+cHFtLCBhcmdzLT5xdWV1ZV9pZCwgTlVM TCk7DQo+PiArCX0NCj4gSXQgd291bGQgYmUgbW9yZSByb2J1c3QgaWYgdGhpcyB3YXMgZG9uZSBp bnNpZGUgcHFtX2Rlc3Ryb3lfcXVldWUuIFRoYXQgd2F5IHlvdSdkIGhhbmRsZSBvdGhlciBwb3Rl bnRpYWwgY29kZSBwYXRocyB0aGF0IGRlc3Ryb3kgcXVldWVzIChub3Qgc3VyZSB0aGVyZSBhcmUg YW55KSBhbmQgeW91IHdvdWxkbid0IG5lZWQgcHFtX2dldF9nd3MgZXhwb3J0ZWQgZnJvbSBQUU0u DQo+DQo+IFtPYWtdIEdvb2QgaWRlYS4gV2lsbCBkbyBpdC4gRXZlbiB0aG91Z2ggY3VycmVudGx5 IHRoZXJlIGlzIG5vIG90aGVyIGNvZGUgcGF0aCBkZXN0cm95aW5nIGEgcXVldWUgdXNpbmcgZ3dz LCB5b3VyIHdheSBpcyBzYWZlciBmb3IgZnV0dXJlIGNvZGUgY2hhbmdlLg0KPg0KPg0KPj4gICAg CXJldHZhbCA9IHBxbV9kZXN0cm95X3F1ZXVlKCZwLT5wcW0sIGFyZ3MtPnF1ZXVlX2lkKTsNCj4+ ICAgIA0KPj4gICAgCW11dGV4X3VubG9jaygmcC0+bXV0ZXgpOw0KPj4gQEAgLTE1NTksNiArMTU2 NCw0NCBAQCBzdGF0aWMgaW50IGtmZF9pb2N0bF91bm1hcF9tZW1vcnlfZnJvbV9ncHUoc3RydWN0 IGZpbGUgKmZpbGVwLA0KPj4gICAgCXJldHVybiBlcnI7DQo+PiAgICB9DQo+PiAgICANCj4+ICtz dGF0aWMgaW50IGtmZF9pb2N0bF9hbGxvY19xdWV1ZV9nd3Moc3RydWN0IGZpbGUgKmZpbGVwLA0K Pj4gKwkJc3RydWN0IGtmZF9wcm9jZXNzICpwLCB2b2lkICpkYXRhKQ0KPj4gK3sNCj4+ICsJaW50 IHJldHZhbDsNCj4+ICsJc3RydWN0IGtmZF9pb2N0bF9hbGxvY19xdWV1ZV9nd3NfYXJncyAqYXJn cyA9IGRhdGE7DQo+PiArCXN0cnVjdCBrZmRfZGV2ICpkZXYgPSBOVUxMOw0KPj4gKwlzdHJ1Y3Qg a2dkX21lbSAqbWVtOw0KPj4gKw0KPj4gKwlpZiAoYXJncy0+bnVtX2d3cyA9PSAwKQ0KPj4gKwkJ cmV0dXJuIC1FSU5WQUw7DQo+PiArDQo+PiArCWlmICghaHdzX2d3c19zdXBwb3J0IHx8DQo+PiAr CQlkZXYtPmRxbS0+c2NoZWRfcG9saWN5ID09IEtGRF9TQ0hFRF9QT0xJQ1lfTk9fSFdTKQ0KPj4g KwkJcmV0dXJuIC1FSU5WQUw7DQo+PiArDQo+PiArCWRldiA9IGtmZF9kZXZpY2VfYnlfaWQoYXJn cy0+Z3B1X2lkKTsNCj4+ICsJaWYgKCFkZXYpIHsNCj4+ICsJCXByX2RlYnVnKCJDb3VsZCBub3Qg ZmluZCBncHUgaWQgMHgleFxuIiwgYXJncy0+Z3B1X2lkKTsNCj4+ICsJCXJldHVybiAtRUlOVkFM Ow0KPj4gKwl9DQo+PiArDQo+PiArCXJldHZhbCA9IGFtZGdwdV9hbWRrZmRfYWRkX2d3c190b19w cm9jZXNzKHAtPmtnZF9wcm9jZXNzX2luZm8sDQo+PiArCQkJZGV2LT5nd3MsICZtZW0pOw0KPj4g KwlpZiAodW5saWtlbHkocmV0dmFsKSkNCj4+ICsJCXJldHVybiByZXR2YWw7DQo+PiArDQo+PiAr CW11dGV4X2xvY2soJnAtPm11dGV4KTsNCj4+ICsJcmV0dmFsID0gcHFtX3NldF9nd3MoJnAtPnBx bSwgYXJncy0+cXVldWVfaWQsIG1lbSk7DQo+PiArCW11dGV4X3VubG9jaygmcC0+bXV0ZXgpOw0K Pj4gKw0KPj4gKwlpZiAodW5saWtlbHkocmV0dmFsKSkNCj4+ICsJCWFtZGdwdV9hbWRrZmRfcmVt b3ZlX2d3c19mcm9tX3Byb2Nlc3MocC0+a2dkX3Byb2Nlc3NfaW5mbywgbWVtKTsNCj4+ICsNCj4+ ICsJLyogVGhlIGd3c19hcnJheSBwYXJhbWV0ZXIgaXMgcmVzZXJ2ZWQgZm9yIGZ1dHVyZSBleHRl bnNpb24qLw0KPj4gKwlhcmdzLT5nd3NfYXJyYXlbMF0gPSAwOw0KPj4gKwlyZXR1cm4gcmV0dmFs Ow0KPj4gK30NCj4+ICsNCj4+ICAgIHN0YXRpYyBpbnQga2ZkX2lvY3RsX2dldF9kbWFidWZfaW5m byhzdHJ1Y3QgZmlsZSAqZmlsZXAsDQo+PiAgICAJCXN0cnVjdCBrZmRfcHJvY2VzcyAqcCwgdm9p ZCAqZGF0YSkNCj4+ICAgIHsNCj4+IEBAIC0xNzYxLDYgKzE4MDQsOCBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IGFtZGtmZF9pb2N0bF9kZXNjIGFtZGtmZF9pb2N0bHNbXSA9IHsNCj4+ICAgIAlBTURL RkRfSU9DVExfREVGKEFNREtGRF9JT0NfSU1QT1JUX0RNQUJVRiwNCj4+ICAgIAkJCQlrZmRfaW9j dGxfaW1wb3J0X2RtYWJ1ZiwgMCksDQo+PiAgICANCj4+ICsJQU1ES0ZEX0lPQ1RMX0RFRihBTURL RkRfSU9DX0FMTE9DX1FVRVVFX0dXUywNCj4+ICsJCQlrZmRfaW9jdGxfYWxsb2NfcXVldWVfZ3dz LCAwKSwNCj4+ICAgIH07DQo+PiAgICANCj4+ICAgICNkZWZpbmUgQU1ES0ZEX0NPUkVfSU9DVExf Q09VTlQJQVJSQVlfU0laRShhbWRrZmRfaW9jdGxzKQ0KPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv dWFwaS9saW51eC9rZmRfaW9jdGwuaA0KPj4gYi9pbmNsdWRlL3VhcGkvbGludXgva2ZkX2lvY3Rs LmggaW5kZXggMjA5MTdjNS4uMTk2NGFiMiAxMDA2NDQNCj4+IC0tLSBhL2luY2x1ZGUvdWFwaS9s aW51eC9rZmRfaW9jdGwuaA0KPj4gKysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L2tmZF9pb2N0bC5o DQo+PiBAQCAtNDEwLDYgKzQxMCwyMCBAQCBzdHJ1Y3Qga2ZkX2lvY3RsX3VubWFwX21lbW9yeV9m cm9tX2dwdV9hcmdzIHsNCj4+ICAgIAlfX3UzMiBuX3N1Y2Nlc3M7CQkvKiB0by9mcm9tIEtGRCAq Lw0KPj4gICAgfTsNCj4+ICAgIA0KPj4gKy8qIEFsbG9jYXRlIEdXUyBmb3Igc3BlY2lmaWMgcXVl dWUNCj4+ICsgKg0KPj4gKyAqIEBncHVfaWQ6ICAgICAgZGV2aWNlIGlkZW50aWZpZXINCj4+ICsg KiBAcXVldWVfaWQ6ICAgIHF1ZXVlJ3MgaWQgdGhhdCBHV1MgaXMgYWxsb2NhdGVkIGZvcg0KPj4g KyAqIEBudW1fZ3dzOiAgICAgaG93IG1hbnkgR1dTIHRvIGFsbG9jYXRlDQo+PiArICogQGd3c19h cnJheTogICB1c2VkIHRvIHJldHVybiB0aGUgYWxsb2NhdGVkIGd3cw0KPj4gKyAqLw0KPj4gK3N0 cnVjdCBrZmRfaW9jdGxfYWxsb2NfcXVldWVfZ3dzX2FyZ3Mgew0KPj4gKwlfX3UzMiBncHVfaWQ7 CQkvKiB0byBLRkQgKi8NCj4+ICsJX191MzIgcXVldWVfaWQ7CQkvKiB0byBLRkQgKi8NCj4+ICsJ X191MzIgbnVtX2d3czsJCS8qIHRvIEtGRCAqLw0KPj4gKwlfX3UzMiAqZ3dzX2FycmF5OwkvKiBm cm9tIEtGRCAqLw0KPiBEb24ndCB1c2UgcG9pbnRlcnMgaW4gaW9jdGwgc3RydWN0dXJlcy4gVXNl IHVpbnQ2NF90LiBBY2Nlc3NpbmcgdXNlciBtb2RlIHBvaW50ZXJzIHJlcXVpcmVzIGNvcHlfdG8v ZnJvbV91c2VyIG9yIHNpbWlsYXIuDQo+DQo+IEFsc28gcHJlZmVyIHRvIG1vdmUgNjQtYml0IGVs ZW1lbnRzIHRvIHRoZSBmaXJzdCBlbGVtZW50IHRvIGVuc3VyZSBwcm9wZXIgYWxpZ25tZW50LCBh bmQgcGFkIHRoZSBzdHJ1Y3R1cmUgdG8gNjQtYml0IGZvciBBQkkgY29tcGF0aWJpbGl0eS4NCj4N Cj4gSSdtIG5vdCBzdXJlIHdoYXQgeW91ciBwbGFuIGlzIGZvciB0aGF0IGd3c19hcnJheS4gSWYg aXQncyBhIHBvaW50ZXIgdG8gYSB1c2VyIG1vZGUgYXJyYXksIHRoZW4gdGhhdCBhcnJheSBuZWVk cyBiZSBhbGxvY2F0ZWQgYnkgdXNlciBtb2RlLiBBbmQgdXNlciBtb2RlIHNob3VsZCBwcm9iYWJs eSBwYXNzIGRvd24gdGhlIHNpemUgb2YgdGhlIGFycmF5IGl0IGFsbG9jYXRlZCBpbiBhbm90aGVy IHBhcmFtZXRlci4NCj4NCj4gVGhhdCBzYWlkLCBJIHRoaW5rIHdoYXQgd2Ugd2FudCBpcyBub3Qg YW4gYXJyYXksIGJ1dCBqdXN0IHRoZSBpbmRleCBvZiB0aGUgZmlyc3QgR1dTIGVudHJ5IHRoYXQg d2FzIGFsbG9jYXRlZCBmb3IgdGhlIHF1ZXVlLCB3aGljaCBpcyBjdXJyZW50bHkgYWx3YXlzIDAu IFNvIEknbSBub3Qgc3VyZSB3aHkgeW91J3JlIGNhbGxpbmcgdGhpcyBhbiAiYXJyYXkiLg0KPg0K PiBbT2FrXSBGb3IgdGhlIGN1cnJlbnQgZGVzaWduLCBvbmUgcXVldWUgYWx3YXlzIGdldCBhbGwg NjQgR1dTLCBzbyByZXR1cm5pbmcgdGhlIGluZGV4IG9mIHRoZSBmaXJzdCBHV1MgKDApIGlzIG5v dCBhIHByb2JsZW0uIEluIHRoZSBmdXR1cmUsIGlzIGl0IHBvc3NpYmxlIHF1ZXVlIGNhbiBvbmx5 IGFsbG9jYXRlIGEgZmV3IG5vbmUtY29udGlndW91cyBHV1MsIGZvciBleGFtcGxlIEdXUzMgYW5k IEdXUzU2PyBJZiB0aGlzIGlzIHRoZSBjYXNlLCB3ZSB3aWxsIGhhdmUgdG8gY29weSBhbiBhcnJh eSBvZiBnd3MgYmFjayB0byB1c2VyIHNwYWNlLg0KDQpDdXJyZW50IEhXIG9ubHkgc3VwcG9ydCBj b250aWd1b3VzIGFsbG9jYXRpb25zIG9mIEdXUy4gSSBkb24ndCBmb3Jlc2VlIA0KdGhhdCBjaGFu Z2luZy4gSSB0aGluayB3ZSBjYW4gYWNrbm93bGVkZ2UgdGhhdCBpbiB0aGUgQVBJLg0KDQoNCj4N Cj4+ICt9Ow0KPj4gKw0KPj4gICAgc3RydWN0IGtmZF9pb2N0bF9nZXRfZG1hYnVmX2luZm9fYXJn cyB7DQo+PiAgICAJX191NjQgc2l6ZTsJCS8qIGZyb20gS0ZEICovDQo+PiAgICAJX191NjQgbWV0 YWRhdGFfcHRyOwkvKiB0byBLRkQgKi8NCj4+IEBAIC01MjksNyArNTQzLDEwIEBAIGVudW0ga2Zk X21taW9fcmVtYXAgew0KPj4gICAgI2RlZmluZSBBTURLRkRfSU9DX0lNUE9SVF9ETUFCVUYJCVwN Cj4+ICAgIAkJQU1ES0ZEX0lPV1IoMHgxRCwgc3RydWN0IGtmZF9pb2N0bF9pbXBvcnRfZG1hYnVm X2FyZ3MpDQo+PiAgICANCj4+ICsjZGVmaW5lIEFNREtGRF9JT0NfQUxMT0NfUVVFVUVfR1dTCQlc DQo+PiArCQlBTURLRkRfSU9XUigweDFFLCBzdHJ1Y3Qga2ZkX2lvY3RsX2FsbG9jX3F1ZXVlX2d3 c19hcmdzKQ0KPj4gKw0KPiBUaGlzIHdpbGwgZm9yY2UgdXMgdG8gbW92ZSBzb21lIGlvY3RsIG51 bWJlcnMgaW4gYW1kLWtmZC1zdGFnaW5nIGFuZCB0aGUgREtNUyBicmFuY2gsIHdoaWNoIHdpbGwg YnJlYWsgdGhlIEFCSSBvZiBvdXIgUk9DbSByZWxlYXNlcy4gTm90IHN1cmUgdGhlcmUgaXMgYSBn b29kIHdheSB0byBhdm9pZCB0aGF0IG90aGVyIHRoYW4gbGVhdmluZyBhIHdob2xlIGluIHRoZSB1 cHN0cmVhbSBpb2N0bCBzcGFjZS4gSSBnb3QgcHVzaC1iYWNrIG9uIHRoYXQga2luZCBvZiB0aGlu ZyB3aGVuIEkgb3JpZ2luYWxseSB1cHN0cmVhbWVkIEtGRC4gU28gdGhpcyBpcyBqdXN0IGFuIEZZ SS4NCj4gW09ha10gWWVzLCB3aGVuIHdlIG1lcmdlIHRoaXMgY2hhbmdlcyBiYWNrIHRvIGFtZC1r ZmQtc3RhZ2luZyBicmFuY2gsIHdlIGhhdmUgdG8gY2hhbmdlIHRoZSBpb2N0bCBudW1iZXIgZm9y IEdXUyBhbGxvY2F0aW9uIHRvIDB4MjIsIHRvIGFjY29tbW9kYXRlIGV4dHJhIGtmZCBpb2N0bHMg b24ga2ZkLXN0YWdpbmcgYnJhbmNoLiBAUnVzc2VsbCwgS2VudCBGWUkNCg0KTm8sIHRoZSBvdGhl ciB3YXkgYXJvdW5kLiBXaXRoIEFQSXMgdGhhdCBhcmUgdXBzdHJlYW0gd2Ugc2hvdWxkIGhhdmUg DQphbWQta2ZkLXN0YWdpbmcgbWF0Y2ggdGhlIHVwc3RyZWFtIEFCSS4gVGhhdCBtZWFucyB3ZSBo YXZlIHRvIG1vdmUgdGhlIA0Kb3RoZXIgbm9uLXVwc3RyZWFtIGlvY3RsIG51bWJlcnMuDQoNClJl Z2FyZHMsDQogwqAgRmVsaXgNCg0KDQo+DQo+IFJlZ2FyZHMsDQo+ICAgwqAgRmVsaXgNCj4NCj4+ ICAgICNkZWZpbmUgQU1ES0ZEX0NPTU1BTkRfU1RBUlQJCTB4MDENCj4+IC0jZGVmaW5lIEFNREtG RF9DT01NQU5EX0VORAkJMHgxRQ0KPj4gKyNkZWZpbmUgQU1ES0ZEX0NPTU1BTkRfRU5ECQkweDFG DQo+PiAgICANCj4+ICAgICNlbmRpZg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9h bWQtZ2Z4