From: Harry Wentland <harry.wentland@amd.com>
To: Jason Yan <yanaijie@huawei.com>,
sunpeng.li@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch,
mikita.lipski@amd.com, eryk.brol@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug
Date: Mon, 28 Sep 2020 10:11:51 -0400 [thread overview]
Message-ID: <835292b6-84e5-c4ba-e86a-3c402df91122@amd.com> (raw)
In-Reply-To: <8097f391-c62e-5b4d-a1d4-d2661714066e@huawei.com>
On 2020-09-28 10:06 a.m., Jason Yan wrote:
> ping...
>
Fix by YueHaibing is already merged for this:
commit 73b1acd54e13686fbb002afdf892c670177f0c57
Author: YueHaibing <yuehaibing@huawei.com>
Date: Thu Sep 10 11:13:52 2020 +0800
drm/amd/display: Create trigger_hotplug entry
Add trigger_hotplug debugfs entry.
Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger
debugfs entry")
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Harry
> 在 2020/9/12 10:22, Jason Yan 写道:
>> The 'trigger_hotplug' entry in debugfs is defined but not wired up. This
>> causes a gcc warning build with W=1.
>>
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:2045:37:
>>
>> warning: ‘dp_trigger_hotplug_debugfs_fops’ defined but not used
>> [-Wunused-const-variable=]
>> 2045 | static const struct file_operations
>> dp_trigger_hotplug_debugfs_fops = {
>> |
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>> index 94fcb086154c..972c780b6293 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>> @@ -2115,6 +2115,7 @@ static const struct {
>> {"dsc_pic_height", &dp_dsc_pic_height_debugfs_fops},
>> {"dsc_chunk_size", &dp_dsc_chunk_size_debugfs_fops},
>> {"dsc_slice_bpg", &dp_dsc_slice_bpg_offset_debugfs_fops},
>> + {"trigger_hotplug", &dp_trigger_hotplug_debugfs_fops},
>> {"dp_dsc_fec_support", &dp_dsc_fec_support_fops}
>> };
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-09-28 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 2:22 [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug Jason Yan
2020-09-28 14:06 ` Jason Yan
2020-09-28 14:11 ` Harry Wentland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835292b6-84e5-c4ba-e86a-3c402df91122@amd.com \
--to=harry.wentland@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eryk.brol@amd.com \
--cc=hulkci@huawei.com \
--cc=mikita.lipski@amd.com \
--cc=sunpeng.li@amd.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox