From: Luben Tuikov <luben.tuikov@amd.com>
To: Huang Rui <ray.huang@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Liu, Aaron" <Aaron.Liu@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: fix the wrong logic checking when secure buffer is created
Date: Tue, 18 Feb 2020 15:55:08 -0500 [thread overview]
Message-ID: <83fbdd37-7a4c-9b9b-8d7a-4cc52987f413@amd.com> (raw)
In-Reply-To: <20200218082703.GA6610@jenkins-Celadon-RN>
On 2020-02-18 3:27 a.m., Huang Rui wrote:
> On Tue, Feb 18, 2020 at 04:04:15PM +0800, Koenig, Christian wrote:
>> Am 18.02.20 um 07:12 schrieb Huang Rui:
>>> While the current amdgpu doesn't support TMZ, it will return the error if user
>>> mode would like to allocate secure buffer.
>>>
>>> Fixes: 17d907c drm/amdgpu: implement TMZ accessor (v3)
>>>
>>> Signed-off-by: Huang Rui <ray.huang@amd.com>
>>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> index b51a060..91e4235 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>> @@ -235,7 +235,7 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
>>> if (args->in.domains & ~AMDGPU_GEM_DOMAIN_MASK)
>>> return -EINVAL;
>>>
>>> - if (amdgpu_is_tmz(adev) && (flags & AMDGPU_GEM_CREATE_ENCRYPTED)) {
>>> + if (!amdgpu_is_tmz(adev) && (flags & AMDGPU_GEM_CREATE_ENCRYPTED)) {
>>> DRM_ERROR("Cannot allocate secure buffer since TMZ is disabled\n");
>>
>> BTW: This message should be removed because it allows userspace to spam
>> the logs.
>>
>
> Fine. This can be removed.
I already submitted this for review, along with the flags bugfix.
???
What's going on????
Regards,
Luben
>
> Thanks,
> Ray
>
>>> return -EINVAL;
>>> }
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-02-18 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 6:12 [PATCH] drm/amdgpu: fix the wrong logic checking when secure buffer is created Huang Rui
2020-02-18 8:04 ` Christian König
2020-02-18 8:27 ` Huang Rui
2020-02-18 20:55 ` Luben Tuikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fbdd37-7a4c-9b9b-8d7a-4cc52987f413@amd.com \
--to=luben.tuikov@amd.com \
--cc=Aaron.Liu@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox