From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Kuehling Subject: Re: [PATCH 1/7] drm/amdgpu: fix VM PD addr shift Date: Wed, 29 Nov 2017 14:33:28 -0500 Message-ID: <842e4e85-a2b7-e227-94ad-7d09a91b9b8f@amd.com> References: <20171127160217.4010-1-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171127160217.4010-1-christian.koenig-5C7GfCeVMHo@public.gmane.org> Content-Language: en-CA List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, =?UTF-8?Q?Christian_K=c3=b6nig?= SGkgQ2hyaXN0aWFuLAoKSSd2ZSBmaW5hbGx5IGZvdW5kIHRoZSB0aW1lIHRvIHJldmlldyB0aGUg cGF0Y2ggc2VyaWVzLiBJdCBtYWtlcyBzZW5zZQp0byBtZS4KCkkgdGhpbmsgdGhlIGV4cGxhbmF0 aW9uIG9uIHBhdGNoIDEgKCJUaGUgYmxvY2sgc2l6ZSBvbmx5IGFmZmVjdHMgdGhlCmxlYXZlIG5v ZGVzLCBldmVyeXRoaW5nIGVsc2UgaXMgZml4ZWQuIikgYWxzbyBhcHBsaWVzIHRvIHBhdGNoIDIg YW5kCndvdWxkIG1ha2UgaXQgZWFzaWVyIHRvIHVuZGVyc3RhbmQgdGhlIG1vdGl2YXRpb24gZm9y IHRoZSBjaGFuZ2UuCgpPdGhlciB0aGFuIHRoYXQsIHRoZSBzZXJpZXMgaXMgUmV2aWV3ZWQtYnk6 IEZlbGl4IEt1ZWhsaW5nCjxGZWxpeC5LdWVobGluZ0BhbWQuY29tPgoKUmVnYXJkcywKwqAgRmVs aXgKCgpPbiAyMDE3LTExLTI3IDExOjAyIEFNLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+IFRo ZSBibG9jayBzaXplIG9ubHkgYWZmZWN0cyB0aGUgbGVhdmUgbm9kZXMsIGV2ZXJ5dGhpbmcgZWxz ZSBpcyBmaXhlZC4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlh bi5rb2VuaWdAYW1kLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3ZtLmMgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jIGIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiBpbmRleCAxMjIzNzlkZmM3ZDguLmYxZTU0MWU5YjUxNCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4gQEAgLTEzOSw2ICsx MzksMjQgQEAgc3RydWN0IGFtZGdwdV9wcnRfY2Igewo+ICB9Owo+ICAKPiAgLyoqCj4gKyAqIGFt ZGdwdV92bV9sZXZlbF9zaGlmdCAtIHJldHVybiB0aGUgYWRkciBzaGlmdCBmb3IgZWFjaCBsZXZl bAo+ICsgKgo+ICsgKiBAYWRldjogYW1kZ3B1X2RldmljZSBwb2ludGVyCj4gKyAqCj4gKyAqIFJl dHVybnMgdGhlIG51bWJlciBvZiBiaXRzIHRoZSBwZm4gbmVlZHMgdG8gYmUgcmlnaHQgc2hpZnRl ZCBmb3IgYSBsZXZlbC4KPiArICovCj4gK3N0YXRpYyB1bnNpZ25lZCBhbWRncHVfdm1fbGV2ZWxf c2hpZnQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gKwkJCQkgICAgICB1bnNpZ25lZCBs ZXZlbCkKPiArewo+ICsJaWYgKGxldmVsICE9IGFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsKQo+ ICsJCXJldHVybiA5ICogKGFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsIC0gbGV2ZWwgLSAxKSAr Cj4gKwkJCWFkZXYtPnZtX21hbmFnZXIuYmxvY2tfc2l6ZTsKPiArCWVsc2UKPiArCQkvKiBGb3Ig dGhlIHBhZ2UgdGFibGVzIG9uIHRoZSBsZWF2ZXMgKi8KPiArCQlyZXR1cm4gMDsKPiArfQo+ICsK PiArLyoqCj4gICAqIGFtZGdwdV92bV9udW1fZW50cmllcyAtIHJldHVybiB0aGUgbnVtYmVyIG9m IGVudHJpZXMgaW4gYSBQRC9QVAo+ICAgKgo+ICAgKiBAYWRldjogYW1kZ3B1X2RldmljZSBwb2lu dGVyCj4gQEAgLTI4OCw4ICszMDYsNyBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9hbGxvY19sZXZl bHMoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAkJCQkgIHVpbnQ2NF90IHNhZGRyLCB1 aW50NjRfdCBlYWRkciwKPiAgCQkJCSAgdW5zaWduZWQgbGV2ZWwpCj4gIHsKPiAtCXVuc2lnbmVk IHNoaWZ0ID0gKGFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsIC0gbGV2ZWwpICoKPiAtCQlhZGV2 LT52bV9tYW5hZ2VyLmJsb2NrX3NpemU7Cj4gKwl1bnNpZ25lZCBzaGlmdCA9IGFtZGdwdV92bV9s ZXZlbF9zaGlmdChhZGV2LCBsZXZlbCk7Cj4gIAl1bnNpZ25lZCBwdF9pZHgsIGZyb20sIHRvOwo+ ICAJaW50IHI7Cj4gIAl1NjQgZmxhZ3M7Cj4gQEAgLTEzMDIsMTggKzEzMTksMTkgQEAgdm9pZCBh bWRncHVfdm1fZ2V0X2VudHJ5KHN0cnVjdCBhbWRncHVfcHRlX3VwZGF0ZV9wYXJhbXMgKnAsIHVp bnQ2NF90IGFkZHIsCj4gIAkJCSBzdHJ1Y3QgYW1kZ3B1X3ZtX3B0ICoqZW50cnksCj4gIAkJCSBz dHJ1Y3QgYW1kZ3B1X3ZtX3B0ICoqcGFyZW50KQo+ICB7Cj4gLQl1bnNpZ25lZCBpZHgsIGxldmVs ID0gcC0+YWRldi0+dm1fbWFuYWdlci5udW1fbGV2ZWw7Cj4gKwl1bnNpZ25lZCBsZXZlbCA9IDA7 Cj4gIAo+ICAJKnBhcmVudCA9IE5VTEw7Cj4gIAkqZW50cnkgPSAmcC0+dm0tPnJvb3Q7Cj4gIAl3 aGlsZSAoKCplbnRyeSktPmVudHJpZXMpIHsKPiAtCQlpZHggPSBhZGRyID4+IChwLT5hZGV2LT52 bV9tYW5hZ2VyLmJsb2NrX3NpemUgKiBsZXZlbC0tKTsKPiArCQl1bnNpZ25lZCBpZHggPSBhZGRy ID4+IGFtZGdwdV92bV9sZXZlbF9zaGlmdChwLT5hZGV2LCBsZXZlbCsrKTsKPiArCj4gIAkJaWR4 ICU9IGFtZGdwdV9ib19zaXplKCgqZW50cnkpLT5iYXNlLmJvKSAvIDg7Cj4gIAkJKnBhcmVudCA9 ICplbnRyeTsKPiAgCQkqZW50cnkgPSAmKCplbnRyeSktPmVudHJpZXNbaWR4XTsKPiAgCX0KPiAg Cj4gLQlpZiAobGV2ZWwpCj4gKwlpZiAobGV2ZWwgIT0gcC0+YWRldi0+dm1fbWFuYWdlci5udW1f bGV2ZWwpCj4gIAkJKmVudHJ5ID0gTlVMTDsKPiAgfQo+ICAKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeAo=