From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kuehling, Felix" <Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 6/6] drm/amdkfd: Fix sdma queue allocate race condition
Date: Thu, 6 Jun 2019 20:17:43 +0000
Message-ID: <85e5bc85-7b5f-6e57-3d29-9d649f748a4a@amd.com>
References: <1559845507-3052-1-git-send-email-Oak.Zeng@amd.com>
 <1559845507-3052-3-git-send-email-Oak.Zeng@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <1559845507-3052-3-git-send-email-Oak.Zeng-5C7GfCeVMHo@public.gmane.org>
Content-Language: en-US
Content-ID: <2B13A656842518419571AE8F6F2E8238-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org>
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: "Zeng, Oak" <Oak.Zeng-5C7GfCeVMHo@public.gmane.org>, "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Zhao, Yong" <Yong.Zhao-5C7GfCeVMHo@public.gmane.org>, "Freehill,
 Chris" <Chris.Freehill-5C7GfCeVMHo@public.gmane.org>, "Liu, Alex" <Alex.Liu-5C7GfCeVMHo@public.gmane.org>

UGF0Y2hlcyA1IGFuZCA2IGFyZSBSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1
ZWhsaW5nQGFtZC5jb20+DQoNCk9uIDIwMTktMDYtMDYgMjoyNSBwLm0uLCBaZW5nLCBPYWsgd3Jv
dGU6DQo+IFNETUEgcXVldWUgYWxsb2NhdGlvbiByZXF1aXJlcyB0aGUgZHFtIGxvY2sgYXQgaXQg
bW9kaWZ5DQo+IHRoZSBnbG9iYWwgZHFtIG1lbWJlcnMuIE1vdmUgdXAgdGhlIGRxbV9sb2NrIHNv
IHNkbWENCj4gcXVldWUgYWxsb2NhdGlvbiBpcyBlbmNsb3NlZCBpbiB0aGUgY3JpdGljYWwgc2Vj
dGlvbi4gTW92ZQ0KPiBtcWQgYWxsb2NhdGlvbiBvdXQgb2YgY3JpdGljYWwgc2VjdGlvbiB0byBh
dm9pZCBjaXJjdWxhcg0KPiBsb2NrIGRlcGVuZGVuY3kuDQo+DQo+IENoYW5nZS1JZDogSTk2YWJk
NDJlYWU2ZTc3YzgyYTViYTFiOGU2MDBhZjNlZmU4ZDc5MWQNCj4gU2lnbmVkLW9mZi1ieTogT2Fr
IFplbmcgPE9hay5aZW5nQGFtZC5jb20+DQo+IC0tLQ0KPiAgIC4uLi9ncHUvZHJtL2FtZC9hbWRr
ZmQva2ZkX2RldmljZV9xdWV1ZV9tYW5hZ2VyLmMgIHwgMjQgKysrKysrKysrKystLS0tLS0tLS0t
LQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkN
Cj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2Vf
cXVldWVfbWFuYWdlci5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2RldmljZV9x
dWV1ZV9tYW5hZ2VyLmMNCj4gaW5kZXggMTY2NjM2Yy4uY2QyNTliOCAxMDA2NDQNCj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2RldmljZV9xdWV1ZV9tYW5hZ2VyLmMNCj4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2RldmljZV9xdWV1ZV9tYW5hZ2Vy
LmMNCj4gQEAgLTExMzMsMjMgKzExMzMsMjcgQEAgc3RhdGljIGludCBjcmVhdGVfcXVldWVfY3Bz
Y2goc3RydWN0IGRldmljZV9xdWV1ZV9tYW5hZ2VyICpkcW0sIHN0cnVjdCBxdWV1ZSAqcSwNCj4g
ICAJaWYgKGRxbS0+dG90YWxfcXVldWVfY291bnQgPj0gbWF4X251bV9vZl9xdWV1ZXNfcGVyX2Rl
dmljZSkgew0KPiAgIAkJcHJfd2FybigiQ2FuJ3QgY3JlYXRlIG5ldyB1c2VybW9kZSBxdWV1ZSBi
ZWNhdXNlICVkIHF1ZXVlcyB3ZXJlIGFscmVhZHkgY3JlYXRlZFxuIiwNCj4gICAJCQkJZHFtLT50
b3RhbF9xdWV1ZV9jb3VudCk7DQo+IC0JCXJldHZhbCA9IC1FUEVSTTsNCj4gLQkJZ290byBvdXQ7
DQo+ICsJCXJldHVybiAtRVBFUk07DQo+ICAgCX0NCj4gICANCj4gKwltcWRfbWdyID0gZHFtLT5t
cWRfbWdyc1tnZXRfbXFkX3R5cGVfZnJvbV9xdWV1ZV90eXBlKA0KPiArCQkJcS0+cHJvcGVydGll
cy50eXBlKV07DQo+ICsJcS0+bXFkX21lbV9vYmogPSBtcWRfbWdyLT5hbGxvY2F0ZV9tcWQobXFk
X21nci0+ZGV2LCAmcS0+cHJvcGVydGllcyk7DQo+ICsJaWYgKCFxLT5tcWRfbWVtX29iaikNCj4g
KwkJcmV0dXJuIC1FTk9NRU07DQo+ICsNCj4gKwlkcW1fbG9jayhkcW0pOw0KPiAgIAlpZiAocS0+
cHJvcGVydGllcy50eXBlID09IEtGRF9RVUVVRV9UWVBFX1NETUEgfHwNCj4gICAJCXEtPnByb3Bl
cnRpZXMudHlwZSA9PSBLRkRfUVVFVUVfVFlQRV9TRE1BX1hHTUkpIHsNCj4gICAJCXJldHZhbCA9
IGFsbG9jYXRlX3NkbWFfcXVldWUoZHFtLCBxKTsNCj4gICAJCWlmIChyZXR2YWwpDQo+IC0JCQln
b3RvIG91dDsNCj4gKwkJCWdvdG8gb3V0X3VubG9jazsNCj4gICAJfQ0KPiAgIA0KPiAgIAlyZXR2
YWwgPSBhbGxvY2F0ZV9kb29yYmVsbChxcGQsIHEpOw0KPiAgIAlpZiAocmV0dmFsKQ0KPiAgIAkJ
Z290byBvdXRfZGVhbGxvY2F0ZV9zZG1hX3F1ZXVlOw0KPiAgIA0KPiAtCW1xZF9tZ3IgPSBkcW0t
Pm1xZF9tZ3JzW2dldF9tcWRfdHlwZV9mcm9tX3F1ZXVlX3R5cGUoDQo+IC0JCQlxLT5wcm9wZXJ0
aWVzLnR5cGUpXTsNCj4gICAJLyoNCj4gICAJICogRXZpY3Rpb24gc3RhdGUgbG9naWM6IG1hcmsg
YWxsIHF1ZXVlcyBhcyBldmljdGVkLCBldmVuIG9uZXMNCj4gICAJICogbm90IGN1cnJlbnRseSBh
Y3RpdmUuIFJlc3RvcmluZyBpbmFjdGl2ZSBxdWV1ZXMgbGF0ZXIgb25seQ0KPiBAQCAtMTE2MSwx
MiArMTE2NSw4IEBAIHN0YXRpYyBpbnQgY3JlYXRlX3F1ZXVlX2Nwc2NoKHN0cnVjdCBkZXZpY2Vf
cXVldWVfbWFuYWdlciAqZHFtLCBzdHJ1Y3QgcXVldWUgKnEsDQo+ICAgCQlkcW0tPmFzaWNfb3Bz
LmluaXRfc2RtYV92bShkcW0sIHEsIHFwZCk7DQo+ICAgCXEtPnByb3BlcnRpZXMudGJhX2FkZHIg
PSBxcGQtPnRiYV9hZGRyOw0KPiAgIAlxLT5wcm9wZXJ0aWVzLnRtYV9hZGRyID0gcXBkLT50bWFf
YWRkcjsNCj4gLQlxLT5tcWRfbWVtX29iaiA9IG1xZF9tZ3ItPmFsbG9jYXRlX21xZChtcWRfbWdy
LT5kZXYsICZxLT5wcm9wZXJ0aWVzKTsNCj4gLQlpZiAoIXEtPm1xZF9tZW1fb2JqKQ0KPiAtCQln
b3RvIG91dF9kZWFsbG9jYXRlX2Rvb3JiZWxsOw0KPiAgIAltcWRfbWdyLT5pbml0X21xZChtcWRf
bWdyLCAmcS0+bXFkLCBxLT5tcWRfbWVtX29iaiwNCj4gICAJCQkJJnEtPmdhcnRfbXFkX2FkZHIs
ICZxLT5wcm9wZXJ0aWVzKTsNCj4gLQlkcW1fbG9jayhkcW0pOw0KPiAgIA0KPiAgIAlsaXN0X2Fk
ZCgmcS0+bGlzdCwgJnFwZC0+cXVldWVzX2xpc3QpOw0KPiAgIAlxcGQtPnF1ZXVlX2NvdW50Kys7
DQo+IEBAIC0xMTkyLDEzICsxMTkyLDEzIEBAIHN0YXRpYyBpbnQgY3JlYXRlX3F1ZXVlX2Nwc2No
KHN0cnVjdCBkZXZpY2VfcXVldWVfbWFuYWdlciAqZHFtLCBzdHJ1Y3QgcXVldWUgKnEsDQo+ICAg
CWRxbV91bmxvY2soZHFtKTsNCj4gICAJcmV0dXJuIHJldHZhbDsNCj4gICANCj4gLW91dF9kZWFs
bG9jYXRlX2Rvb3JiZWxsOg0KPiAtCWRlYWxsb2NhdGVfZG9vcmJlbGwocXBkLCBxKTsNCj4gICBv
dXRfZGVhbGxvY2F0ZV9zZG1hX3F1ZXVlOg0KPiAgIAlpZiAocS0+cHJvcGVydGllcy50eXBlID09
IEtGRF9RVUVVRV9UWVBFX1NETUEgfHwNCj4gICAJCXEtPnByb3BlcnRpZXMudHlwZSA9PSBLRkRf
UVVFVUVfVFlQRV9TRE1BX1hHTUkpDQo+ICAgCQlkZWFsbG9jYXRlX3NkbWFfcXVldWUoZHFtLCBx
KTsNCj4gLW91dDoNCj4gK291dF91bmxvY2s6DQo+ICsJZHFtX3VubG9jayhkcW0pOw0KPiArCW1x
ZF9tZ3ItPmZyZWVfbXFkKG1xZF9tZ3IsIHEtPm1xZCwgcS0+bXFkX21lbV9vYmopOw0KPiAgIAly
ZXR1cm4gcmV0dmFsOw0KPiAgIH0NCj4gICANCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vYW1kLWdmeA==