AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/amdgpu/gmc9: re-enable AGP
Date: Mon, 8 Jan 2024 09:17:31 +0100	[thread overview]
Message-ID: <8677656a-50c9-4372-9776-07fc5d5da58a@gmail.com> (raw)
In-Reply-To: <20240103215536.1780386-1-alexander.deucher@amd.com>

Am 03.01.24 um 22:55 schrieb Alex Deucher:
> It should be fixed with
> commit ca0b006939f9 ("drm/amdgpu: fix AGP addressing when GART is not at 0")
> so re-enable it.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com> for the series.

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 9bff72356a37..de961bedad3b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1632,7 +1632,7 @@ static void gmc_v9_0_vram_gtt_location(struct amdgpu_device *adev,
>   	} else {
>   		amdgpu_gmc_vram_location(adev, mc, base);
>   		amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_BEST_FIT);
> -		if (!amdgpu_sriov_vf(adev) && (amdgpu_agp == 1))
> +		if (!amdgpu_sriov_vf(adev) && (amdgpu_agp != 0))
>   			amdgpu_gmc_agp_location(adev, mc);
>   	}
>   	/* base offset of vram pages */


      parent reply	other threads:[~2024-01-08  8:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 21:55 [PATCH 1/3] drm/amdgpu/gmc9: re-enable AGP Alex Deucher
2024-01-03 21:55 ` [PATCH 2/3] drm/amdgpu/gmc10: " Alex Deucher
2024-01-03 21:55 ` [PATCH 3/3] drm/amdgpu/gmc11: " Alex Deucher
2024-01-04 14:22   ` Zhang, Hawking
2024-01-08  8:17 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8677656a-50c9-4372-9776-07fc5d5da58a@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox