From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH v2 hmm 05/11] mm/hmm: Remove duplicate condition test before wait_event_timeout Date: Thu, 6 Jun 2019 20:06:52 -0700 Message-ID: <86962e22-88b1-c1bf-d704-d5a5053fa100@nvidia.com> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-6-jgg@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190606184438.31646-6-jgg@ziepe.ca> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jason Gunthorpe , Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com Cc: Andrea Arcangeli , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-mm@kvack.org, Jason Gunthorpe , dri-devel@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org T24gNi82LzE5IDExOjQ0IEFNLCBKYXNvbiBHdW50aG9ycGUgd3JvdGU6Cj4gRnJvbTogSmFzb24g R3VudGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+IAo+IFRoZSB3YWl0X2V2ZW50X3RpbWVvdXQg bWFjcm8gYWxyZWFkeSB0ZXN0cyB0aGUgY29uZGl0aW9uIGFzIGl0cyBmaXJzdAo+IGFjdGlvbiwg c28gdGhlcmUgaXMgbm8gcmVhc29uIHRvIG9wZW4gY29kZSBhbm90aGVyIHZlcnNpb24gb2YgdGhp cywgYWxsCj4gdGhhdCBkb2VzIGlzIHNraXAgdGhlIG1pZ2h0X3NsZWVwKCkgZGVidWdnaW5nIGlu IGNvbW1vbiBjYXNlcywgd2hpY2ggaXMKPiBub3QgaGVscGZ1bC4KPiAKPiBGdXJ0aGVyLCBiYXNl ZCBvbiBwcmlvciBwYXRjaGVzLCB3ZSBjYW4gbm8gc2ltcGxpZnkgdGhlIHJlcXVpcmVkIGNvbmRp dGlvbgoKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIm5vdyBzaW1w bGlmeSIKCj4gdGVzdDoKPiAgLSBJZiByYW5nZSBpcyB2YWxpZCBtZW1vcnkgdGhlbiBzbyBpcyBy YW5nZS0+aG1tCj4gIC0gSWYgaG1tX3JlbGVhc2UoKSBoYXMgcnVuIHRoZW4gcmFuZ2UtPnZhbGlk IGlzIHNldCB0byBmYWxzZQo+ICAgIGF0IHRoZSBzYW1lIHRpbWUgYXMgZGVhZCwgc28gbm8gcmVh c29uIHRvIGNoZWNrIGJvdGguCj4gIC0gQSB2YWxpZCBobW0gaGFzIGEgdmFsaWQgaG1tLT5tbS4K PiAKPiBBbHNvLCBhZGQgdGhlIFJFQURfT05DRSBmb3IgcmFuZ2UtPnZhbGlkIGFzIHRoZXJlIGlz IG5vIGxvY2sgaGVsZCBoZXJlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphc29uIEd1bnRob3JwZSA8 amdnQG1lbGxhbm94LmNvbT4KPiBSZXZpZXdlZC1ieTogSsOpcsO0bWUgR2xpc3NlIDxqZ2xpc3Nl QHJlZGhhdC5jb20+Cj4gLS0tCj4gIGluY2x1ZGUvbGludXgvaG1tLmggfCAxMiArKy0tLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaG1tLmggYi9pbmNsdWRlL2xpbnV4L2htbS5o Cj4gaW5kZXggNGVlM2FjYWJlNWVkMjIuLjJhYjM1YjQwOTkyYjI0IDEwMDY0NAo+IC0tLSBhL2lu Y2x1ZGUvbGludXgvaG1tLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L2htbS5oCj4gQEAgLTIxOCwx NyArMjE4LDkgQEAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25nIGhtbV9yYW5nZV9wYWdlX3Np emUoY29uc3Qgc3RydWN0IGhtbV9yYW5nZSAqcmFuZ2UpCj4gIHN0YXRpYyBpbmxpbmUgYm9vbCBo bW1fcmFuZ2Vfd2FpdF91bnRpbF92YWxpZChzdHJ1Y3QgaG1tX3JhbmdlICpyYW5nZSwKPiAgCQkJ CQkgICAgICB1bnNpZ25lZCBsb25nIHRpbWVvdXQpCj4gIHsKPiAtCS8qIENoZWNrIGlmIG1tIGlz IGRlYWQgPyAqLwo+IC0JaWYgKHJhbmdlLT5obW0gPT0gTlVMTCB8fCByYW5nZS0+aG1tLT5kZWFk IHx8IHJhbmdlLT5obW0tPm1tID09IE5VTEwpIHsKPiAtCQlyYW5nZS0+dmFsaWQgPSBmYWxzZTsK PiAtCQlyZXR1cm4gZmFsc2U7Cj4gLQl9Cj4gLQlpZiAocmFuZ2UtPnZhbGlkKQo+IC0JCXJldHVy biB0cnVlOwo+IC0Jd2FpdF9ldmVudF90aW1lb3V0KHJhbmdlLT5obW0tPndxLCByYW5nZS0+dmFs aWQgfHwgcmFuZ2UtPmhtbS0+ZGVhZCwKPiArCXdhaXRfZXZlbnRfdGltZW91dChyYW5nZS0+aG1t LT53cSwgcmFuZ2UtPnZhbGlkLAo+ICAJCQkgICBtc2Vjc190b19qaWZmaWVzKHRpbWVvdXQpKTsK PiAtCS8qIFJldHVybiBjdXJyZW50IHZhbGlkIHN0YXR1cyBqdXN0IGluIGNhc2Ugd2UgZ2V0IGx1 Y2t5ICovCj4gLQlyZXR1cm4gcmFuZ2UtPnZhbGlkOwo+ICsJcmV0dXJuIFJFQURfT05DRShyYW5n ZS0+dmFsaWQpOwoKSnVzdCB0byBlbnN1cmUgdGhhdCBJIGFjdHVhbGx5IHVuZGVyc3RhbmQgdGhl IG1vZGVsOiBJJ20gYXNzdW1pbmcgdGhhdCB0aGUgClJFQURfT05DRSBpcyB0aGVyZSBzb2xlbHkg dG8gZW5zdXJlIHRoYXQgcmFuZ2UtPnZhbGlkIGlzIHJlYWQgKmFmdGVyKiB0aGUKd2FpdF9ldmVu dF90aW1lb3V0KCkgcmV0dXJucy4gSXMgdGhhdCBjb3JyZWN0PwoKCj4gIH0KPiAgCj4gIC8qCj4g CgpJbiBhbnkgY2FzZSwgaXQgbG9va3MgZ29vZCwgc286CgogICAgUmV2aWV3ZWQtYnk6IEpvaG4g SHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KCnRoYW5rcywKLS0gCkpvaG4gSHViYmFyZApO VklESUEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs