From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend Date: Mon, 8 Oct 2018 20:21:51 +0200 Message-ID: <872987e6-57a0-ff6f-c39e-b75c98fd6ecd@gmail.com> References: <1538565000-30532-1-git-send-email-Rex.Zhu@amd.com> <1538565000-30532-2-git-send-email-Rex.Zhu@amd.com> <37f64613-0ae4-df1e-b306-00abdb71eb11@gmail.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Zhu, Rex" , "Koenig, Christian" , "Deucher, Alexander" , Alex Deucher Cc: amd-gfx list QW0gMDguMTAuMjAxOCB1bSAyMDoxNSBzY2hyaWViIFpodSwgUmV4Ogo+Cj4+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IEtvZW5pZywgQ2hyaXN0aWFuCj4+IFNlbnQ6IFR1ZXNk YXksIE9jdG9iZXIgOSwgMjAxOCAyOjAzIEFNCj4+IFRvOiBaaHUsIFJleCA8UmV4LlpodUBhbWQu Y29tPjsgRGV1Y2hlciwgQWxleGFuZGVyCj4+IDxBbGV4YW5kZXIuRGV1Y2hlckBhbWQuY29tPjsg QWxleCBEZXVjaGVyIDxhbGV4ZGV1Y2hlckBnbWFpbC5jb20+Cj4+IENjOiBhbWQtZ2Z4IGxpc3Qg PGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnPgo+PiBTdWJqZWN0OiBSZTogW1BBVENIIDEv NV0gZHJtL2FtZGdwdTogRG9uJ3QgcmVhbGxvY2F0ZSB1Y29kZSBibyB3aGVuCj4+IHN1c3BlbmQK Pj4KPj4gQW0gMDguMTAuMjAxOCB1bSAxOTo1OCBzY2hyaWViIFpodSwgUmV4Ogo+Pj4+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+Pj4gRnJvbTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2tvZW5p Zy5sZWljaHR6dW1lcmtlbkBnbWFpbC5jb20+Cj4+Pj4gU2VudDogVHVlc2RheSwgT2N0b2JlciA5 LCAyMDE4IDE6MzIgQU0KPj4+PiBUbzogWmh1LCBSZXggPFJleC5aaHVAYW1kLmNvbT47IERldWNo ZXIsIEFsZXhhbmRlcgo+Pj4+IDxBbGV4YW5kZXIuRGV1Y2hlckBhbWQuY29tPjsgQWxleCBEZXVj aGVyIDxhbGV4ZGV1Y2hlckBnbWFpbC5jb20+Cj4+Pj4gQ2M6IGFtZC1nZnggbGlzdCA8YW1kLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmc+Cj4+Pj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzVdIGRy bS9hbWRncHU6IERvbid0IHJlYWxsb2NhdGUgdWNvZGUgYm8gd2hlbgo+Pj4+IHN1c3BlbmQKPj4+ Pgo+Pj4+IEFtIDA4LjEwLjIwMTggdW0gMTg6MzAgc2NocmllYiBaaHUsIFJleDoKPj4+Pj4+IC0t LS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+Pj4+PiBGcm9tOiBEZXVjaGVyLCBBbGV4YW5kZXIK Pj4+Pj4+IFNlbnQ6IFR1ZXNkYXksIE9jdG9iZXIgOSwgMjAxOCAxMjoyMSBBTQo+Pj4+Pj4gVG86 IFpodSwgUmV4IDxSZXguWmh1QGFtZC5jb20+OyBBbGV4IERldWNoZXIKPj4+PiA8YWxleGRldWNo ZXJAZ21haWwuY29tPgo+Pj4+Pj4gQ2M6IGFtZC1nZnggbGlzdCA8YW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmc+Cj4+Pj4+PiBTdWJqZWN0OiBSRTogW1BBVENIIDEvNV0gZHJtL2FtZGdwdTog RG9uJ3QgcmVhbGxvY2F0ZSB1Y29kZSBibyB3aGVuCj4+Pj4+PiBzdXNwZW5kCj4+Pj4+Pgo+Pj4+ Pj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+Pj4+Pj4gRnJvbTogYW1kLWdmeCA8YW1k LWdmeC1ib3VuY2VzQGxpc3RzLmZyZWVkZXNrdG9wLm9yZz4gT24gQmVoYWxmCj4+IE9mCj4+Pj4+ Pj4gWmh1LCBSZXgKPj4+Pj4+PiBTZW50OiBNb25kYXksIE9jdG9iZXIgOCwgMjAxOCAxMTo1NyBB TQo+Pj4+Pj4+IFRvOiBBbGV4IERldWNoZXIgPGFsZXhkZXVjaGVyQGdtYWlsLmNvbT4KPj4+Pj4+ PiBDYzogYW1kLWdmeCBsaXN0IDxhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZz4KPj4+Pj4+ PiBTdWJqZWN0OiBSRTogW1BBVENIIDEvNV0gZHJtL2FtZGdwdTogRG9uJ3QgcmVhbGxvY2F0ZSB1 Y29kZSBibwo+Pj4+Pj4+IHdoZW4gc3VzcGVuZAo+Pj4+Pj4+Cj4+Pj4+Pj4KPj4+Pj4+Pgo+Pj4+ Pj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+Pj4+Pj4+PiBGcm9tOiBBbGV4IERldWNo ZXIgPGFsZXhkZXVjaGVyQGdtYWlsLmNvbT4KPj4+Pj4+Pj4gU2VudDogVGh1cnNkYXksIE9jdG9i ZXIgNCwgMjAxOCAxMTozNSBBTQo+Pj4+Pj4+PiBUbzogWmh1LCBSZXggPFJleC5aaHVAYW1kLmNv bT4KPj4+Pj4+Pj4gQ2M6IGFtZC1nZnggbGlzdCA8YW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmc+Cj4+Pj4+Pj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS81XSBkcm0vYW1kZ3B1OiBEb24ndCBy ZWFsbG9jYXRlIHVjb2RlIGJvCj4+Pj4+Pj4+IHdoZW4gc3VzcGVuZAo+Pj4+Pj4+Pgo+Pj4+Pj4+ PiBPbiBXZWQsIE9jdCAzLCAyMDE4IGF0IDc6MTEgQU0gUmV4IFpodSA8UmV4LlpodUBhbWQuY29t PiB3cm90ZToKPj4+Pj4+Pj4+IGRyaXZlciBkb24ndCByZWxlYXNlIHRoZSB1Y29kZSBtZW1vcnkg d2hlbiBzdXNwZW5kLiBzbyBkb24ndAo+Pj4+Pj4+Pj4gbmVlZCB0byBhbGxvY2F0ZSBibyB3aGVu IHJlc3VtZSBiYWNrLgo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFJleCBaaHUg PFJleC5aaHVAYW1kLmNvbT4KPj4+Pj4+Pj4+IC0tLQo+Pj4+Pj4+Pj4gICAgIGRyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jIHwgMiArLQo+Pj4+Pj4+Pj4gICAgIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Pj4+Pj4+Pj4KPj4+Pj4+ Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdWNvZGUu Ywo+Pj4+Pj4+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdWNvZGUuYwo+ Pj4+Pj4+Pj4gaW5kZXggOTg3ODIxMi4uYWRmZWI5MyAxMDA2NDQKPj4+Pj4+Pj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jCj4+Pj4+Pj4+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdWNvZGUuYwo+Pj4+Pj4+Pj4gQEAgLTQz NCw3ICs0MzQsNyBAQCBpbnQgYW1kZ3B1X3Vjb2RlX2luaXRfYm8oc3RydWN0Cj4+Pj4+PiBhbWRn cHVfZGV2aWNlCj4+Pj4+Pj4+ICphZGV2KQo+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgIHJl dHVybiAwOwo+Pj4+Pj4+Pj4gICAgICAgICAgICB9Cj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4gLSAgICAg ICBpZiAoIWFkZXYtPmluX2dwdV9yZXNldCkgewo+Pj4+Pj4+Pj4gKyAgICAgICBpZiAoIWFkZXYt PmluX2dwdV9yZXNldCAmJiAhYWRldi0+aW5fc3VzcGVuZCkgewo+Pj4+Pj4+Pj4gICAgICAgICAg ICAgICAgICAgIGVyciA9IGFtZGdwdV9ib19jcmVhdGVfa2VybmVsKGFkZXYsCj4+Pj4+Pj4+PiBh ZGV2LT5maXJtd2FyZS5md19zaXplLAo+Pj4+Pj4+PiBQQUdFX1NJWkUsCj4+Pj4+Pj4+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYW1kZ3B1X3NyaW92X3ZmKGFk ZXYpID8KPj4+Pj4+Pj4gQU1ER1BVX0dFTV9ET01BSU5fVlJBTSA6IEFNREdQVV9HRU1fRE9NQUlO X0dUVCwKPj4+Pj4+Pj4+ICZhZGV2LT5maXJtd2FyZS5md19idWYsCj4+Pj4+Pj4+IE5vdCBzdXJl IGlmIHdlIHN1cHBvcnQgUzMgaW4gU1ItSU9WLCBidXQgSSB0aGluayB0aGlzIHdpbGwgYnJlYWsK Pj4+Pj4+Pj4gaXQgYmVjYXVzZSB3ZSdsbCBsb3NlIHZyYW0gY29udGVudHMgYW5kIG5vdCByZS1p bml0IGl0Lgo+Pj4+Pj4+IENvbmZpcm0gd2l0aCBTUi1JT1YgdGVhbSwgUzMgd2FzIG5vdCBzdXBw b3J0ZWQgaW4gU1ItSU9WLgo+Pj4+Pj4+Cj4+Pj4+Pj4gICAgIEJ1dCBJIHN0aWxsIGNvbmZ1c2Vk IHdoeSB0aGlzIHBhdGNoIHdpbGwgYnJlYWsgdGhlIHN1c3BlbmQgaWYKPj4+Pj4+PiBpbiBTUklP Vgo+Pj4+IGNhc2U/Cj4+Pj4+PiBQaW5uZWQgYnVmZmVycyBkb24ndCBnZXQgZXZpY3RlZCBzbyBp ZiB3ZSBsb3NlIFZSQU0gZHVlIHRvIGEgZ3B1Cj4+Pj4+PiByZXNldCBvciBTMywgdGhlIGRhdGEg aXMgbG9zdC4gIEdUVCBpcyByZXRhaW5lZCBzaW5jZSB0aGUgT1MgbWFuYWdlcyB0aGF0Lgo+Pj4+ PiBUaGUgZ2FydCB0YWJsZSB3YXMgdW5waW5uZWQgd2hlbiBzdXNwZW5kLnNvIGRvbid0IG5lZWQg dG8gY3JlYXRlIHRoZQo+Pj4+PiBibwo+Pj4+IGFnYWluLiB3ZSBzdGlsbCBjb3B5IHRoZSB1Y29k ZSB0byB0aGUgYm8uCj4+Pj4+IEFuZCBpbiBiYXJlbWV0YWwsICB0aGlzIGZ1bmN0aW9uIGNhbiBy ZXR1cm4gZGlyZWN0bHkgZm9yIFMzLgo+Pj4+IFRoYXQncyBpcnJlbGV2YW50Lgo+Pj4+Cj4+Pj4g VGhlIHdob2xlIGNvZGUgaXMgYnVnZ3kgc2luY2UgYW1kZ3B1X3Vjb2RlX2ZpbmlfYm8oKSB3aWxs IGRyb3AgdGhlIEJPCj4+Pj4gaW5kZXBlbmRlbnQgaWYgd2UgYXJlIGluIHJlc2V0IG9yIGluIHN1 c3BlbmQuCj4+PiBXZSBkb24ndCBjYWxsIGFtZGdwdV91Y29kZV9maW5pX2JvIHdoZW4gc3VzcGVu ZC9zcmlvdl9yZXNldC4KPj4gWWVhaCBhbmQgZXhhY3RseSB0aGF0J3MgdGhlIGJ1ZyB3aGljaCBz aG91bGQgYmUgZml4ZWQgaW5zdGVhZC4KPiBTb3JyeSwgSSBkb24ndCB1bmRlcnN0YW5kLgo+IFdo eSB3ZSBuZWVkIHRvIHJlbGVhc2UgdGhlIGJvIHdoZW4gc3VzcGVuZD8KPiBJbiBhbWRncHUsIHdl IGNyZWF0ZSBhIGJ1bmNoIG9mIGJvKHZyYW1fc2NyYXRjaC5yb2JqLCBlLmcpLCB3ZSBvbmx5IGZy ZWUgdGhlbSB3aGVuIGRyaXZlciB1bmxvYWQuCgpZb3Ugc2hvdWxkIG5vdCByZWxlYXNlIHRoZSBC TyB3aGlsZSBzdXNwZW5kaW5nLCBidXQgdGhlIAphbWRncHVfdWNvZGVfZmluaV9ibygpIGFuZCBh bWRncHVfdWNvZGVfaW5pdF9ibygpIHNob3VsZCBiZSBjYWxsZWQgdW5kZXIgCnRoZSBzYW1lIGNv bmRpdGlvbnMuCgpUaGlzIG1lYW5zIHdlIHNob3VsZCBlaXRoZXIgc2VwYXJhdGUgZmlsbGluZyB0 aGUgQk8gZnJvbSBhbGxvY2F0aW5nIGl0IAooZS5nLiBzcGxpdCBhbWRncHVfdWNvZGVfaW5pdF9i byBpbnRvIHR3byBmdW5jdGlvbnMpIGFuZCB0aGVuIG9ubHkgY2FsbCAKdGhlIGZpbGxpbmcgZnVu Y3Rpb24gZHVyaW5nIEdQVSByZXNldCBhbmQgcmVzdW1lLgoKT3Igd2UgYWRkIHRoZSBzYW1lICJp ZiAoIWFkZXYtPmluX2dwdV9yZXNldCAmJiAhYWRldi0+aW5fc3VzcGVuZCkiIGludG8gCnRoZSBh bWRncHVfdWNvZGVfZmluaV9ibygpIGZ1bmN0aW9uIGFzIHdlbGwuCgpJIGNvbnNpZGVyIHRoZSBm aXJzdCBvbmUgbW9yZSBjbGVhbmVyLgoKQ2hyaXN0aWFuLgoKPgo+IFJleAo+Cj4+IENocmlzdGlh bi4KPj4KPj4+IFJleAo+Pj4KPj4+PiBUaGUgY29ycmVjdCBoYW5kbGluZyBoZXJlIGlzIHRvIHJl bW92ZSB0aGUgaWYgYWxsIHRvZ2V0aGVyIGFuZCBtYWtlCj4+Pj4gc3VyZQo+Pj4+IGFtZGdwdV9i b19jcmVhdGVfa2VybmVsKCkgaXMgQUxXQVlTIGNhbGxlZC4KPj4+Pgo+Pj4+IENhdXNlIHRoZW4g aXQgaXMgYWx3YXlzIHJlLWNyZWF0ZWQgaWYgaXQgaXNuJ3QgdGhlcmUgYWxyZWFkeS4KPj4+Pgo+ Pj4+IEFsdGVybmF0aXZlbHkgd2UgY291bGQgZml4IHVwIHRoZSBjYWxsZXJzIG9mIGFtZGdwdV91 Y29kZV9pbml0X2JvKCkKPj4+PiBhbmQKPj4+PiBhbWRncHVfdWNvZGVfZmluaV9ibygpIHRvIGJl IGNvcnJlY3RseSBiYWxhbmNlZC4KPj4+Pgo+Pj4+IENocmlzdGlhbi4KPj4+Pgo+Pj4+PiBSZXgK Pj4+Pj4KPj4+Pj4KPj4+Pj4+IEFsZXgKPj4+Pj4+Cj4+Pj4+Pj4gUmV4Cj4+Pj4+Pj4KPj4+Pj4+ Pj4gQWxleAo+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4gLS0KPj4+Pj4+Pj4+IDEuOS4xCj4+Pj4+Pj4+Pgo+ Pj4+Pj4+Pj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K Pj4+Pj4+Pj4+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4+Pj4+Pj4+PiBhbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+Pj4+Pj4+Pj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9hbWQtZ2Z4Cj4+Pj4+Pj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPj4+Pj4+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+Pj4+Pj4+ IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+Pj4+Pj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cj4+Pj4+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+Pj4+IGFtZC1nZnggbWFpbGluZyBs aXN0Cj4+Pj4+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+Pj4+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYW1kLWdmeCBtYWlsaW5nIGxp c3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9hbWQtZ2Z4Cg==