From: Eric Anholt <eric@anholt.net>
To: Brian Starkey <Brian.Starkey@arm.com>,
Boris Brezillon <boris.brezillon@bootlin.com>
Cc: "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>, nd <nd@arm.com>,
"Christian König" <christian.koenig@amd.com>,
"Ben Skeggs" <bskeggs@redhat.com>
Subject: Re: [PATCH v3 1/3] drm/connector: Add generic underscan properties
Date: Wed, 28 Nov 2018 09:17:07 -0800 [thread overview]
Message-ID: <875zwh6s18.fsf@anholt.net> (raw)
In-Reply-To: <20181122173658.7gvnl3trkdhsqn3p@DESKTOP-E1NTVVP.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 1032 bytes --]
Brian Starkey <Brian.Starkey@arm.com> writes:
> Hi Boris,
>
> Just because I happened to read the docs in here, one typo below:
>
> On Thu, Nov 22, 2018 at 12:23:29PM +0100, Boris Brezillon wrote:
>>diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
>>index c555e17ab8d7..170317248da6 100644
>>--- a/drivers/gpu/drm/drm_connector.c
>>+++ b/drivers/gpu/drm/drm_connector.c
>>@@ -971,6 +971,38 @@ DRM_ENUM_NAME_FN(drm_get_content_protection_name, drm_cp_enum_list)
>> * can also expose this property to external outputs, in which case they
>> * must support "None", which should be the default (since external screens
>> * have a built-in scaler).
>>+ *
>>+ * Connectors for non-analog outputs may also have standardized underscan
>>+ * properties (drivers can set this up by calling
>>+ * drm_connector_attach_content_protection_property() on initialization):
>
> Should be drm_connector_attach_underscan_properties()
Other than this typo, this series is:
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-11-28 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 11:23 [PATCH v3 0/3] drm/connector: Provide generic support for underscan Boris Brezillon
2018-11-22 11:23 ` [PATCH v3 1/3] drm/connector: Add generic underscan properties Boris Brezillon
[not found] ` <20181122112331.17735-2-boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
2018-11-22 17:36 ` Brian Starkey
2018-11-28 17:17 ` Eric Anholt [this message]
2018-12-03 14:40 ` Ville Syrjälä
2018-12-03 15:36 ` Boris Brezillon
2018-12-03 15:50 ` Eric Anholt
2018-12-04 10:42 ` Daniel Vetter
[not found] ` <20181122112331.17735-1-boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
2018-11-22 11:23 ` [PATCH v3 2/3] drm/vc4: Take underscan setup into account when updating planes Boris Brezillon
2018-11-22 11:23 ` [PATCH v3 3/3] drm/vc4: Attach underscan props to the HDMI connector Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zwh6s18.fsf@anholt.net \
--to=eric@anholt.net \
--cc=Brian.Starkey@arm.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=boris.brezillon@bootlin.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nd@arm.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox