From: Jani Nikula via amd-gfx <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
nikola.cornij-5C7GfCeVMHo@public.gmane.org,
Manasi Navare
<manasi.d.navare-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
harry.wentland-5C7GfCeVMHo@public.gmane.org,
David Francis <David.Francis-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [Intel-gfx] [PATCH 0/3] Make DRM DSC helpers more generally usable
Date: Thu, 14 Feb 2019 15:09:01 +0200 [thread overview]
Message-ID: <877ee2wm8i.fsf@intel.com> (raw)
In-Reply-To: <20190213144536.21661-1-David.Francis-5C7GfCeVMHo@public.gmane.org>
On Wed, 13 Feb 2019, David Francis <David.Francis@amd.com> wrote:
> drm_dsc could use some work so that drm drivers other than
> i915 can make use of it their own DSC implementations
>
> Move rc compute, a function that forms part of the DSC spec,
> into drm. Update it to DSC 1.2. Also change the packing function
> to operate only on the packing struct, to allow for drivers with
> their own SDP struct headers
Acked-by: Jani Nikula <jani.nikula@intel.com>
as long as you've ironed out the details with Manasi's review. Also okay
to merge via drm-misc.
Ideally, please rebase on drm-tip and continue to Cc: intel-gfx so the
Intel CI machinery can crunch through this. Now the patches failed to
apply.
Thanks,
Jani.
>
> David Francis (3):
> drm/i915: Move dsc rate params compute into drm
> drm/dsc: Add native 420 and 422 support to compute_rc_params
> drm/dsc: Change infoframe_pack to payload_pack
>
> drivers/gpu/drm/drm_dsc.c | 236 ++++++++++++++++++++++++------
> drivers/gpu/drm/i915/intel_vdsc.c | 131 +----------------
> include/drm/drm_dsc.h | 7 +-
> 3 files changed, 200 insertions(+), 174 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-02-14 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 14:45 [PATCH 0/3] Make DRM DSC helpers more generally usable David Francis
[not found] ` <20190213144536.21661-1-David.Francis-5C7GfCeVMHo@public.gmane.org>
2019-02-13 14:45 ` [PATCH 1/3] drm/i915: Move dsc rate params compute into drm David Francis
2019-02-13 15:26 ` Wentland, Harry
2019-02-13 18:36 ` Manasi Navare
2019-02-14 3:31 ` [Intel-gfx] " kbuild test robot via dri-devel
2019-02-14 11:09 ` Dan Carpenter via dri-devel
2019-02-13 14:45 ` [PATCH 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params David Francis
[not found] ` <20190213144536.21661-3-David.Francis-5C7GfCeVMHo@public.gmane.org>
2019-02-13 15:27 ` Wentland, Harry
2019-02-13 18:49 ` Manasi Navare via amd-gfx
2019-02-13 14:45 ` [PATCH 3/3] drm/dsc: Change infoframe_pack to payload_pack David Francis
2019-02-13 15:35 ` Wentland, Harry
[not found] ` <20190213144536.21661-4-David.Francis-5C7GfCeVMHo@public.gmane.org>
2019-02-13 21:22 ` Manasi Navare via amd-gfx
2019-02-14 13:09 ` Jani Nikula via amd-gfx [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ee2wm8i.fsf@intel.com \
--to=amd-gfx-pd4fty7x32lngt0pjobp9y5qc8qiuhrw@public.gmane.org \
--cc=David.Francis-5C7GfCeVMHo@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=harry.wentland-5C7GfCeVMHo@public.gmane.org \
--cc=intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=manasi.d.navare-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=nikola.cornij-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox