From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 259C6C25B75 for ; Thu, 6 Jun 2024 07:21:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B65B10E848; Thu, 6 Jun 2024 07:21:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BcqQ0nRX"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B52610E848; Thu, 6 Jun 2024 07:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717658475; x=1749194475; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=QD4Dh8MLYOkud3AMPflq2aHwK8HUP7fobAgy/H0UKDA=; b=BcqQ0nRXN3UAaO9qo0VPfA2KsOWeVHlICYIqwd54oYo+eleSDegNwMJR +wP2hiBwT6aJVnFebrXMcnTldiTL+Zl/fAIuCnksEvSYSk1W8ndpZGlY0 3Z8iNPgWppeAXZCbayuuXmh3t7PuJQ2bCYOSx7eTP2mvCeT387672ymBQ PJeTCaH6iad9jaRfPi8N57OS40qiCLkVjXEDh/vj6BKxSYZvv+8PuJxav D8hXulxfsN56znX+9K7zqtgvDCe9tWa3TazSui9bkNG8nKz2oA0tDj7Nf c2lP6xtgSP5u648EixLgjlG7gHeG6cCfGaLYw2VWmJpVq6KDDyTEdYQ0T w==; X-CSE-ConnectionGUID: dHA8hGtdTh+SAW7B2LypOA== X-CSE-MsgGUID: AS7ViU6ZRECGw9KBOLZ43Q== X-IronPort-AV: E=McAfee;i="6600,9927,11094"; a="14147841" X-IronPort-AV: E=Sophos;i="6.08,218,1712646000"; d="scan'208";a="14147841" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 00:21:14 -0700 X-CSE-ConnectionGUID: v/EJ7GX4RJOkNXeZvA21Fg== X-CSE-MsgGUID: dO3Tae8ZQJKIx4SLwrVfQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,218,1712646000"; d="scan'208";a="42794382" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.246.9]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 00:21:10 -0700 From: Jani Nikula To: Chris Bainbridge , kernel test robot Cc: Mario Limonciello , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, hughsient@gmail.com Subject: Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240528210319.1242-1-mario.limonciello@amd.com> <202406040928.Eu1gRIWv-lkp@intel.com> Date: Thu, 06 Jun 2024 10:21:07 +0300 Message-ID: <87h6e6bkpo.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, 05 Jun 2024, Chris Bainbridge wrote: > On Tue, Jun 04, 2024 at 10:02:29AM +0800, kernel test robot wrote: >> Hi Mario, >> >> kernel test robot noticed the following build errors: >> >> [auto build test ERROR on drm-misc/drm-misc-next] >> [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.10-rc2 next-20240603] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/drm-client-Detect-when-ACPI-lid-is-closed-during-initialization/20240529-050440 >> base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next >> patch link: https://lore.kernel.org/r/20240528210319.1242-1-mario.limonciello%40amd.com >> patch subject: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization >> config: i386-randconfig-053-20240604 (https://download.01.org/0day-ci/archive/20240604/202406040928.Eu1gRIWv-lkp@intel.com/config) >> compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240604/202406040928.Eu1gRIWv-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202406040928.Eu1gRIWv-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >> ld: drivers/gpu/drm/drm_client_modeset.o: in function `drm_client_match_edp_lid': >> >> drivers/gpu/drm/drm_client_modeset.c:281:(.text+0x221b): undefined reference to `acpi_lid_open' >> >> >> vim +281 drivers/gpu/drm/drm_client_modeset.c >> >> 260 >> 261 static void drm_client_match_edp_lid(struct drm_device *dev, >> 262 struct drm_connector **connectors, >> 263 unsigned int connector_count, >> 264 bool *enabled) >> 265 { >> 266 int i; >> 267 >> 268 for (i = 0; i < connector_count; i++) { >> 269 struct drm_connector *connector = connectors[i]; >> 270 >> 271 switch (connector->connector_type) { >> 272 case DRM_MODE_CONNECTOR_LVDS: >> 273 case DRM_MODE_CONNECTOR_eDP: >> 274 if (!enabled[i]) >> 275 continue; >> 276 break; >> 277 default: >> 278 continue; >> 279 } >> 280 >> > 281 if (!acpi_lid_open()) { >> 282 drm_dbg_kms(dev, "[CONNECTOR:%d:%s] lid is closed, disabling\n", >> 283 connector->base.id, connector->name); >> 284 enabled[i] = false; >> 285 } >> 286 } >> 287 } >> 288 >> >> -- >> 0-DAY CI Kernel Test Service >> https://github.com/intel/lkp-tests/wiki > > The failed config has CONFIG_ACPI_BUTTON=m. The build failure can be > fixed with: > > diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c > index b76438c31761..0271e66f44f8 100644 > --- a/drivers/gpu/drm/drm_client_modeset.c > +++ b/drivers/gpu/drm/drm_client_modeset.c > @@ -271,11 +271,13 @@ static void drm_client_match_edp_lid(struct drm_device *dev, > if (connector->connector_type != DRM_MODE_CONNECTOR_eDP || !enabled[i]) > continue; > > +#if defined(CONFIG_ACPI_BUTTON) > if (!acpi_lid_open()) { > drm_dbg_kms(dev, "[CONNECTOR:%d:%s] lid is closed, disabling\n", > connector->base.id, connector->name); > enabled[i] = false; > } > +#endif > } > } No. This is because CONFIG_DRM=y CONFIG_ACPI_BUTTON=m The pedantically correct fix is probably having DRM depends on ACPI_BUTTON || ACPI_BUTTON=n but seeing how i915 and xe just select ACPI_BUTTON if ACPI and nouveau basically uses acpi_lid_open() it if it's reachable with no regard to kconfig, it's anyone's guess what will work. BR, Jani. -- Jani Nikula, Intel