Re: [PATCH v2 13/14] drm/amd/display: add drm_edid to dc_sink

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 06 May 2025, Melissa Wen <mwen@igalia.com> wrote:
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index c93e074ea736..54f6ed33e373 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -46,6 +46,8 @@
>  
>  #include "dmub/inc/dmub_cmd.h"
>  
> +#include <drm/drm_edid.h>
> +

Completely up to AMD maintainers, but in code I maintain I'd request
using a forward declaration instead of an include if you only need a
struct pointer. The header interdependencies just add up.

BR,
Jani.

>  struct abm_save_restore;
>  
>  /* forward declaration */
> @@ -2433,6 +2435,7 @@ struct scdc_caps {
>  struct dc_sink {
>  	enum signal_type sink_signal;
>  	struct dc_edid dc_edid; /* raw edid */
> +	const struct drm_edid *drm_edid; /* Linux DRM edid*/
>  	struct dc_edid_caps edid_caps; /* parse display caps */
>  	struct dc_container_id *dc_container_id;
>  	uint32_t dongle_max_pix_clk;

-- 
Jani Nikula, Intel