From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6EDFCD3420 for ; Tue, 3 Sep 2024 10:42:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D177710E3E2; Tue, 3 Sep 2024 10:42:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Y5Eh1R5n"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F9ED10E3B9 for ; Tue, 3 Sep 2024 10:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725360126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6lwmVfPx2sszsBri4TFoZL/uMUGIYxHzznRQSGZUMD4=; b=Y5Eh1R5nmsBJnrLN5glqpjT6FDg1jkPOTBlGqr98uWX38Ll2zoyRmAFOdG0hvhyLP2i7CG lF26Gi8HCIezZ03HY0JGReTZq2mz/a8/JG1/jszY99VEMKwGSVF9Po03QxpPkb3l7oY2Wx hWiiNxKvzhxxddOfOy1Qvk7k/oQ7bLM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-RN9E_XZkM_aZH1qcnKMZqg-1; Tue, 03 Sep 2024 06:42:03 -0400 X-MC-Unique: RN9E_XZkM_aZH1qcnKMZqg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-374c9b0daf3so1263614f8f.1 for ; Tue, 03 Sep 2024 03:42:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725360122; x=1725964922; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6lwmVfPx2sszsBri4TFoZL/uMUGIYxHzznRQSGZUMD4=; b=egRbqnBCN3VTAgBRhxOpRcBZMmtGqvKvlMACQHe9v7ej17vkLeeVNr6QNKJbVoVvgj 2zerZyAzZSbrRrNKyD79CBamr/1EYx686JY0oHSHBDdDY+JHOplPKvdBLKfMs7BZqc3O PkAoAkW1+V93DJ7/Qzbqg9e4n5kq3gRgcsjfpOkDxxKW0bHItLIV1t/ggNT84TUp9Yg/ qMwvf0FjrLRlLJiosZZ8iacdayGl0dK5EWMaNHpK2iqEYNINIQ+7nprrvkADwVTF8js2 d3oKUqxoS24/pUhloYEQoFfQaeOAgVoj6oAUrC8JdP0MCrqidRgCQ/tEWfGwNHjKMOZd fyAQ== X-Forwarded-Encrypted: i=1; AJvYcCUQI9d7sJfVkzOkmJzmjGs9w3Qof5vSCn9cIu6rxXL/d3CSfv+iXtpeGFn8AtD03DaR1lDF8xvN@lists.freedesktop.org X-Gm-Message-State: AOJu0YxoeYRJ0+amrrtXAxyhCNl8TGhozgHqioFkxv+3SQ1vGoTG1AZm 07wemv1vzNtFV+4qNX3gWS9p8AnUK43XBV4aE6ikvm1BiNuWB48HYKB3IsJ0nxCjVqvpgrtmcrl x38RpcDMJH2bYK1rX+D3aZpKgN32T9uvzVw4vrQbXbO9POXRYyjdpcrcEcyng1rk= X-Received: by 2002:a05:6000:18a7:b0:376:7a68:bc42 with SMTP id ffacd0b85a97d-3767a68c23dmr1148284f8f.27.1725360122021; Tue, 03 Sep 2024 03:42:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHn4YS9bNBLLWoNJTDrRNeKzv2DqbtrI+GY2Fyjm7bbAi6bx9DMubdkqlGYZw08xR/rtbBxWw== X-Received: by 2002:a05:6000:18a7:b0:376:7a68:bc42 with SMTP id ffacd0b85a97d-3767a68c23dmr1148260f8f.27.1725360121455; Tue, 03 Sep 2024 03:42:01 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df0a0asm167347215e9.13.2024.09.03.03.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 03:42:01 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Thomas Zimmermann Subject: Re: [PATCH v3 03/81] drm/fbdev: Add memory-agnostic fbdev client In-Reply-To: <20240830084456.77630-4-tzimmermann@suse.de> References: <20240830084456.77630-1-tzimmermann@suse.de> <20240830084456.77630-4-tzimmermann@suse.de> Date: Tue, 03 Sep 2024 12:42:00 +0200 Message-ID: <87jzftggsn.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Thomas Zimmermann writes: > Add an fbdev client that can work with any memory manager. The > client implementation is the same as existing code in fbdev-dma or > fbdev-shmem. > > Provide struct drm_driver.fbdev_probe for the new client to allocate > the surface GEM buffer. The new callback replaces fb_probe of struct > drm_fb_helper_funcs, which does the same. > > To use the new client, DRM drivers set fbdev_probe in their struct > drm_driver instance and call drm_fbdev_client_setup(). Probing and > creating the fbdev surface buffer is now independent from the other > operations in struct drm_fb_helper. For the pixel format, the fbdev > client either uses a specified format, the value in preferred_depth > or 32-bit RGB. > > v2: > - test for struct drm_fb_helper.funcs for NULL (Sui) > - respect struct drm_mode_config.preferred_depth for default format > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat