From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 902EFC25B79 for ; Fri, 24 May 2024 09:16:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E85D610E480; Fri, 24 May 2024 09:16:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gqmjQdFe"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95B3A89289; Fri, 24 May 2024 09:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716541504; x=1748077504; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=QknNTek5hZ/unaPk2F7O7L5h7E+LUgaHwteegjzsQD8=; b=gqmjQdFeaDkLF+AbamwOsofyYMoQNlXfro/MZCUohP3jixgpWgp1X4Ea ey6Ba0j302dn36zzRxQEJu5Jbf+EY9uURSY2Or7Y+7b8XIClw2XY5gWhb LAxPNU8wWFGScSQGPs0vPAyYGF8S0a10hdL/q66OMYB7X0hTcqkSjFFsy NdJ3BT/UpZudApMPAr1IwOZQ7L2S/dE0EBOFdPSkZlKxF1bVhRlWwN9wl z9qysk0VZp531DBofKhD7J0jD7YqrX+mWST81MAi9Lpe1h2fc5BO4+Wbg HWyaMCPq3SAezTcjDy1dR/gmbeBCQ20k7R8q5v2VFfqqNK/3wBowCfnGz g==; X-CSE-ConnectionGUID: ///fmO5jR9iJBayK+0Mkaw== X-CSE-MsgGUID: BXYo/ilBSjqX0RCmE/LBJg== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="16736924" X-IronPort-AV: E=Sophos;i="6.08,185,1712646000"; d="scan'208";a="16736924" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 02:05:03 -0700 X-CSE-ConnectionGUID: owI/ScNCSAe5LggpAUHqFQ== X-CSE-MsgGUID: tjoMYhfrTG2Ja7PoLqmA8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,185,1712646000"; d="scan'208";a="34067922" Received: from bergbenj-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.108]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 02:04:59 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Subject: Re: [PATCH 3/4] drm/imx: fix -Wformat-truncation warning in imx_ldb_probe() In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Fri, 24 May 2024 12:04:56 +0300 Message-ID: <87jzjjoa13.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 24 May 2024 09:16:14 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, 23 May 2024, Ville Syrj=C3=A4l=C3=A4 wrote: > On Thu, May 23, 2024 at 06:51:08PM +0300, Jani Nikula wrote: >> Enabling -Wformat-truncation yields the following warning: >>=20 >> ../drivers/gpu/drm/imx/ipuv3/imx-ldb.c: In function =E2=80=98imx_ldb_pro= be=E2=80=99: >> ../drivers/gpu/drm/imx/ipuv3/imx-ldb.c:658:57: error: =E2=80=98_sel=E2= =80=99 directive output may be truncated writing 4 bytes into a region of s= ize between 3 and 13 [-Werror=3Dformat-truncation=3D] >> 658 | snprintf(clkname, sizeof(clkname), "di%d_sel", i= ); >> | ^~~~ >> ../drivers/gpu/drm/imx/ipuv3/imx-ldb.c:658:17: note: =E2=80=98snprintf= =E2=80=99 output between 8 and 18 bytes into a destination of size 16 >> 658 | snprintf(clkname, sizeof(clkname), "di%d_sel", i= ); >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > If only the compiler could count to three... I did not try, but apparently using %hhd would hide the issue too: snprintf(clkname, sizeof(clkname), "di%hhd_sel", i); BR, Jani. > >>=20 >> Silence the warning by checking the snprintf() return value. >>=20 >> Signed-off-by: Jani Nikula >>=20 >> --- >>=20 >> Cc: Philipp Zabel >> Cc: Shawn Guo >> Cc: Sascha Hauer >> Cc: Pengutronix Kernel Team >> Cc: Fabio Estevam >> Cc: dri-devel@lists.freedesktop.org >> Cc: imx@lists.linux.dev >> --- >> drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >>=20 >> diff --git a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c b/drivers/gpu/drm/imx/i= puv3/imx-ldb.c >> index 71d70194fcbd..46f779fe60ee 100644 >> --- a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c >> +++ b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c >> @@ -654,8 +654,12 @@ static int imx_ldb_probe(struct platform_device *pd= ev) >> */ >> for (i =3D 0; i < 4; i++) { >> char clkname[16]; >> + int len; >> + >> + len =3D snprintf(clkname, sizeof(clkname), "di%d_sel", i); >> + if (len >=3D sizeof(clkname)) >> + dev_err(dev, "clkname truncated\n"); >>=20=20 >> - snprintf(clkname, sizeof(clkname), "di%d_sel", i); >> imx_ldb->clk_sel[i] =3D devm_clk_get(imx_ldb->dev, clkname); >> if (IS_ERR(imx_ldb->clk_sel[i])) { >> ret =3D PTR_ERR(imx_ldb->clk_sel[i]); >> --=20 >> 2.39.2 --=20 Jani Nikula, Intel