From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CEB3CD13CF for ; Tue, 3 Sep 2024 12:22:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C986110E574; Tue, 3 Sep 2024 12:22:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Q2pCAFLH"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0463F10E576 for ; Tue, 3 Sep 2024 12:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725366165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0J18mFtPW85AHtY7ZOej0CYOhen09AyMbJhKjs06Zig=; b=Q2pCAFLHurXFyLPk0fEuTirB6wO6idsJ7N4usy3MBL+8BzSAn9BMgSTzAUztUE7NXOeQdW WUa7zqL+vGw3RoajSIXeniy16GN3TZuikzZxU+FCRFWJdrewA6N/LbzRcPgip6L5Y6Js2j TLMfQryFS6iNzT8dL4OH/8EJkwM+RfE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-X3x3ndeuNSi1I8L13OE_gQ-1; Tue, 03 Sep 2024 08:22:44 -0400 X-MC-Unique: X3x3ndeuNSi1I8L13OE_gQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-374ba33b2d2so2365416f8f.2 for ; Tue, 03 Sep 2024 05:22:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725366163; x=1725970963; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0J18mFtPW85AHtY7ZOej0CYOhen09AyMbJhKjs06Zig=; b=l0sanYOt1E96ddJQ2HHMxUNgJNfXDuikdlTm5/mZ9u3sk4L8QLvOFUdcZpQDjqHFU4 5YR3nC7BGPu9xXfjd6LIbDoIrD6L5L4QyQHZR1aeXkGrM3b7CUMqIyVtsYbSdilst++y WqM11TloKsKwcPsf3NfRAqxQuOghte0cyKClYSJqzd20GpvPaxGBJzbamlrmXhdQkqLO CbCf0sImHAYOwSTFvfnbltvtKskyZbZxdNA5TxFl8NnfseIaxUSbWk9tk5zgqOdwX+G0 iFWeMKzVnkgHNr88QA0HeyB7vXFRQD66a3xtsL0WLHxDzlFfozeEw/5tF4z5xsoGVchh Eq9A== X-Forwarded-Encrypted: i=1; AJvYcCUGEDnSBY/8yGRTTr8xC0MMR97GwbWD2ZRhTTAvCfGUo4MCWGVfwDtXx6If2MLMMMrpSUtqqT78@lists.freedesktop.org X-Gm-Message-State: AOJu0YyvCkW5NN00a88EQESjFXYFy+GCAR2ZxAdnWdHnOTcTGCj9k8tx a4joq6kuWun5oAklh0iHRN1hFAgOuyL0/R7fQ/POvaq08eSY2XLBnTOZwkF9tpoZOhAdYtqHX6D nd8/kITCrEPC/Nf5PgL5bMM+YzHY+5rzB/ATmN62K0KCD4YCcwnLdepN4ncoizjM= X-Received: by 2002:a5d:69d0:0:b0:374:c50e:377b with SMTP id ffacd0b85a97d-374fa04bda4mr1738356f8f.57.1725366162733; Tue, 03 Sep 2024 05:22:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4S4eih2N9VBmWhzMozSzK8e8m/fVAd05vFao5JLuB0ET5xeJ36/8k/lqNYcQmxehh1CNfiA== X-Received: by 2002:a5d:69d0:0:b0:374:c50e:377b with SMTP id ffacd0b85a97d-374fa04bda4mr1738344f8f.57.1725366162260; Tue, 03 Sep 2024 05:22:42 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42c819e356asm82859735e9.42.2024.09.03.05.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 05:22:42 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Thomas Zimmermann , Tomi Valkeinen Subject: Re: [PATCH v3 81/81] drm/omapdrm: Run DRM default client setup In-Reply-To: <20240830084456.77630-82-tzimmermann@suse.de> References: <20240830084456.77630-1-tzimmermann@suse.de> <20240830084456.77630-82-tzimmermann@suse.de> Date: Tue, 03 Sep 2024 14:22:41 +0200 Message-ID: <87zfopapv2.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The omapdrm driver specifies a preferred color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 1 + > drivers/gpu/drm/omapdrm/omap_fbdev.c | 131 ++++++--------------------- > drivers/gpu/drm/omapdrm/omap_fbdev.h | 8 ++ > 3 files changed, 38 insertions(+), 102 deletions(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat