From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Subject: Re: [Updated PATCH v2] drm: modify drm_global_item_ref to avoid two
 times of writing ref->object
Date: Wed, 7 Sep 2016 10:02:47 +0200
Message-ID: <8e0116fa-6f4c-ea4f-5e59-73cb98a543bf@amd.com>
References: <1473225871-2847-1-git-send-email-ray.huang@amd.com>
 <88949438-6e9e-502c-a543-9ca374411b1c@amd.com>
 <20160907075435.GA13516@hr-amur2>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20160907075435.GA13516@hr-amur2>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Huang Rui <ray.huang@amd.com>, Sean Paul <seanpaul@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher <alexander.deucher@amd.com>, Ken Wang <Qingqing.Wang@amd.com>
List-Id: amd-gfx.lists.freedesktop.org

QW0gMDcuMDkuMjAxNiB1bSAwOTo1NCBzY2hyaWViIEh1YW5nIFJ1aToKPiBPbiBXZWQsIFNlcCAw
NywgMjAxNiBhdCAwOToxMjoyOUFNICswMjAwLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+PiBB
bSAwNy4wOS4yMDE2IHVtIDA3OjI0IHNjaHJpZWIgSHVhbmcgUnVpOgo+Pj4gSW4gcHJldmlvdXMg
ZHJtX2dsb2JhbF9pdGVtX3JlZiwgdGhlcmUgYXJlIHR3byB0aW1lcyBvZiB3cml0aW5nCj4+PiBy
ZWYtPm9iamVjdCBpZiBpdGVtLT5yZWZjb3VudCBpcyAwLiBTbyB0aGlzIHBhdGNoIGRvZXMgYSBt
aW5vciB1cGRhdGUKPj4+IHRvIHB1dCBhbGxvYyBhbmQgaW5pdCByZWYgZmlyc3RseSwgYW5kIHRo
ZW4gdG8gbW9kaWZ5IHRoZSBpdGVtIG9mIGdsb2IKPj4+IGFycmF5LiBVc2UgImVsc2UiIHRvIGF2
b2lkIHR3byB0aW1lcyBvZiB3cml0aW5nIHJlZi0+b2JqZWN0LiBJdCBjYW4KPj4+IG1ha2UgdGhl
IGNvZGUgbG9naWMgbW9yZSBjbGVhcmx5Lgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEh1YW5nIFJ1
aSA8cmF5Lmh1YW5nQGFtZC5jb20+Cj4+IFdlbGwgd2hlbiB5b3UgdXBkYXRlIHlvdXIgcGF0Y2gs
IGV2ZW4gd2hlbiBpdCdzIGp1c3QgZml4aW5nIGEgc21hbGwKPj4gdHlwbywgcGxlYXNlIGluY3Jl
YXNlIHRoZSB2ZXJzaW9uIG51bWJlci4KPj4KPj4gVGhhdCBtYWtlcyBpdCBtdWNoIGVhc2llciB0
byB0cmFjayB0aGUgZGlmZmVyZW50IGluc3RhbmNlcyBvZiBhIHBhdGNoLgo+Pgo+IE9LLgo+Cj4+
IEEgZmV3IGFkZGl0aW9uYWwgbm90ZXMgYmVsb3cuCj4+Cj4+PiAtLS0KPj4+Cj4+PiBDaGFuZ2Vz
IGZyb20gVjEgLT4gVjI6Cj4+PiAtIEFkZCBrZnJlZSBleGNlcHRpb25hbCBoYW5kbGUgdG8gYXZv
aWQgbWVtb3J5IGxlYWsuCj4+PiAtIEltcHJvdmUgY29kZSBzdHlsZS4KPj4+Cj4+PiAtLS0KPj4+
ICAgZHJpdmVycy9ncHUvZHJtL2RybV9nbG9iYWwuYyB8IDIzICsrKysrKysrKysrKystLS0tLS0t
LS0tCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMo
LSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9nbG9iYWwuYyBiL2Ry
aXZlcnMvZ3B1L2RybS9kcm1fZ2xvYmFsLmMKPj4+IGluZGV4IDNkMmU5MWMuLmIxODFlODEgMTAw
NjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dsb2JhbC5jCj4+PiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vZHJtX2dsb2JhbC5jCj4+PiBAQCAtNjUsMzAgKzY1LDMzIEBAIHZvaWQgZHJt
X2dsb2JhbF9yZWxlYXNlKHZvaWQpCj4+PiAgIGludCBkcm1fZ2xvYmFsX2l0ZW1fcmVmKHN0cnVj
dCBkcm1fZ2xvYmFsX3JlZmVyZW5jZSAqcmVmKQo+Pj4gICB7Cj4+PiAtCWludCByZXQ7Cj4+PiAr
CWludCByZXQgPSAwOwo+Pj4gICAJc3RydWN0IGRybV9nbG9iYWxfaXRlbSAqaXRlbSA9ICZnbG9i
W3JlZi0+Z2xvYmFsX3R5cGVdOwo+Pj4gICAJbXV0ZXhfbG9jaygmaXRlbS0+bXV0ZXgpOwo+Pj4g
ICAJaWYgKGl0ZW0tPnJlZmNvdW50ID09IDApIHsKPj4+IC0JCWl0ZW0tPm9iamVjdCA9IGt6YWxs
b2MocmVmLT5zaXplLCBHRlBfS0VSTkVMKTsKPj4+IC0JCWlmICh1bmxpa2VseShpdGVtLT5vYmpl
Y3QgPT0gTlVMTCkpIHsKPj4+ICsJCXJlZi0+b2JqZWN0ID0ga3phbGxvYyhyZWYtPnNpemUsIEdG
UF9LRVJORUwpOwo+Pj4gKwkJaWYgKHVubGlrZWx5KHJlZi0+b2JqZWN0ID09IE5VTEwpKSB7Cj4+
PiAgIAkJCXJldCA9IC1FTk9NRU07Cj4+PiAtCQkJZ290byBvdXRfZXJyOwo+Pj4gKwkJCWdvdG8g
b3V0Owo+Pj4gICAJCX0KPj4+IC0KPj4+IC0JCXJlZi0+b2JqZWN0ID0gaXRlbS0+b2JqZWN0Owo+
Pj4gICAJCXJldCA9IHJlZi0+aW5pdChyZWYpOwo+Pj4gICAJCWlmICh1bmxpa2VseShyZXQgIT0g
MCkpCj4+PiAgIAkJCWdvdG8gb3V0X2VycjsKPj4+ICsJCWl0ZW0tPm9iamVjdCA9IHJlZi0+b2Jq
ZWN0Owo+Pj4gKwl9IGVsc2Ugewo+Pj4gKwkJcmVmLT5vYmplY3QgPSBpdGVtLT5vYmplY3Q7Cj4+
PiAgIAl9Cj4+PiArCj4+PiAgIAkrK2l0ZW0tPnJlZmNvdW50Owo+Pj4gLQlyZWYtPm9iamVjdCA9
IGl0ZW0tPm9iamVjdDsKPj4+IC0JbXV0ZXhfdW5sb2NrKCZpdGVtLT5tdXRleCk7Cj4+PiAtCXJl
dHVybiAwOwo+Pj4gKwlnb3RvIG91dDsKPj4gQSBnb3RvIGluIHRoZSBub3QgZXJyb3IgcGF0aCBp
cyBhIGJpdCB1bnVzdWFsLiBTaW5jZSBvdXRfZXJyIGlzIG9ubHkKPj4gdXNlZCBvbmNlIGNvdWxk
bid0IHlvdSBqdXN0IG1vdmUgdGhlIGNvZGUgaW50byB0aGUgaWYgYW5kIHRoZW4gZ290bwo+PiB0
byBvdXQgYXMgd2VsbD8KPj4KPj4gQWx0ZXJuYXRpdmUgeW91IGNvdWxkIGp1c3QgZHVwbGljYXRl
IHRoZSBtdXRleCByZWxlYXNlIGluIHRoZQo+PiBub24tZXJyb3IgcGF0aC4KPj4KPiBBY3R1YWxs
eSwgSSBhbHNvIGhhdmUgYSBsaXR0bGUgY29uY2VybiB3aXRoICJnb3RvIiBpbiBub24tZXJyb3Ig
cGF0aC4gQnV0Cj4gYXMgU2VhbidzIHN1Z2dlc3Rpb24sIHVzZSAiZ290byIgY2FuIGF2b2lkIGEg
ZHVwbGljYXRlIG11dGV4IHJlbGVhc2UsIHlvdQo+IGtub3cuCgpJIHdvdWxkIGNlcnRhaW5seSBw
cmVmZXIgdGhlIGR1cGxpY2F0ZSBtdXRleCByZWxlYXNlLgoKPgo+IEBTZWFuLCBpZiB5b3UgZG9u
J3QgaGF2ZSBjb25jZXJuIHdpdGggYWRkaW5nIGEgbXV0ZXggcmVsZWFzZSBiZWxvdywgSSB3aWxs
Cj4gdXBkYXRlIGl0IGluIFYzLgo+Cj4gLS0tCj4gICAgICAgICAgKytpdGVtLT5yZWZjb3VudDsK
PiAgICAgICAgICBtdXRleF91bmxvY2soJml0ZW0tPm11dGV4KTsKPiAgICAgICAgICByZXR1cm4g
MDsKPgo+IG91dF9lcnI6Cj4gICAgICAgICAga2ZyZWUocmVmLT5vYmplY3QpOwo+ICAgICAgICAg
IHJlZi0+b2JqZWN0ID0gTlVMTDsKPiBvdXQ6CgpCVFc6IEkgd291bGQgbmFtZSB0aG9zZSBsYWJl
bHMgZXJyb3JfZnJlZSBhbmQgZXJyb3JfdW5sb2NrIHRvIG1ha2UgY2xlYXIgCnRoYXQgdGhleSBh
cmUgZm9yIGVycm9yIGhhbmRsaW5nIGFuZCB3aGF0IHRoZXkgYXJlIHN1cHBvc2VkIHRvIGRvLgoK
UmVnYXJkcywKQ2hyaXN0aWFuLgoKPiAgICAgICAgICBtdXRleF91bmxvY2soJml0ZW0tPm11dGV4
KTsKPiAgICAgICAgICByZXR1cm4gcmV0Owo+IC0tLQo+Cj4KPiBUaGFua3MsCj4gUnVpCgoKX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h
aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==