Re: [PATCH v2] drm/ttm: Should to return the evict error

["Chen, Xiaogang" <xiaogang.chen@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]


On 5/21/2025 9:42 PM, Deng, Emily wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Ping......
>
> Emily Deng
> Best Wishes
>
>
>
>> -----Original Message-----
>> From: Emily Deng<Emily.Deng@amd.com>
>> Sent: Wednesday, May 21, 2025 11:57 AM
>> To:amd-gfx@lists.freedesktop.org
>> Cc: Deng, Emily<Emily.Deng@amd.com>
>> Subject: [PATCH v2] drm/ttm: Should to return the evict error
>>
>> For the evict fail case, the evict error should be returned.
>>
>> v2: Consider ENOENT case.
>>
>> Signed-off-by: Emily Deng<Emily.Deng@amd.com>
>> ---
>> drivers/gpu/drm/ttm/ttm_resource.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
>> index 097716bd248a..abf104ae9d35 100644
>> --- a/drivers/gpu/drm/ttm/ttm_resource.c
>> +++ b/drivers/gpu/drm/ttm/ttm_resource.c
>> @@ -511,12 +511,12 @@ int ttm_resource_manager_evict_all(struct ttm_device
>> *bdev,
>>                .force_alloc = true
>>        };
>>        struct dma_fence *fence;
>> -      int ret;
>> +      int ret, evict_ret = 0;
>>
>>        do {
>> -              ret = ttm_bo_evict_first(bdev, man, &ctx);
>> +              evict_ret = ttm_bo_evict_first(bdev, man, &ctx);
>>                cond_resched();
>> -      } while (!ret);
>> +      } while (!evict_ret);
>>
>>        spin_lock(&man->move_lock);
>>        fence = dma_fence_get(man->move);
>> @@ -529,7 +529,7 @@ int ttm_resource_manager_evict_all(struct ttm_device *bdev,
>>                        return ret;
>>        }
>>
>> -      return 0;
>> +      return (evict_ret == -ENOENT) ? 0 : evict_ret;
>> }

Can you explain why you care ENOENT(No such file or directory) specifically?

Regards

Xiaogang

>> EXPORT_SYMBOL(ttm_resource_manager_evict_all);
>>
>> --
>> 2.34.1

[-- Attachment #2: Type: text/html, Size: 2921 bytes --]