From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62525CCD19F for ; Mon, 20 Oct 2025 17:29:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 07B3C10E4A0; Mon, 20 Oct 2025 17:29:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="agVdwunP"; dkim-atps=neutral Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010068.outbound.protection.outlook.com [52.101.46.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2BF510E4AA for ; Mon, 20 Oct 2025 17:29:23 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sbC1ySHqVEhD3i7LP2WnjgdA1hLz43rgO0bVBz0aSQJ9JFs3fIKsrBWN6m1US0V+Pd+81zyXivatIGtD9sNAXGtfLUnXNvL7LPhf1kxn53fgIDYrWwCe5ZxO/0wN4zUAiQEGzi28+zeFRdxBcYjpJVzvyIYCPYUQKUb+ZTNGlWIiEkulOVDYerCeCrTqXM4kRV7tiLFCLHZk/IR2QmRUelb6UQqJ14NzL/WcEua7FjdspiLHuGTngiTqPPMMGb3l5HXJJeD2jECSvN5SoLKGxAzxDHTEAQEaaVZc3yMqJv6NrakDBKg0pIDv12MDr/YcpLWu0jBrOo3vFhulDm48oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LoBhblmkVIN/z1DkhfeuHvFQ0gC6M7Pv43iWVrrbAVk=; b=sldarHsyvm/j1Qwva6a0mWgoEq8hhlF+97md9+VQSc+OBlwrqlXzSQcIn2yKlCezm2wfGjUQGzPrR/N1Vnyqw6Zpd/MueYtGbC1y83YsrWal7aiVZFisxH4Rh52SLHk4XL8Q4EchJPXAnW/r6/jnqLvMdeLBIKmCOgrgtzHgFPLNYaveqLEELmXR9G5Xte6WWllbcFkUcYo+WCQkw+kyMSNn7gxiBgrQYzH+jqNkcHdwv79GVb9SPPUHnKzPYIyodC9bXSH6MFswayAzPNOp70zBHAMTaPkDKBkRVhLNgLVLSI8Y6tS03IFwD3uy1giKRTBdXxS0MmvgwfA0SPsUFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LoBhblmkVIN/z1DkhfeuHvFQ0gC6M7Pv43iWVrrbAVk=; b=agVdwunP4PQL6LgaO76RgPZZqMPcdoX4dSTAkBu1qf0MSIuAOy39asxSVWIsuDKWnBr94ZqjQGSvA2f4L/89pqKc4RMA2Jb8JWarvqR/nljjB6VJsr09GapSumyUKE3/nZOhfing6vfprw0LvmGRPxe68kKu8D/4z0NUOtvHLdQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) by DM4PR12MB5818.namprd12.prod.outlook.com (2603:10b6:8:62::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.16; Mon, 20 Oct 2025 17:29:21 +0000 Received: from DM4PR12MB6566.namprd12.prod.outlook.com ([fe80::31b:5d31:8ba6:abd7]) by DM4PR12MB6566.namprd12.prod.outlook.com ([fe80::31b:5d31:8ba6:abd7%6]) with mapi id 15.20.9228.015; Mon, 20 Oct 2025 17:29:21 +0000 Content-Type: multipart/alternative; boundary="------------EzQq6wV9nZOXHVRivzrZxnB9" Message-ID: <97a3c5de-3a66-435e-8b4c-72c87473d88f@amd.com> Date: Mon, 20 Oct 2025 12:29:19 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] drm/amdkfd: Fix false positive queue buffer free warning To: Philip Yang , Philip Yang , amd-gfx@lists.freedesktop.org Cc: Felix.Kuehling@amd.com References: <20251020143016.23409-1-Philip.Yang@amd.com> <1d60c36a-523b-5bf0-bea9-7d5fbdecf93e@amd.com> Content-Language: en-US From: "Chen, Xiaogang" In-Reply-To: <1d60c36a-523b-5bf0-bea9-7d5fbdecf93e@amd.com> X-ClientProxiedBy: SA1PR03CA0003.namprd03.prod.outlook.com (2603:10b6:806:2d3::14) To DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6566:EE_|DM4PR12MB5818:EE_ X-MS-Office365-Filtering-Correlation-Id: d0f76686-5ac7-4c32-a102-08de0ffe34a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cnlZcGF0Z09xcmNaV3hwN0J2NWZ6YjVlSEhaRzMxS1RNWGVtaEN1R1B6QTk0?= =?utf-8?B?UXIyNlFWZDBJSm15dzRncHFOa0wvSTZSY3dibEtLejM0blJlSkw1Y2dUMlRx?= =?utf-8?B?eVZtNkc0amNkQ3ZhSkhUVXBrTC9SZGt1L3FucDlOeWNRZkRPcEpDam0rODNx?= =?utf-8?B?aXRSQi9QaHdHQTVjWXBYTE1LNldHSlVaVkNOUUduUnFBbEJ0QSttWkRWUWRL?= =?utf-8?B?L09xS1RVbzhrbGMwajNJTUl4Q0hqS0o4bDRIUTBaanV3TnJmemJSRERJSXNl?= =?utf-8?B?ckFOY0kvSXpOcU1HMXVUZ1Q2NjNTWHUvNTMzeERWcXhrYTB6Sjc2bVdZYXE4?= =?utf-8?B?dHFSSmJOMjl2Tm5ETVdlWVd5MngxU3U3YkdyYldlaGpobmdtL2JxWlNZWVEv?= =?utf-8?B?UUxiOVZGWFV3UTNSaTZFRXJ1b2ZzY2tzdnBvbE9QV1NnVWRqOE92U2NEdzZK?= =?utf-8?B?TmhOMU1FVnZoQ3lQZmpidUlaaVVzZU45c2x5TE9rOFFENVplNnR0VjFoRjJv?= =?utf-8?B?Z0c0bmEvQmVnQ1JVdjlOVjhla3BQbkdRWTZvN2d5bEI2T0JmRWx3ZERmNGc0?= =?utf-8?B?RVdacElYVEtzVGVxUTQzODI1Z3M1dU91UUlGTU5xUWM5aGc2aHY4Y0MzZFVw?= =?utf-8?B?TlI2Rnl3eTlQcUNpZitoazZJNXllcWJZeDFDeENwNlExNmtNdSszWVp5UE50?= =?utf-8?B?ZjkvMUlXNTJtN3RQdG1mUmI1SFdoN1dEU1VQUDJBN2YxZ2R4KzM5Nm9VVEdj?= =?utf-8?B?Y1FFTTNwdTJaTzBONHR0d2QrNFRPbTlESDc5eUEwbUgydmZtVDVMRGV4TXA2?= =?utf-8?B?ZktaMm96bzhJZ2RIMXJ2R055TTZwa0JsQlNsbHJLVmtOdll5alhmRytRUDZn?= =?utf-8?B?ZlcxM0FtdUVRMFBnblY0ci9zK20wYkgyeDlleXlXYWdzVTdhWUYrZDVBcnNz?= =?utf-8?B?YkRiODFha0RwMFkzc1ZZTHY5U09HQnBITFFGSWx0TG1FUGFhdVI5bE0vNTU0?= =?utf-8?B?N1hzRmJkUDdPV3oxdDBsREF4Ulg1ZXBrOUhUcHh3Z1kvTkJIUW1WdE5PcDFI?= =?utf-8?B?MTI3cEpVWk52QnUxcitWZDFXSWlQSTNlVEw4MFJwY1MybVBYaVZzTXRlamZO?= =?utf-8?B?Nk4zd0huak9FS29wNlVIQUMwaWxodGVGcWs2UThZbkw5UHB4eXVSOXFiSi9t?= =?utf-8?B?UnhHV1Jkc3I5NCtsKzNrdElseHZnbHJkaTRVdlpHTnlyV0FxR0xPWitTQzM0?= =?utf-8?B?V2tlSFErVmNId1hNLzczOFkwQVc4dDNCVURpWVEveElIVzc5QnE1OWVWQm84?= =?utf-8?B?c3htcVNlMVUyZUd6NlVZNnQ3bFFTZFpOZ0ZPU2s5dnMvQ3QvYVBUdllwYnhF?= =?utf-8?B?TFR6MVpCR1lZRjJ1VXAwRVpMajU3b3pFa05HQTlLbnc0LzV1bUptNXFJREtq?= =?utf-8?B?RXpEVXVuYnU0UkcrZThkVVp1OVl2d2k1RUdrbStITHpUZWZXTkp1aFFFbk9w?= =?utf-8?B?bncvQ2N5VUMvTzRRTlZJTG9DVWRMdFRTeXhadHUvZ0lpZk5LY2ZDY2l2V3Qy?= =?utf-8?B?SXc5YmkxTzNPRnpzQjJ4cmZqQTRBZHFhSlIrT05qd2lQQ0d3TnE4SThiVkV1?= =?utf-8?B?ak8yMW9JWVpUL1J2aEhYQm9JYjNFczhFVHp0ZHpGNWhmeno4S2IxaHlIVXBk?= =?utf-8?B?ak9FN2didzRqRmZoczlZVlZxN2pIYnB6endNc1pUQXMyLzhEYmxmbkJRZlhD?= =?utf-8?B?c0dJTFdUdmFTd01kNWhJODFTNFpEQzZOMjkydDdFbEZkUldhK2xqY1FRQXpq?= =?utf-8?B?blBOVEhjVm9GS1A0UlJ4WkdaMzNFMS9rZU5yQnEwdjlmMFpRZWdReTJUcnJZ?= =?utf-8?B?cXZ1ZENHNk8ycUIvWGdTazVpVG9xVisxaFBIeWV6K0taNmpzalZ1eGIyQzUy?= =?utf-8?Q?mjEoRzBo4nIPHycXw8f6JHNKNY5Q/MPz?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6566.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STI4RjdBWmFhNkh4OXJ3TzZLdFpwYWtGc3pQMlRQWUI1ZTNwYUxlWk9kdXJR?= =?utf-8?B?ZmJuN2NGVkU3ZFJQbGVOSGRoWG0rK0Fod08wSGhRelR3NnJ0bG9ILzBvblVr?= =?utf-8?B?UTNmdmVvc2J4U245cm5sQ0hBRnp6REpQUm9na2tUTWNqM0F6WHl6UHFsVncz?= =?utf-8?B?eG8wWFZCaHJibnNVUExPbGVQTWYrTzFQRGtQOGRYRmtFeEM1aVpsaGk2eVVi?= =?utf-8?B?WXZhMjRQY0NMaEIwbjFMdXMvT1p5UU5EQmdzU1ZlSmFzbzJ1aWxHSURQOXpk?= =?utf-8?B?bTR3ZFFRNzJzWndqYVNCV1k4ZllWUndtd2pmbldra20yM1d1azdRaW82Sngv?= =?utf-8?B?WmVVOFpjWlpqY1NBaHhLc2E3VEpNOEFvYW9NSmNiQ2Z5bjczUTZoM3VLVWZj?= =?utf-8?B?SEZ1MmNKZ0I4eVBIS0ZuUEV3OUd0WUtTUDE3LzQ0dTZSUXV0aEJ3S3FZam1L?= =?utf-8?B?ajA0VTY1bjVndlJqZW03L0JPYVZQSUdTd29JM3MxWk1TcGFrby9SYjRJbmVS?= =?utf-8?B?NWxJdEZFUmMwaFo5QTV6b3VIVUtjcDh5WE5OdUlDcnQ0VUJ4b0RVeUhXcnQ5?= =?utf-8?B?M2JzdFFvenN3NkR2SE5OcDM5M3FxdTlXbWhoZ09qenN0VlNVWVJ2Z2NLTVcy?= =?utf-8?B?S0R2Q1p5emlpUTEwU3lINHdSd3JpT3Q1WExPOEZGQVNFVm9ubDdlcDkzbFVK?= =?utf-8?B?eGVjcndRZjA2czFwVmVpVFFMb21JdDlFK3FKNTBtRWpXTmVBWEdXUUdLK1Qr?= =?utf-8?B?ZjJEdm9SUWkxZ2o3dlBGQUxvY0MzdkMrZXVYV3VMVnR4QWwwczBLT1BtY29U?= =?utf-8?B?VTlZYUhVU1lhZ2tJQzdaS29xeXVNV0VWaU45Y1FOb3VhK0I0U2phYTNLcXVI?= =?utf-8?B?Qmg0am1GamRxbGJLWmtDVmpTVkhYdld5QmVWbGVQRUhKTThmUHRSVUdLcFRj?= =?utf-8?B?V1pUZ0pPT0liSElMcUcvSE40bm9zRXhIaVNUUW52V0FYT0d1QmVhNzhwVlh2?= =?utf-8?B?OWV6Z04rUnFjaGJ2aG1abTErWWhtSlZ6dDN6MGZPNmd1UEJEald6V3c4Rmti?= =?utf-8?B?cU5NcktRK3o0RVhuTURKMWpKclRqUElvMTJLb0owdVpwWGx5MHB2cjRiM2xj?= =?utf-8?B?NFZXWmJjSWVZcTlyalRyUjVIVlVnZ1JYc1UvVFhpbzN1cyt3MGREeWUxcFhN?= =?utf-8?B?Z0hPeHBBNmNiVXNCNk9aVzNCVlYvdXUvenJNWnNGWHdjU0hQQkswRE9yZUlY?= =?utf-8?B?N1RwbGJFSjNVbmVuL3dvZytncEJQSGNWQXpFWE1uM1hLTm5kdmZXTG5YWW5V?= =?utf-8?B?Wk1KT1MwVCs2SUdERGt4dXgrVWVoeThDY3JPcWxKVEhjcWJ3bTZkd1h0QlFK?= =?utf-8?B?dkhYMjlVbHhramlBK1JHbEhYRFU1ajI3THo5L1diK3hFbHYrOURONkkrcnd0?= =?utf-8?B?MVoyOWxrU1hiOFc2TDVtNlppT3hYNmN3dGN3VFRhRG83emoxYVVsWnUza0pY?= =?utf-8?B?U2I3cm54VXlUTEtiRDhZM3lHbVNRN1Q4Y1p6TlVjeWtWdHNJWlVZWS9FN0ZU?= =?utf-8?B?TWVjamREblFHcFcrUlV4VWtBdnJDcVBsTExDU0loV3ZYZDRpclJ3QVdoeit2?= =?utf-8?B?a1dVcHBFcHdhNk5HRVVtdlF6SUlPUmFYTzVkc1M0SG9kb25TMnU2S2FSeFBE?= =?utf-8?B?dlA2ekFobXFtOUQ1eUYyVnkzTXNGUUV1ME94eTlWMnhTczlmckd5YWdCbVp5?= =?utf-8?B?ckliMTM2aGtnTm12Ykdqc25UNVhvbTRmV1VQYmpVVzlGZCtGS1hja3RlSmUz?= =?utf-8?B?U1VJT3Jsek5VZE1NQjY3RGMzd0dmV0IzMlR6eHQrMCtvY2h0UjdIa0o4UGFn?= =?utf-8?B?di9UY3ZXa1g1UTQ0aUc1YzJESExqcHlQZHZtQmMxOWVnL2pvd3ppMnFOaFNN?= =?utf-8?B?VjNPYm9uWnNOd1d5SXNiR05Ob2pZNXpQZGVVdjhxZi9LOXA3UDR5Y25nR1Jy?= =?utf-8?B?bG83bUVSSVhFbWhyaDdCYkovT3BWKzJwVDhoNlZ0cDJrWlVsMGFXOXB0eG11?= =?utf-8?B?UitpdGoyQWtFcy8vNDFweTRMZ0ZubUdjVVJ4V2FwNWlpMEtzYmxZZE9CM3RS?= =?utf-8?Q?CE0A=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0f76686-5ac7-4c32-a102-08de0ffe34a2 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6566.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2025 17:29:21.4829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2P6Ye/gvYkGPvZu7f8fBP9GRohsudD02i1SQB3ISQPv+7YFJCUQJboA6HZ7gW/rv X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5818 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --------------EzQq6wV9nZOXHVRivzrZxnB9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/20/2025 11:34 AM, Philip Yang wrote: > > On 2025-10-20 11:59, Chen, Xiaogang wrote: >> >> >> On 10/20/2025 9:30 AM, Philip Yang wrote: >>> Only show warning message if process mm is still alive when queue >>> buffer is freed. >>> >>> If kfd_lookup_process_by_mm return NULL, means the process is already >>> exited and mm is gone, it is fine to free queue buffer. >>> >>> Fixes: b049504e211e ("drm/amdkfd: Validate user queue svm memory >>> residency") >>> Signed-off-by: Philip Yang >>> --- >>>   drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +++-- >>>   1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c >>> b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c >>> index 4d4a47313f5b..d1b2f8525f80 100644 >>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c >>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c >>> @@ -2487,7 +2487,9 @@ svm_range_unmap_from_cpu(struct mm_struct *mm, >>> struct svm_range *prange, >>>       bool unmap_parent; >>>       uint32_t i; >>>   -    if (atomic_read(&prange->queue_refcount)) { >>> +    p = kfd_lookup_process_by_mm(mm); >> >> p->mm is null, not p  because driver set p->mm to null. But still >> prange->queue_refcount is ref of queues from this prange. If app >> unmap this prange app should have destroyed the queues associated >> with this prange already. If not, it is not driver issue. >> > right, we still pr_warn if app unmap the prange with queue_refcount > not zero, p is not NULL for this case. >> >> I think driver should send this warning anyway to indicate there are >> queues not destroyed by app before app unmap the prange. >> > if app killed or segmentation fault, mm is gone first, then queue is > destroyed in scheduled release wq, then exit_mmap unmap the prange > with queue_refcount not zero, p is NULL, should not pr_warn, because > warning message "Freeing queue vital buffer...." is not related to app > segmentation fault or killed. Then can we put pqm_uninit at kfd_process_notifier_release_internal as you did at second patch with kfd_process_dequeue_from_all_devices: destroy queue when mm is gone? And if this is for the cases "app got killed or segment fault" how important user should not see this warning message? Something was wrong already anyway. My thought is that prange->queue_refcount means queue number associated with prange. If it got unmap the queues should be destroyed already, if not, something was wrong somewhere, then need send this warning message. Regards Xiaogang > > Regards, > > Philip > >> It is an app race condition, not driver. >> >> Regards >> >> Xiaogang >> >>> + >>> +    if (p && atomic_read(&prange->queue_refcount)) { >>>           int r; >>>             pr_warn("Freeing queue vital buffer 0x%lx, queue >>> evicted\n", >>> @@ -2497,7 +2499,6 @@ svm_range_unmap_from_cpu(struct mm_struct *mm, >>> struct svm_range *prange, >>>               pr_debug("failed %d to quiesce KFD queues\n", r); >>>       } >>>   -    p = kfd_lookup_process_by_mm(mm); >>>       if (!p) >>>           return; >>>       svms = &p->svms; --------------EzQq6wV9nZOXHVRivzrZxnB9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 10/20/2025 11:34 AM, Philip Yang wrote:

On 2025-10-20 11:59, Chen, Xiaogang wrote:


On 10/20/2025 9:30 AM, Philip Yang wrote:
Only show warning message if process mm is still alive when queue
buffer is freed.

If kfd_lookup_process_by_mm return NULL, means the process is already
exited and mm is gone, it is fine to free queue buffer.

Fixes: b049504e211e ("drm/amdkfd: Validate user queue svm memory residency")
Signed-off-by: Philip Yang<Philip.Yang@amd.com>
---
  drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 4d4a47313f5b..d1b2f8525f80 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -2487,7 +2487,9 @@ svm_range_unmap_from_cpu(struct mm_struct *mm, struct svm_range *prange,
      bool unmap_parent;
      uint32_t i;
  -    if (atomic_read(&prange->queue_refcount)) {
+    p = kfd_lookup_process_by_mm(mm);

p->mm is null, not p  because driver set p->mm to null. But still prange->queue_refcount is ref of queues from this prange. If app unmap this prange app should have destroyed the queues associated with this prange already. If not, it is not driver issue.

right, we still pr_warn if app unmap the prange with queue_refcount not zero, p is not NULL for this case.

I think driver should send this warning anyway to indicate there are queues not destroyed by app before app unmap the prange.

if app killed or segmentation fault, mm is gone first, then queue is destroyed in scheduled release wq, then exit_mmap unmap the prange with queue_refcount not zero, p is NULL, should not pr_warn, because warning message "Freeing queue vital buffer...." is not related to app segmentation fault or killed. 

Then can we put pqm_uninit at kfd_process_notifier_release_internal as you did at second patch with kfd_process_dequeue_from_all_devices: destroy queue when mm is gone?


And if this is for the cases "app got killed or segment fault" how important user should not see this warning message? Something was wrong already anyway.

My thought is that prange->queue_refcount means queue number associated with prange. If it got unmap the queues should be destroyed already, if not, something was wrong somewhere, then need send this warning message.

Regards

Xiaogang


Regards,

Philip

It is an app race condition, not driver.

Regards

Xiaogang

+
+    if (p && atomic_read(&prange->queue_refcount)) {
          int r;
            pr_warn("Freeing queue vital buffer 0x%lx, queue evicted\n",
@@ -2497,7 +2499,6 @@ svm_range_unmap_from_cpu(struct mm_struct *mm, struct svm_range *prange,
              pr_debug("failed %d to quiesce KFD queues\n", r);
      }
  -    p = kfd_lookup_process_by_mm(mm);
      if (!p)
          return;
      svms = &p->svms;
--------------EzQq6wV9nZOXHVRivzrZxnB9--