From: "Wentland, Harry" <Harry.Wentland-5C7GfCeVMHo@public.gmane.org>
To: "Vishwakarma, Pratik" <Pratik.Vishwakarma-5C7GfCeVMHo@public.gmane.org>
Cc: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/display: fix compiler errors [-Werror,-Wparentheses-equality]
Date: Tue, 5 Feb 2019 14:43:15 +0000 [thread overview]
Message-ID: <989afa37-d307-8931-d228-e7666a2a5213@amd.com> (raw)
In-Reply-To: <20190204081546.24935-1-Pratik.Vishwakarma-5C7GfCeVMHo@public.gmane.org>
On 2019-02-04 3:16 a.m., Vishwakarma, Pratik wrote:
> Remove extraneous parentheses around the comparison
> to silence this warning
>
> Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c
> index 7d102ac0d61b..1ef0074302c5 100644
> --- a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c
> +++ b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c
> @@ -63,7 +63,7 @@ void scaler_settings_calculation(struct dcn_bw_internal_vars *v)
> if (v->interlace_output[k] == 1.0) {
> v->v_ratio[k] = 2.0 * v->v_ratio[k];
> }
> - if ((v->underscan_output[k] == 1.0)) {
> + if (v->underscan_output[k] == 1.0) {
> v->h_ratio[k] = v->h_ratio[k] * v->under_scan_factor;
> v->v_ratio[k] = v->v_ratio[k] * v->under_scan_factor;
> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-02-05 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 8:16 [PATCH] drm/amdgpu/display: fix compiler errors [-Werror,-Wparentheses-equality] Vishwakarma, Pratik
[not found] ` <20190204081546.24935-1-Pratik.Vishwakarma-5C7GfCeVMHo@public.gmane.org>
2019-02-05 14:43 ` Wentland, Harry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=989afa37-d307-8931-d228-e7666a2a5213@amd.com \
--to=harry.wentland-5c7gfcevmho@public.gmane.org \
--cc=Pratik.Vishwakarma-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox