Re: [PATCH 1/2] Revert "drm/amdgpu: don't attach the tlb fence for SI"

["Christian König" <christian.koenig@amd.com>]

On 1/9/26 09:25, Prike Liang wrote:
> This reverts commit 47d28900bc2049379b28656cf1e527aa8598925b.
> 
> It’s better to validate VM TLB flushes in the flush‑TLB backend
> rather than in the generic VM layer.
> 
> Signed-off-by: Prike Liang <Prike.Liang@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 0eccb31793ca..6a2ea200d90c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1069,9 +1069,7 @@ amdgpu_vm_tlb_flush(struct amdgpu_vm_update_params *params,
>  	}
>  
>  	/* Prepare a TLB flush fence to be attached to PTs */
> -	if (!params->unlocked &&
> -	    /* SI doesn't support pasid or KIQ/MES */
> -	    params->adev->family > AMDGPU_FAMILY_SI) {
> +	if (!params->unlocked) {
>  		amdgpu_vm_tlb_fence_create(params->adev, vm, fence);
>  
>  		/* Makes sure no PD/PT is freed before the flush */